From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2967 invoked by alias); 27 Apr 2012 15:14:33 -0000 Received: (qmail 2862 invoked by uid 22791); 27 Apr 2012 15:14:31 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Apr 2012 15:14:10 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SNms5-0006Mg-6Q from Maciej_Rozycki@mentor.com ; Fri, 27 Apr 2012 08:14:09 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 27 Apr 2012 08:14:08 -0700 Received: from [172.30.0.84] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Fri, 27 Apr 2012 16:14:06 +0100 Date: Fri, 27 Apr 2012 15:16:00 -0000 From: "Maciej W. Rozycki" To: Tom Tromey CC: Subject: Re: [RFA] MIPS16 FP manual call/return fixes In-Reply-To: Message-ID: References: <87r4va71oo.fsf@fleche.redhat.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00992.txt.bz2 On Thu, 26 Apr 2012, Maciej W. Rozycki wrote: > > Maciej> * value.h (using_struct_return): Likewise. > > > > I noticed that sparc-tdep.c calls this, but your patch doesn't update > > it. > > Good catch, thanks! I'll see how I can deal with that. It seems to me I > may be able to regression-test it too, let me see... So this was a red herring after all, the argument in question is NULL here, so the type does not matter as in some other places touched by the patch. Chances are I already considered it and disregarded before (by proofreading only, though) -- this patch is long-lived enough this may well have been many years ago, so I don't remember anymore. There are no regression for the sparc-solaris2.8 native target, GCC, using 32-bit and 64-bit (-m64) multilibs -- with the patch as is. However while attempting to do this I hit two problems for which I'll post patches separately: program name transformation breakage in gdb/configure and function prototype breakage in /proc services. Maciej