From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32276 invoked by alias); 28 Feb 2012 19:43:03 -0000 Received: (qmail 32266 invoked by uid 22791); 28 Feb 2012 19:43:03 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Feb 2012 19:42:50 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1S2Swi-00034P-Rp from Maciej_Rozycki@mentor.com ; Tue, 28 Feb 2012 11:42:48 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 28 Feb 2012 11:42:27 -0800 Received: from [172.30.13.146] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 28 Feb 2012 19:42:46 +0000 Date: Tue, 28 Feb 2012 19:49:00 -0000 From: "Maciej W. Rozycki" To: Pedro Alves CC: , Doug Evans , Joel Brobecker Subject: Re: Ping: [PATCH] testsuite: Add (extensive) hardware breakpoint testing In-Reply-To: <4F4D0B18.5040402@redhat.com> Message-ID: References: <4F4D0B18.5040402@redhat.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00670.txt.bz2 On Tue, 28 Feb 2012, Pedro Alves wrote: > I read the thread from the start, and I diffed the new proposed test against break.exp, > and I think we should go ahead and put this in. Only a couple remarks below. > > > +# Copyright 2012 Free Software Foundation, Inc. > > I think dropping the original copyright years was a mistake. TBH I've never been particularly convinced to do that since this is derived work (and clearly not in a trivial amount). Thanks for backing me up. > > +if { [prepare_for_testing hbreak2.exp "break" {break.c break1.c} {debug nowarnings}] } { > > s/"break"/"hbreak2", so that running this test doesn't overwrite break.exp's binary. > More instances of this. Good point, apparently there is just one other place requiring this adjustment. Thanks for your review, here's the resulting update. Any further thoughts, anyone? Maciej Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.base/hbreak2.exp =================================================================== --- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.base/hbreak2.exp 2012-02-28 18:50:20.455581421 +0000 +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.base/hbreak2.exp 2012-02-28 18:49:31.835596342 +0000 @@ -1,4 +1,5 @@ -# Copyright 2012 Free Software Foundation, Inc. +# Copyright 1988, 1990-1992, 1994-2000, 2002-2003, 2007-2012 Free +# Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -19,7 +20,7 @@ # the number available. -if { [prepare_for_testing hbreak2.exp "break" {break.c break1.c} {debug nowarnings}] } { +if { [prepare_for_testing hbreak2.exp "hbreak2" {break.c break1.c} {debug nowarnings}] } { return -1 } set srcfile break.c @@ -530,7 +531,7 @@ test_next_with_recursion # Build a new file with optimization enabled so that we can try breakpoints # on targets with optimized prologues. -if { [prepare_for_testing hbreak2.exp "breako2" {break.c break1.c} {debug nowarnings optimize=-O2}] } { +if { [prepare_for_testing hbreak2.exp "hbreak2o2" {break.c break1.c} {debug nowarnings optimize=-O2}] } { return -1 }