From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6121 invoked by alias); 2 Nov 2011 22:43:08 -0000 Received: (qmail 6113 invoked by uid 22791); 2 Nov 2011 22:43:07 -0000 X-SWARE-Spam-Status: No, hits=0.1 required=5.0 tests=AWL,BAYES_50 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 22:42:50 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1RLjWE-0000r2-4u from Maciej_Rozycki@mentor.com ; Wed, 02 Nov 2011 15:42:50 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 2 Nov 2011 15:41:33 -0700 Received: from [172.30.5.203] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Wed, 2 Nov 2011 22:42:47 +0000 Date: Wed, 02 Nov 2011 22:43:00 -0000 From: "Maciej W. Rozycki" To: Justin Lebar CC: Stan Shebs , Subject: Re: Status of 'blacklist' patch? In-Reply-To: Message-ID: References: <83ipnjs9i1.fsf@gnu.org> <83ipndc92n.fsf@gnu.org> <83ehy0ded8.fsf@gnu.org> <4EA753C4.60408@mentor.com> <4EAF2E0E.7080508@earthlink.net> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00057.txt.bz2 On Tue, 1 Nov 2011, Justin Lebar wrote: > Checked in, with two spaces after periods in comments. > > Thank you for your patience! > > -Justin > > 2011-10-06 Justin Lebar > > * Makefile.in: (SFILES): Add skip.c. > (HFILES_NO_SRCDIR): Add skip.h. > (COMMON_OBS): Add skip.o. > * skip.h, skip.c: New. > * breakpoint.h (set_default_breakpoint): Remove. > (get_sal_arch): Declare. > * breakpoint.c: Remove default_breakpoint_valid, > default_breakpoint_address, default_breakpoint_symtab, > default_breakpoint_line, default_breakpoint_pspace variables. > (get_sal_arch): Make public. > (set_default_breakpoint): Remove. > (parse_breakpoint_sals, create_breakpoint, clear_command, > decode_line_spec_1): Remove uses of default_breakpoint variables; > replaced with function calls into stack.c. > * cli/cli-cmds.h: Add cmd_list_element *skiplist. > * cli/cli-cmds.c: Add skiplist. > (init_cmd_lists): Initialize skiplist. > (init_cli_cmds): Fix comment (classes of commands appear in > alphabetical order). > * infrun.c (handle_inferior_event): Add check that we don't step into > a function whose pc is marked for skip. > * stack.c: Declare last_displayed_sal_valid, last_displayed_pspace, > last_displayed_addr, last_displayed_symtab, last_displayed_line > variables. > (set_last_displayed_sal): New static function. > (print_frame_info): Switch call to set_default_breakpoint to call to > set_last_displayed_sal. > (clear_last_displayed_sal, last_displayed_sal_is_valid, > get_last_displayed_pspace, get_last_displayed_addr, > get_last_displayed_symtab, get_last_displayed_line, > get_last_displayed_sal): New public functions. > * stack.h (clear_last_displayed_sal, last_displayed_sal_is_valid, > get_last_displayed_pspace, get_last_displayed_addr, > get_last_displayed_symtab, get_last_displayed_line, > get_last_displayed_sal): Declare. > > 2011-10-06 Justin Lebar > > Add tests for skip command. > * testsuite/gdb.base/skip-solib-lib.c: New > * testsuite/gdb.base/skip-solib-main.c: New > * testsuite/gdb.base/skip-solib.exp: New > * testsuite/gdb.base/skip.c: New > * testsuite/gdb.base/skip.exp: New > * testsuite/gdb.base/skip1.c: New > * testsuite/gdb.base/Makefile.in: Adding new files. This change broke the build of gdb.info: makeinfo --css-ref=../cs.css --split-size=5000000 --split-size=5000000 --split-size=5000000 -DHAVE_MAKEINFO_CLICK -I .../gdb/doc/../../readline/doc -I .../gdb/doc/../mi -I .../gdb/doc \ -o gdb.info .../gdb/doc/gdb.texinfo .../gdb/doc/gdb.texinfo:4899: warning: `.' or `,' must follow @xref, not `I'. .../gdb/doc/gdb.texinfo:4857: `Skipping Over Functions and Files' has no Up field(perhaps incorrect sectioning?). .../gdb/doc/gdb.texinfo:4857: warning: unreferenced node `Skipping Over Functionsand Files'. makeinfo: Removing output file `gdb.info' due to errors; use --force to preserve. make[5]: *** [gdb.info] Error 1 Also a ChangeLog entry is missing for changes to gdb.texinfo -- please fix that up. OK to apply the fix for the build errors below? 2011-11-02 Maciej W. Rozycki gdb/doc/ * gdb.texinfo (Skipping Over Functions and Files): Remove node designation. Fix "Specify Location" cross-reference. Maciej gdb-info-fix.diff Index: gdb-fsf-trunk-quilt/gdb/doc/gdb.texinfo =================================================================== --- gdb-fsf-trunk-quilt.orig/gdb/doc/gdb.texinfo 2011-11-02 21:25:50.000000000 +0000 +++ gdb-fsf-trunk-quilt/gdb/doc/gdb.texinfo 2011-11-02 22:22:53.495572496 +0000 @@ -4854,7 +4854,6 @@ proceed until the function returns. An argument is a repeat count, as in @code{next}. @end table -@node Skipping Over Functions and Files @subsection Skipping Over Functions and Files @cindex skipping over functions and files @@ -4896,7 +4895,7 @@ example, @code{skip file boring.c}. @itemx skip function @r{[}@var{linespec}@r{]} After running this command, the function named by @var{linespec} or the function containing the line named by @var{linespec} will be skipped over when -stepping. @xref{Specify Location} +stepping. @xref{Specify Location}. If you do not specify @var{linespec}, the function you're currently debugging will be skipped.