From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15278 invoked by alias); 2 Apr 2014 08:04:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15249 invoked by uid 89); 2 Apr 2014 08:04:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_BRBL_LASTEXT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 X-HELO: arjuna.pair.com Received: from arjuna.pair.com (HELO arjuna.pair.com) (209.68.5.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 02 Apr 2014 08:04:26 +0000 Received: (qmail 40083 invoked by uid 3006); 2 Apr 2014 08:04:24 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 2 Apr 2014 08:04:24 -0000 Date: Wed, 02 Apr 2014 08:04:00 -0000 From: Hans-Peter Nilsson To: Alan Modra cc: gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: vdso handling In-Reply-To: <20140328061321.GU18201@bubble.grove.modra.org> Message-ID: References: <20140313130322.GA3384@bubble.grove.modra.org> <5321C7C8.6000707@redhat.com> <5321C8FA.40708@gmail.com> <5321CE1A.20509@redhat.com> <20140313235347.GD3384@bubble.grove.modra.org> <20140318230939.GA9145@bubble.grove.modra.org> <5329879C.6070805@redhat.com> <20140320013305.GA13347@bubble.grove.modra.org> <532C5F60.80700@redhat.com> <20140328061321.GU18201@bubble.grove.modra.org> User-Agent: Alpine 2.02 (BSF 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00020.txt.bz2 On Fri, 28 Mar 2014, Alan Modra wrote: > > bfd_from_remote_memory should take note of p_memsz.. Hmm, and there > are quite a few other issues there too, most notably that p_align > on x86_64 these days tends to be *much* larger than the page size used > by ld.so. > > Gah, I've been sucked into looking at this long enough that I may as > well fix it. Does this look OK? The new size parameter uses size_t in bfd headers, breaking some simulators like cris-elf, frv-elf, h8300-elf, iq2000-elf, m32r-elf, mips-elf, mn10300-elf. The obvious change is to instead use bfd_size_type, like everything else in BFD headers. Any reason not to do that here? > * elfcode.h (bfd_from_remote_memory): Add "size" parameter. brgds, H-P