Re: Build regression on 32-bit hosts [Re: [PATCH] fix PR symtab/15597]

Tom Tromey
2013-10-09T15:46:06Z

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> opncls.c: In function ‘get_alt_debug_link_info_shim’:
Jan> opncls.c:1485:3: error: passing argument 2 of ‘bfd_get_alt_debug_link_info’ from incompatible pointer type [-Werror]
Jan> opncls.c:1211:1: note: expected ‘bfd_size_type *’ but argument is of type ‘size_t *’

I see my BFD record still stands.

Here's a follow-up.

Tom

2013-10-09 Tom Tromey <tromey@redhat.com>

* opncls.c (get_alt_debug_link_info_shim): Update type of 'len'.

Index: opncls.c
===================================================================
RCS file: /cvs/src/src/bfd/opncls.c,v
retrieving revision 1.84
diff -u -r1.84 opncls.c
--- opncls.c 9 Oct 2013 14:26:26 -0000 1.84
+++ opncls.c 9 Oct 2013 15:45:36 -0000
@@ -1480,7 +1480,7 @@
static char *
get_alt_debug_link_info_shim (bfd * abfd, unsigned long *crc32_out)
{
- size_t len;
+ bfd_size_type len;
bfd_byte *buildid = NULL;
char *result = bfd_get_alt_debug_link_info (abfd, &len, &buildid);