Re: [PATCH] fix PR symtab/15597

Doug Evans
2013-10-10T00:17:09Z

Tom Tromey writes:
> >>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
>
> Tom> This patch fixes gdb PR symtab/15597.
> Tom> The bug is that the .gnu_debugaltlink section includes the build-id of
> Tom> the alt file, but gdb does not use it.
>
> I'm checking in an updated version of this patch now.
> The only change is to fix the patch for the objfile_name change in gdb.
> I rebuilt and regtested this on x86-64 Fedora 18.
>
> Tom
>
> * bfd-in2.h: Rebuild.
> * opncls.c (bfd_get_alt_debug_link_info): Add buildid_len
> parameter. Change type of buildid_out. Update.
> (get_alt_debug_link_info_shim): New function.
> (bfd_follow_gnu_debuglink): Use it.
>
> * Makefile.in (SFILES): Add build-id.c.
> (HFILES_NO_SRCDIR): Add build-id.h.
> * build-id.c: New file, largely from elfread.c. Modified
> most functions.
> * build-id.h: New file.
> * dwarf2read.c (dwarf2_get_dwz_file): Update for change to
> bfd_get_alt_debug_link_info. Verify dwz file's build-id.
> Search for dwz file using build-id.
> * elfread.c (build_id_bfd_get, build_id_verify)
> (build_id_to_debug_filename, find_separate_debug_file): Remove.
>
> * gdb.dwarf2/dwzbuildid.exp: New file.
> * lib/dwarf.exp (Dwarf::_section): Add "flags" and "type"
> parameters.
> (Dwarf::_defer_output): Change "section" parameter to
> "section_spec"; update.
> (Dwarf::gnu_debugaltlink, Dwarf::_note, Dwarf::build_id): New
> procs.

So code was moved to a different file and edited in one step
(instead of moving it, and then editing it in a separate pass)?

[not that I mind per se, but I thought doing things that way
was more than just "nice to have"]