From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5741 invoked by alias); 14 Sep 2013 01:16:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5712 invoked by uid 89); 14 Sep 2013 01:16:16 -0000 Received: from arjuna.pair.com (HELO arjuna.pair.com) (209.68.5.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Sat, 14 Sep 2013 01:16:16 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50,KHOP_THREADED autolearn=ham version=3.3.2 X-HELO: arjuna.pair.com Received: (qmail 55035 invoked by uid 3006); 14 Sep 2013 01:16:13 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 14 Sep 2013 01:16:13 -0000 Date: Sat, 14 Sep 2013 01:16:00 -0000 From: Hans-Peter Nilsson To: gdb-patches@sourceware.org, binutils@sourceware.org cc: tromey@redhat.com Subject: Re: RFA: support in src-release to create a release-style sim.tar.bz2 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (BSF 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00415.txt.bz2 Ping! Also CC:ing Tromey as having special interest in this along with being able to approve it, presumably being "any global maintainer" as mentioned in /MAINTAINERS. On Fri, 6 Sep 2013, Hans-Peter Nilsson wrote: > I checked the CVS modules that would be completely inside the > binutils+gdb git and it appears the sim module is the only usable > stand-alone one. > > There are certainly "straddling" projects (having parts both inside > and outside binutils+gdb): insight and sid (not counting a historical > relic called old-gdb). I'll leave those to interested parties as > straddling projects will have to solve that problem before they can > make use of any non-stand-alone sub-part tar-balls of a binutils+gdb > repository (like the existing naked-* CVS modules). Sid may have to > be revived first. > > The do-proto-toplevel change is needed to support files in > SUPPORT_FILES with paths like gdb/version.in; the ln -s machinery > broke as you probably understand from the change. Beware that DIRS in > SIM_SUPPORT_DIRS is a misnomer but not a new one; single toplevel > files (not just directories) have been included in it, way before > this change. > > Tested by building a sim-7.6.50.20130906 out of a binutils+gdb > checkout using "make -f src-release sim.tar.bz2" and checking that the > difference to the "sim" CVS module was not unexpected compared to > e.g. the difference between a created binutils.tar.bz2 and the > "binutils" CVS module. > > N.B. this requires a patch to align sim/common/create-version.sh with > gdb/common/create-version.sh, posted to gdb-patches@. I expect to > commit that patch before this one. > > Ok to commit? > > toplevel: > * src-release (do-proto-toplevel): Support subdir-path-prefixed > files in SUPPORT_FILES. > (SIM_SUPPORT_DIRS): New variable. > (sim.tar.bz2): New rule. > > Index: src-release > =================================================================== > RCS file: /cvs/src/src/src-release,v > retrieving revision 1.36 > diff -p -u -r1.36 src-release > --- src-release 17 Aug 2013 01:07:52 -0000 1.36 > +++ src-release 7 Sep 2013 00:52:09 -0000 > @@ -165,7 +165,15 @@ do-proto-toplev: $(DEVO_SUPPORT) $(SUPPO > else \ > ln -s ../$$d proto-toplev/$$d ; \ > fi ; \ > - else ln -s ../$$d proto-toplev/$$d ; fi ; \ > + else \ > + if (echo x$$d | grep / >/dev/null); then \ > + mkdir -p proto-toplev/`dirname $$d` ; \ > + x=`dirname $$d` ; \ > + ln -s ../`echo $$x/ | sed -e 's,[^/]*/,../,g'`$$d proto-toplev/$$d ; \ > + else \ > + ln -s ../$$d proto-toplev/$$d ; \ > + fi ; \ > + fi ; \ > done > cd etc && $(MAKE) MAKEINFOFLAGS="$(MAKEINFOFLAGS)" info > $(MAKE) distclean > @@ -286,6 +294,14 @@ gdb.tar: $(DIST_SUPPORT) $(GDB_SUPPORT_D > MD5PROG="$(MD5PROG)" \ > SUPPORT_FILES="$(GDB_SUPPORT_DIRS)" > > +# Corresponding to the CVS "sim" module. > +.PHONY: sim.tar.bz2 > +SIM_SUPPORT_DIRS= bfd opcodes libiberty include intl gdb/version.in makefile.vms > +sim.tar.bz2: $(DIST_SUPPORT) $(SIM_SUPPORT_DIRS) sim > + $(MAKE) -f $(SELF) taz TOOL=sim \ > + MD5PROG="$(MD5PROG)" \ > + SUPPORT_FILES="$(SIM_SUPPORT_DIRS)" > + > .PHONY: insight.tar.bz2 > INSIGHT_SUPPORT_DIRS= $(GDB_SUPPORT_DIRS) tcl tk itcl libgui > insight.tar.bz2: $(DIST_SUPPORT) $(GDB_SUPPORT_DIRS) gdb > > brgds, H-P >