From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9644 invoked by alias); 27 Jun 2013 23:33:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9633 invoked by uid 89); 27 Jun 2013 23:33:32 -0000 X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from arjuna.pair.com (HELO arjuna.pair.com) (209.68.5.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with SMTP; Thu, 27 Jun 2013 23:33:02 +0000 Received: (qmail 65136 invoked by uid 3006); 27 Jun 2013 23:33:00 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 27 Jun 2013 23:33:00 -0000 Date: Fri, 28 Jun 2013 03:18:00 -0000 From: Hans-Peter Nilsson To: Tom Tromey cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: RFC: move common/version.in to gdb/ (Was: sim checkout broken) In-Reply-To: <87vc4zo5km.fsf_-_@fleche.redhat.com> Message-ID: References: <1371835865-15879-1-git-send-email-tromey@redhat.com> <871u7rwodv.fsf@fleche.redhat.com> <20130624224138.GC5326@adacore.com> <87y59ythcd.fsf@fleche.redhat.com> <20130625142141.GF5326@adacore.com> <87ppvatfsp.fsf@fleche.redhat.com> <87bo6ute8b.fsf@fleche.redhat.com> <878v1wrghn.fsf@fleche.redhat.com> <87bo6spakh.fsf@fleche.redhat.com> <877ghfppcx.fsf@fleche.redhat.com> <87zjubo9x0.fsf@fleche.redhat.com> <87vc4zo5km.fsf_-_@fleche.redhat.com> User-Agent: Alpine 2.02 (BSF 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2013-06/txt/msg00865.txt.bz2 On Thu, 27 Jun 2013, Tom Tromey wrote: > Tom> I think moving the file out of 'common' should help. > > Here's the patch. > > Let me know what you think. Thanks! It works, but it's sad to be forced to keep src/gdb/version.in. Though, I admit I didn't try much when I saw your patch, but at least I checked and it doesn't help moving the gdb-version-files to their own module alias. That's odd, because the src-support module alias *also* mentions non-pertinent (long gone) files; it seemed just the same as for the attempted gdb-version module below, except for gdb-version mentioning a file one directory deeper. So, I'm still somewhat lost as to what the reason is for that "Emptydir"-complaint and exit(1). I guess I could debug cvs, but I'm not really that deeply interested. Here's what I tried. Before that, as you probably imagine, I tried having gdb-version at the end of the sim module alias. Again: *DO NOT APPLY* the following patch; it's wrong; it doesn't make a difference: Index: modules =================================================================== RCS file: /home/hp/derp/srccvs/cvsfiles/CVSROOT/modules,v retrieving revision 1.79 retrieving revision 1.80 diff -p -u -r1.79 -r1.80 --- modules 25 Jun 2013 15:01:34 -0000 1.79 +++ modules 27 Jun 2013 22:27:52 -0000 1.80 @@ -135,11 +135,18 @@ dejagnu -a naked-dejagnu naked-expect n naked-texinfo naked-libiberty naked-include \ src/djunpack.bat +# This module, gdb-version, must not be mentioned last in any using +# module due to either file expected to be missing, or else CVS exits +# with non-zero value on subsequent checkouts, which is the required +# update method as "cvs update" "updates" by checking out the *rest* of +# the src tree. +gdb-version -a src/gdb/version.in \ + src/gdb/common/version.in + naked-sim -a src/sim sim -a naked-sim naked-bfd naked-opcodes \ naked-libiberty naked-include \ - src-support naked-intl src/gdb/version.in \ - src/gdb/common/version.in + src-support gdb-version naked-intl # OLD-GDB contains everything that ever was in GDB. It can be used to # check out out old GDB branches and as an approximation for an old *DO NOT APPLY* the patch above. > Once it goes in I will update the modules file. Not really necessary, but for the record, I verified that nothing bad happened (could still checkout**2 with exit 0) with the patch below in the local repo copy: Index: modules =================================================================== RCS file: /home/hp/derp/srccvs/cvsfiles/CVSROOT/modules,v retrieving revision 1.79 diff -p -u -r1.79 modules --- modules 25 Jun 2013 15:01:34 -0000 1.79 +++ modules 27 Jun 2013 23:02:42 -0000 @@ -138,8 +138,7 @@ dejagnu -a naked-dejagnu naked-expect n naked-sim -a src/sim sim -a naked-sim naked-bfd naked-opcodes \ naked-libiberty naked-include \ - src-support naked-intl src/gdb/version.in \ - src/gdb/common/version.in + src-support naked-intl src/gdb/version.in # OLD-GDB contains everything that ever was in GDB. It can be used to # check out out old GDB branches and as an approximation for an old Thank you for your efforts. If you want to try something else module-wise, I'll hang on to the repo copy for a little while longer, or maybe you want it uploaded to try something yourself (need to tweak config, commitinfo and loginfo to comment-out the sourceware-specific script calls). I think that'd take a few hours though, (the usual) asymmetric network speed factors apply here. brgds, H-P