From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26636 invoked by alias); 25 Mar 2012 14:26:00 -0000 Received: (qmail 26599 invoked by uid 22791); 25 Mar 2012 14:25:59 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sun, 25 Mar 2012 14:25:45 +0000 Received: (qmail 47960 invoked by uid 20157); 25 Mar 2012 14:25:44 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 25 Mar 2012 14:25:44 -0000 Date: Sun, 25 Mar 2012 14:26:00 -0000 From: Hans-Peter Nilsson To: Mike Frysinger cc: gdb-patches@sourceware.org Subject: Re: Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype" In-Reply-To: <201203250354.34883.vapier@gentoo.org> Message-ID: References: <1332476592-12930-1-git-send-email-vapier@gentoo.org> <201203241424.16156.vapier@gentoo.org> <201203250340.21803.vapier@gentoo.org> <201203250354.34883.vapier@gentoo.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00851.txt.bz2 On Sun, 25 Mar 2012, Mike Frysinger wrote: > On Sunday 25 March 2012 03:40:20 Mike Frysinger wrote: > > the BFD64 logic in gas' expr.c is fairly light. i'm not even sure it makes > > sense to key off of BFD64 since this code doesn't use bfd for number > > processing. it's just deciding whether to automatically upgrade bignum's > > into int64's. i'll post a patch to just delete the BFD64 logic there and > > see what people have to say. > > ok, digging a bit more, that isn't going to work. the gas parsing logic is > tied too closely to the bfd_vma type which is directly tied to the > aforementioned configure flag. > > since the fact.s test already tests both values (full & truncated), and in > reality the compiled code is the same for both (since gas does the > truncation), i've commented out the test that is larger than 32bits. For cris-elf there's a gas test I added (a loong time ago, before 1.1) that I never pursued, one with IIRC a temporarily overflowing expression; one of the temporaries truncated on 32-bit-bfd. I xfailed the test (gas/cris/shexpr-1) which makes it xpass on 64-bit-bfd. :/ Mea culpa. Maybe the same bug maybe slightly different, but the same 32-vs-64-bit-bfd basic reason. It'd be nice to have gas PR's for whatever you can blame on gas from the bfin sim tests. brgds, H-P