From: Simon Marchi <simark@simark.ca>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
gdb-patches@sourceware.org
Cc: Chris Packham <judge.packham@gmail.com>,
Luis <luis.machado.foss@gmail.com>, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH v2 0/2] GDB: aarch64-linux: Some header fixes
Date: Sat, 14 Feb 2026 09:30:45 -0500 [thread overview]
Message-ID: <afe89040-2cd7-419c-a41a-79c5789afef2@simark.ca> (raw)
In-Reply-To: <20260214045504.361392-1-thiago.bauermann@linaro.org>
On 2026-02-13 23:54, Thiago Jung Bauermann wrote:
> Patch 2 fixes the problem that I set out to fix in v1¹.
>
> Patch 1 grew out of Simon's patch review, where he noted that files in
> gdb/arch/ shouldn't depend on arch-specific include files.
>
> Thiago Jung Bauermann (2):
> GDB: aarch64-linux: Reorganize gdb/arch/aarch64-gcs-linux.h
> GDB: aarch64-linux: Fix build failure on musl systems
>
> gdb/Makefile.in | 2 +-
> gdb/aarch64-linux-nat.c | 4 +--
> gdb/aarch64-linux-tdep.c | 9 ++---
> gdb/aarch64-linux-tdep.h | 6 ++--
> .../{aarch64-gcs-linux.h => aarch64-linux.h} | 30 ++++------------
> gdb/nat/aarch64-linux.h | 15 ++++++++
> gdbserver/linux-aarch64-low.cc | 7 ++--
> gdbsupport/config.in | 3 ++
> gdbsupport/configure | 36 +++++++++++++++++++
> gdbsupport/configure.ac | 19 ++++++++++
> 10 files changed, 93 insertions(+), 38 deletions(-)
> rename gdb/arch/{aarch64-gcs-linux.h => aarch64-linux.h} (61%)
>
> ¹ https://inbox.sourceware.org/gdb-patches/20260211045853.1436881-1-thiago.bauermann@linaro.org/
From my point of view, these changes are going the right direction, but
I will let Luis handle the review and approval.
Simon
next prev parent reply other threads:[~2026-02-14 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 4:54 Thiago Jung Bauermann
2026-02-14 4:54 ` [PATCH v2 1/2] GDB: aarch64-linux: Reorganize gdb/arch/aarch64-gcs-linux.h Thiago Jung Bauermann
2026-02-14 9:38 ` Luis
2026-02-17 5:21 ` Thiago Jung Bauermann
2026-02-14 14:29 ` Simon Marchi
2026-02-17 5:10 ` Thiago Jung Bauermann
2026-02-17 15:35 ` Simon Marchi
2026-02-14 4:54 ` [PATCH v2 2/2] GDB: aarch64-linux: Fix build failure on musl systems Thiago Jung Bauermann
2026-02-14 14:30 ` Simon Marchi [this message]
2026-02-17 5:11 ` [PATCH v2 0/2] GDB: aarch64-linux: Some header fixes Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afe89040-2cd7-419c-a41a-79c5789afef2@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=judge.packham@gmail.com \
--cc=luis.machado.foss@gmail.com \
--cc=thiago.bauermann@linaro.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox