From: John Baldwin <jhb@FreeBSD.org>
To: Christian Biesinger <cbiesinger@google.com>,
Kamil Rytarowski <n54@gmx.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/5] Include the x86-bsd-nat.h header and fix the NetBSD/i386 build
Date: Wed, 23 Sep 2020 12:46:42 -0700 [thread overview]
Message-ID: <afe573c1-4016-c02a-9b4d-7d6d8b522f1c@FreeBSD.org> (raw)
In-Reply-To: <CAPTJ0XGu+JmNMTpqmWXMhDh-zZv-AK2xtdXe4QhzKzM6xAn7EA@mail.gmail.com>
On 9/23/20 6:15 AM, Christian Biesinger via Gdb-patches wrote:
> On Wed, Sep 23, 2020 at 6:26 AM Kamil Rytarowski <n54@gmx.com> wrote:
>>
>> In file included from ../../gdb/i386-nbsd-nat.c:26:
>> ../../gdb/i386-bsd-nat.h:34:53: error: expected template-name before '<' token
>> 34 | class i386_bsd_nat_target : public x86bsd_nat_target<BaseTarget>
>> | ^
>
> Seems like x86-bsd-nat.h should be included by i386-bsd-nat.h instead?
That might be a better fix yes. amd64-bsd-nat.h already includes x86-bsd-nat.h.
--
John Baldwin
next prev parent reply other threads:[~2020-09-23 19:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 4:25 [PATCH 0/5] Refine the NetBSD support Kamil Rytarowski
2020-09-23 4:25 ` [PATCH 1/5] Include the x86-bsd-nat.h header and fix the NetBSD/i386 build Kamil Rytarowski
2020-09-23 13:15 ` Christian Biesinger via Gdb-patches
2020-09-23 13:29 ` Kamil Rytarowski
2020-09-28 20:52 ` Simon Marchi
2020-09-23 19:46 ` John Baldwin [this message]
2020-09-23 4:25 ` [PATCH 2/5] Preinitialize the sockaddr_un variable to zero Kamil Rytarowski
2020-09-28 20:57 ` Simon Marchi
2020-09-23 4:25 ` [PATCH 3/5] Refactor the NetBSD amd64 gdbserver support Kamil Rytarowski
2020-09-28 21:11 ` Simon Marchi
2020-09-23 4:25 ` [PATCH 4/5] Add NetBSD/i386 " Kamil Rytarowski
2020-09-23 4:25 ` [PATCH 5/5] Remove the old sanity check of sigcontext offsets for NetBSD/i386 Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afe573c1-4016-c02a-9b4d-7d6d8b522f1c@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox