From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82911 invoked by alias); 2 Jun 2018 10:26:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82899 invoked by uid 89); 2 Jun 2018 10:26:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=UD:list-thread-groups-available.exp X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 02 Jun 2018 10:26:20 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E4F64C12AB; Sat, 2 Jun 2018 10:26:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 113AF2166BB2; Sat, 2 Jun 2018 10:26:17 +0000 (UTC) Subject: Re: [RFC] (windows) GDB/MI crash when using "-list-thread-groups --available" To: Joel Brobecker References: <1525978704-70543-1-git-send-email-brobecker@adacore.com> <20180602005941.f4l5nudlsl3xez4v@adacore.com> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Sat, 02 Jun 2018 10:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180602005941.f4l5nudlsl3xez4v@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00042.txt.bz2 On 06/02/2018 01:59 AM, Joel Brobecker wrote: > Thanks for the pointer. I've taken the liberty of updating our > testcase cookbook to reference it as well, so we know where to > look next time we hit that issue. Good idea, thanks. > > Attached is an updated version which follows the same principle. > > gdb/ChangeLog: > > * windows-nat.c (windows_nat_target::xfer_partial): Return > TARGET_XFER_E_IO if we need to delegate to the target beneath > but BENEATH is NULL. > > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-list-thread-groups-no-inferior.exp: New testcase. > > Test verified on x86_64-linux to confirm that the large amount of > output is properly handled. > > OK to push? It looks good to me. A few comments on minor details follow. How about naming the testcase list-thread-groups-no-inferior.exp (no "mi-") so that it sits side-by-side with list-thread-groups-available.exp? We're missing an intro comment in the .exp file mentioning what the testcase is about, otherwise it's not clear why we have two separate testcases for seemingly the same thing. A couple microscopic nits more: > +gdb_test_multiple $test $test { > + -re ".*\}" { Leading ".*" is not necessary, it's implied. > +mi_gdb_test "-data-evaluate-expression 1" \ > + ".*\\^done,value=\"1\"" \ > + "check GDB is still alive" > + "check" and "test" in test messages is one of my pet peeves. OK, I'm really exaggerating. :-) The point is that all tests are checking something, making it redundant. "GDB is still alive" or even "GDB is alive" says the same. Thanks, Pedro Alves