From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122715 invoked by alias); 14 Feb 2020 19:48:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122282 invoked by uid 89); 14 Feb 2020 19:48:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Feb 2020 19:48:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581709734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+xNfefkTCX6LWeLpIfxoZwQA96NRMawclma/ggdhEyk=; b=Qkcf8oevpT7RXpGX9blo3+WkWXHFfmxeK0lK5FW+mktFfc5LieZuE9WfmeG+IScMnUZKLG 0+iOkUUGwPybRO3ztcKaeRQCBQ0Fhm+MWpWq+OBgIL36xJgJ2+EVUrIG39x3Qb2OECKLxO 8IIJXnZWC5cOK04XOi5w3lsrmxeWKY0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-lVposlEANCSXsUj2LT0c0g-1; Fri, 14 Feb 2020 14:48:50 -0500 Received: by mail-wm1-f71.google.com with SMTP id f207so4447257wme.6 for ; Fri, 14 Feb 2020 11:48:50 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id z11sm8067227wrv.96.2020.02.14.11.48.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Feb 2020 11:48:48 -0800 (PST) Subject: Re: [PATCH 2/2] gdb: make gdbarch_displaced_step_copy_insn return an std::unique_ptr To: Simon Marchi , gdb-patches@sourceware.org References: <20200122151410.30012-1-simon.marchi@efficios.com> <20200122151410.30012-2-simon.marchi@efficios.com> From: Pedro Alves Message-ID: Date: Fri, 14 Feb 2020 19:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00579.txt.bz2 BTW, when I see a bunch of std::unique_ptr I wonder whether a footype_up typedef wouldn't make things read a bit clearer. Thanks, Pedro Alves