Re: [PATCH 6/7] gdb: select "Cygwin" OS ABI for Cygwin binaries

Simon Marchi
2020-03-16T18:18:01Z

On 2020-03-16 2:16 p.m., Christian Biesinger wrote:
>> @@ -898,6 +900,105 @@ static const struct internalvar_funcs tlb_funcs =
>> NULL
>> };
>>
>> +/* Layout of an element of a PE's Import Directory Table. Based on:
>> +
>> + https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#import-directory-table
>> + */
>> +
>> +struct pe_import_directory_entry
>> +{
>> + uint32_t import_lookup_table_rva;
>> + uint32_t timestamp;
>> + uint32_t forwarder_chain;
>> + uint32_t name_rva;
>> + uint32_t import_address_table_rva;
>> +};
>> +
>> +gdb_static_assert (sizeof (pe_import_directory_entry) == 20);
>> +
>> +/* Return true if the Portable Executable behind ABFD uses the Cygwin dll
>> + (cygwin1.dll). */
>> +/* See windows-tdep.h. */
>
> Remove the first of these two comments?

Indeed, thanks.

Simon