From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-137050-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26636 invoked by alias); 15 Feb 2017 23:06:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 26584 invoked by uid 89); 15 Feb 2017 23:06:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*MI:sk:87o9y3n, Hx-languages-length:1271, H*f:sk:87o9y3n, H*i:sk:87o9y3n
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Feb 2017 23:06:23 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id C78307E9C0;	Wed, 15 Feb 2017 23:06:23 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1FN6LAr028929;	Wed, 15 Feb 2017 18:06:21 -0500
Subject: Re: [PATCH] PR gdb/21164: maint print {symbols,msymbols,psymbols} without args crash
To: Sergio Durigan Junior <sergiodj@redhat.com>
References: <20170215201548.29225-1-sergiodj@redhat.com> <caaa55bc-33c6-b012-5e41-936a20b362b9@redhat.com> <87o9y3njyk.fsf@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, Doug Evans <xdje42@gmail.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <afabaf9c-ab6a-cf38-f641-28dba2f172d1@redhat.com>
Date: Wed, 15 Feb 2017 23:06:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <87o9y3njyk.fsf@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-02/txt/msg00427.txt.bz2

On 02/15/2017 10:54 PM, Sergio Durigan Junior wrote:
> On Wednesday, February 15 2017, Pedro Alves wrote:
> 
>> On 02/15/2017 08:15 PM, Sergio Durigan Junior wrote:
>>
>>> This patch fixes that.  OK to apply?
>>
>> Can you add some tests for this, please?
> 
> How about this?

Awesome, thanks!  OK with minor nits.

> commit acd6597d63b2501588318466cd308701d09a58f3
> Author: Sergio Durigan Junior <sergiodj@redhat.com>
> Date:   Wed Feb 15 15:08:19 2017 -0500

>     Hi,

...remove this above...

>     This patch fixes that.  OK to apply?

...and this "OK" from the commit log and...

> diff --git a/gdb/testsuite/gdb.base/maint.exp b/gdb/testsuite/gdb.base/maint.exp
> index 2853508..b87cbfc 100644
> --- a/gdb/testsuite/gdb.base/maint.exp
> +++ b/gdb/testsuite/gdb.base/maint.exp
> @@ -561,6 +561,14 @@ gdb_expect {
>  
>  #set timeout $oldtimeout
>  
> +# Testing that the commands work without an argument.  For this test,

Write "Test that" here.

> +# we don't need an inferior loaded/running.
> +# See PR gdb/21164.
> +gdb_exit
> +gdb_start
> +gdb_test_no_output "maint print symbols"
> +gdb_test_no_output "maint print msymbols"
> +gdb_test_no_output "maint print psymbols"

Thanks,
Pedro Alves