From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127464 invoked by alias); 26 Jan 2019 04:41:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127451 invoked by uid 89); 26 Jan 2019 04:41:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:610 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Jan 2019 04:41:46 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x0Q4fdf4030540 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 25 Jan 2019 23:41:44 -0500 Received: by simark.ca (Postfix, from userid 112) id A2E271E7BB; Fri, 25 Jan 2019 23:41:39 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id E969A1E50C; Fri, 25 Jan 2019 23:41:38 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 26 Jan 2019 04:41:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Update create-version.sh to use common/version.h In-Reply-To: <87pnskm5dp.fsf@tromey.com> References: <20190123172954.24421-1-tom@tromey.com> <20190123172954.24421-2-tom@tromey.com> <6adb597a88e229b7996d156ea8208438@polymtl.ca> <87tvhwm5nr.fsf@tromey.com> <87pnskm5dp.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00557.txt.bz2 On 2019-01-25 23:04, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> How about just copying create-version.sh to sim/common and having > it use > Tom> the old #include "version.h"? Then the two scripts can evolve in > their > Tom> own ways as needed, without worrying. > > Like this. This is fine with me, but the diff below is weird. It modifies sim/common/create-version.sh, which doesn't exist in master currently. And if I apply it with "git am -3", then gdb/common/create-version.sh gets modified... Simon