From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109373 invoked by alias); 10 Jul 2018 03:23:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109019 invoked by uid 89); 10 Jul 2018 03:23:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jul 2018 03:23:38 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 490EA1E059; Mon, 9 Jul 2018 23:23:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531193016; bh=Cc1SwHgkAPc88se06MR15BH28vgdTgqv+mE0u20XT7s=; h=Subject:To:References:From:Date:In-Reply-To:From; b=RLH8qOhqYFupNxRwPueGy2mLM3qIysXmZ7gWg0WIJ1Yn7xtVD4m0NzFN1JPGIFBj2 hu0Rr9Idq7ErIqlD+oChwCwak1b2xPU0KeTo4v0Or1mZ85pFdQasrEbHoyVqoWk7eE kOQkue8zX0SeQWa8YpgsFXbcHW8u7Me9XmBpQK4A= Subject: Re: [RFA 28/42] Set list_in_scope later in DWARF reader To: Keith Seitz , Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-29-tom@tromey.com> From: Simon Marchi Message-ID: Date: Tue, 10 Jul 2018 03:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00244.txt.bz2 On 2018-07-06 02:11 PM, Keith Seitz wrote: > On 05/22/2018 09:58 PM, Tom Tromey wrote: >> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c >> index 3cc15ab645..f7cca01445 100644 >> --- a/gdb/dwarf2read.c >> +++ b/gdb/dwarf2read.c >> @@ -21138,6 +21134,8 @@ dwarf2_start_symtab (struct dwarf2_cu *cu, >> = start_symtab (cu->per_cu->dwarf2_per_objfile->objfile, name, comp_dir, >> low_pc, cu->language); >> >> + cu->list_in_scope = get_file_symbols (); >> + >> record_debugformat ("DWARF 2"); >> record_producer (cu->producer); >> >> > > Warning: `get_file_symbols' is undefined until the next patch. > > Keith > Indeed, though the principle sounds good. Simon