From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8xKfAEaxk2g+cwUAWB0awg (envelope-from ) for ; Wed, 06 Aug 2025 15:47:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1754509637; bh=vXo0TljqfyPp9JA+ZaFo3nLjPok8JVzP90wWl+3hF7M=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=H2PAfDtpIekpsRUY4iM8ro2kreuoMFivAhq5dKa8xeSzvGp/c9dsIOIo1Tuq4PaNH JOf62sHoj04Eamsw47BD9w480g/cAG1PrRnfMmC7m41lTbEH+J6K8ijCkNzCdxBKzR rjQFjzMtcSKJxwPyiVLYHYxO/lgxadGM6ErxIcvM= Received: by simark.ca (Postfix, from userid 112) id E5C0A1E100; Wed, 6 Aug 2025 15:47:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=jkAd+DCu; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Z0ScUgAM; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 68E6D1E091 for ; Wed, 6 Aug 2025 15:47:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 176DF385840C for ; Wed, 6 Aug 2025 19:47:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 176DF385840C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=jkAd+DCu; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Z0ScUgAM Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D38D43858D21 for ; Wed, 6 Aug 2025 19:46:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D38D43858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D38D43858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754509606; cv=none; b=vnJR2A05HbE/4VNzLIksMGlWDPxj/Vk2vwr3S6ek+spAkLzg0M1yq5HHZC9NOaZbhczxI5U+NTH+ym60wZgdzX2L03Y+IMX0E3ffwJzOUMLhHPC6MAZF/q9ma0ohUuXYCMsIygvihunyBEkpXkRqHsnwggro1m0ozI+5qN62EM8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754509606; c=relaxed/simple; bh=vXo0TljqfyPp9JA+ZaFo3nLjPok8JVzP90wWl+3hF7M=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=n5LX8/5OVY5s5c3Wzk/7Qhxg0MOilrc9JYzrUFlRnACKz+MvUkxBlaG5TJn/zvqdNdMyNFS0vW5047O261/wJPlMaF/NhQd6S6/1J8pFEV6h2xzPTjSuq6AGNhH8LQCRsfyrdbklwS7mbt/OHT7Mxa0DO0skeZZd0M4xIUNzo4s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D38D43858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1754509606; bh=vXo0TljqfyPp9JA+ZaFo3nLjPok8JVzP90wWl+3hF7M=; h=Date:Subject:To:References:From:In-Reply-To:From; b=jkAd+DCu73ZNmxxUy4J0SSwxv5wOqPDU/zXsHsDHfAmxPycHW+aN6Qu4NCjdbF+uS kXnbB//UmMz65GdlXwN7PMhZaMkeIM/xq55V/1vWRbzAn6zVwZG4Lrw6G+e/+/I1Dk fE7CS83rhN1z/uR7PXW/VcTniOXiDvjbDLZTXg1o= Received: by simark.ca (Postfix, from userid 112) id 90D1B1E100; Wed, 6 Aug 2025 15:46:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1754509605; bh=vXo0TljqfyPp9JA+ZaFo3nLjPok8JVzP90wWl+3hF7M=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Z0ScUgAMgZAeAoTL3XnprmB9MVLjlK+W4T0p9+cyCHfDltgR3Z1tj9TyTC3YZoovn yB1P0VILGyL2Gy81Wv1vPsL20Z0Qgan2H3dWL8uM5LVLPfGPHD1vnGCSL73E0eta29 QjTjEIP6zDwFXV6xOD3vo6aiT96JcEYPG3YYOJyY= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D35DD1E091; Wed, 6 Aug 2025 15:46:45 -0400 (EDT) Message-ID: Date: Wed, 6 Aug 2025 15:46:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Use gnulib c-ctype module, not To: Tom Tromey , gdb-patches@sourceware.org References: <20250806-gnulib-c-ctype-v1-0-10f33e9f22a4@adacore.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20250806-gnulib-c-ctype-v1-0-10f33e9f22a4@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/6/25 9:13 AM, Tom Tromey wrote: > This series changes gdb to use the gnulib c-ctype module rather than > or "safe-ctype.h". > > The rationale is mostly in patch #3. I do wonder if it would be > better to just add the casts everywhere. > > Regression tested on x86-64 Fedora 41. This doesn't cover > solib-rocm.c though. > > Signed-off-by: Tom Tromey My understanding is that poisoning using macros doesn't work, because it interferes with identifiers of the same name in other headers. But would it be possible to do it using "#pragma GCC poison"? Like: #pragma GCC poison isspace If I try to use it, I get: CXX cp-support.o /home/smarchi/src/binutils-gdb/gdb/cp-support.c:1137:22: error: attempt to use poisoned ‘isspace’ 1137 | while (isspace(name[index])) | ^ In file included from /home/smarchi/src/binutils-gdb/gdb/defs.h:26, from : /home/smarchi/src/binutils-gdb/gdb/../gdbsupport/common-defs.h:231:20: note: poisoned here 231 | #pragma GCC poison isspace | ^~~~~~~ This pragma can obviously be gated by an appropriate ifdef, if not all compilers support it. I was wondering if clang-tidy would have a check for this. The answer is no, but there is a bug open about it: https://github.com/llvm/llvm-project/issues/63280 Simon