From: Simon Marchi <simark@simark.ca>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: enable -Wmissing-prototypes warning
Date: Wed, 11 Mar 2020 15:16:03 -0400 [thread overview]
Message-ID: <af09abf4-a94f-4342-e1a8-2711db80da53@simark.ca> (raw)
In-Reply-To: <20200303223442.330-1-simon.marchi@efficios.com>
On 2020-03-03 5:34 p.m., Simon Marchi wrote:
> While compiling with clang, I noticed it didn't catch cases where my
> function declaration didn't match my function definition. This is
> normally caught by gcc with -Wmissing-declarations.
>
> On clang, this is caught by -Wmissing-prototypes instead.
>
> Note that on gcc, -Wmissing-prototypes also exists, but is only valid
> for C and Objective-C. It gets correctly rejected by the configure
> script since gcc rejects it with:
>
> cc1plus: error: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++ -Werror
>
> So this warning flag ends up not used for gcc (which is what we want).
>
> gdb/ChangeLog:
>
> * configure: Re-generate.
>
> gdbserver/ChangeLog:
>
> * configure: Re-generate.
>
> gdbsupport/ChangeLog:
>
> * configure: Re-generate.
> * warning.m4: Enable -Wmissing-prototypes.
I just pushed this patch.
Simon
next prev parent reply other threads:[~2020-03-11 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 22:34 Simon Marchi
2020-03-11 19:16 ` Simon Marchi [this message]
2021-11-04 12:00 ` gdb: disable -Wmissing-prototypes warning w/gcc Mike Frysinger via Gdb-patches
2021-11-04 12:17 ` Andrew Burgess via Gdb-patches
2021-11-04 12:59 ` Simon Marchi via Gdb-patches
2021-11-04 18:43 ` Simon Marchi via Gdb-patches
2021-11-04 20:18 ` Mike Frysinger via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af09abf4-a94f-4342-e1a8-2711db80da53@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox