From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111118 invoked by alias); 17 Sep 2019 12:43:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111103 invoked by uid 89); 17 Sep 2019 12:43:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Sep 2019 12:43:24 +0000 Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B00D41E093; Tue, 17 Sep 2019 08:43:22 -0400 (EDT) Subject: Re: [PATCH v3] Change boolean options to bool instead of int To: Christian Biesinger , gdb-patches@sourceware.org References: <20190917032624.65172-1-cbiesinger@google.com> From: Simon Marchi Message-ID: Date: Tue, 17 Sep 2019 12:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190917032624.65172-1-cbiesinger@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-09/txt/msg00313.txt.bz2 On 2019-09-16 11:26 p.m., Christian Biesinger via gdb-patches wrote: > This is for add_setshow_boolean_cmd as well as the gdb::option interface. Thanks, this LGTM, please push. And thanks for trying to cover the various native files. If we missed something and it causes a build failure on some configuration, it should be trivial to fix. Simon