From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SSxPFAIQrGoSXRcAWB0awg (envelope-from ) for ; Thu, 17 Sep 2026 12:06:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H+kzDCn5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 44EE11E06A; Thu, 17 Sep 2026 12:06:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BD52E1E01F for ; Thu, 17 Sep 2026 12:06:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EB4014BAE7E5 for ; Thu, 17 Sep 2026 16:06:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB4014BAE7E5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H+kzDCn5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 2A0854BAE7DA for ; Thu, 17 Sep 2026 16:05:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A0854BAE7DA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A0854BAE7DA Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789661155; cv=none; b=n2+zd97JztyzDx0tPguZSro8Jbf3bgT06/LgWi0jBc2y+pR0Vd3oSmArI+alqSaqwNgfTEGNm7pIy1ia5phgx2jXgGcd8pxYo8JWSJDcMAs48Q5d9MPp7AIIyHTV1hDKsIpKicOQK8auKCTr8ABLO3ozOJIF/0p7gKRa+knwtao= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789661155; c=relaxed/simple; bh=VUdE4AA8u56+SmEUoFNGou4ny119fQYAHhe7iEikfZ4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=le0HozuOJKDo7EAdFlB0FLYCBcgTmzv6tCRzUUAwjUlpPJNrTuXK+a2y/Q3M5l518RK1XD6oo6bsPAJR/Leh/uaVMQyfqW4+Ch32073vV/+UAORFBLqWrF0lrXmV5SF9khMy5fRwxXlcNraVE70yKoocanFVPb6rxlYo4Q9j1MM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H+kzDCn5 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A0854BAE7DA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789661154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6yb4mDvYoeHI9TxN011ZNtpNZR3CaFyqSN4xxf7o6vo=; b=H+kzDCn52dRJA0zzlIi5+nVeu6I/IljEccbB9R21yWYYa2RXlK5DosyipooU3nnEzetp+2 158c1B1ITv8MY7SqvKaWZxdvSv41iBeKllywUaAi7r2lzveWwM5tLADk/QOh92GTPuWmA3 SAx7cnOeqSux3j5P1wcaq1nLtsrup3Y= Received: from mail-yx1-f70.google.com (mail-yx1-f70.google.com [74.125.224.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-pFfmBowhNsCFlPiUWgJxHA-1; Thu, 17 Sep 2026 12:05:53 -0400 X-MC-Unique: pFfmBowhNsCFlPiUWgJxHA-1 X-Mimecast-MFC-AGG-ID: pFfmBowhNsCFlPiUWgJxHA_1789661153 Received: by mail-yx1-f70.google.com with SMTP id 956f58d0204a3-67124ce8015so1055726d50.0 for ; Thu, 17 Sep 2026 09:05:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789661153; x=1790265953; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6yb4mDvYoeHI9TxN011ZNtpNZR3CaFyqSN4xxf7o6vo=; b=wKySNIuvxzojf9rciLajK+Y3tYMjd2PPa1jyKOr+rrCvyqWSaRCRJKFCdfTo0MurFl +GZ4BPVorgjvwQ1J9WIT/nIUxh1XnfCUaFBB6oChjRf5kkAvj0fLxLwhUqQxA1krjZZl oC98iN+UnCm9WbU+b53Z7pPrxQ7ZtcgmjnFo8bjsCwP+hqJJsPvKm8LIn7r0jIBSIetI NogN1cTJHg3IJFs22PMWnPah7S/hvr/YST50joSYfgj8T8DhiIbrVnbhmG5W4ha3pa6k Rnngyg9I2h3wxuGtdut16YuaVvBeiTNxgWLnLbZSWNZYTGgcX8vAfm1CVdqukIVYc9h1 LYcA== X-Gm-Message-State: AFuF++nim7CI7Nb8dyzCZgoGukaA9lwkqnLZIUaxinpc2eYIp3Nx65Es 5b8e6r7hKD+yJu0/pm1mUFI9xbjXE5P2O1Kh4HAWc5/1PwfFXSyXlDXfMaXKgpIoi9IuiCoT116 TFwK/WyHuccInzoF0SHD9/aZ5ovtTp8gWbvAnaoM00o9Bc+9/YxstqpK+2Eo2ekQ= X-Gm-Gg: AYBFou2ejuo7cooN18CdVUMtNg01HXqRmpXDsVvqArbp20i9BwLrJiCTOHFhKevImOb M3XcJqMdxHop1/yPWRism4pWmDiHs5jzcdQAOapyxaJE7W3dSXMPBv+uRVqHv66oR2pSJHAZ2RO EJNdeVVRsNZBULbb0meJQGS8ciZQBb/wRKc9NXxhvv7uon5UgGyqiTuu0bSuST7xCa6ePl+3NYY 9vhw7tg2IKeWuzpDYuqQma+lU12r++hfAccQdbIkMVlP+dLnFl97w8pWht77J+K3pJbcu040X8N 4aBvarRVeaaEzASiGPCyW3mH8gHI21QF6LNGwRqib76UqJ5wL8UAYb4O/aR0J7mCpnEwcpi7Qk0 b4zbw8RU= X-Received: by 2002:a05:690e:1516:b0:671:409f:90cf with SMTP id 956f58d0204a3-67163205a67mr2055965d50.15.1789661152956; Thu, 17 Sep 2026 09:05:52 -0700 (PDT) X-Received: by 2002:a05:690e:1516:b0:671:409f:90cf with SMTP id 956f58d0204a3-67163205a67mr2055959d50.15.1789661152490; Thu, 17 Sep 2026 09:05:52 -0700 (PDT) Received: from [150.1.200.157] ([172.56.108.234]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6715f6ba8eesm2757094d50.6.2026.09.17.09.05.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2026 09:05:51 -0700 (PDT) Message-ID: Date: Thu, 17 Sep 2026 09:05:49 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Add infcall support for C++ constructor-style expressions To: Andrew Burgess , Kevin Buettner Cc: gdb-patches@sourceware.org References: <20260626170308.69c33832@f44-mesa-1> <87bj9waqk3.fsf@redhat.com> From: Keith Seitz In-Reply-To: <87bj9waqk3.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CXS_p9GOlaIHb1F7nYS8Yqk_9oanR2PQy0BYjm-u3WE_1789661153 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/17/26 7:41 AM, Andrew Burgess wrote: > > If that was my review, then please do feel free to ignore it. My review > comments are not always based on tested code, usually just my thoughts > when looking through the patch, that doesn't always mean the thoughts > are any good :) In order to solve the additional SR conflicts, I've had to redesign a good chunk of the patch. It's been a struggle, but I am finally testing a new patch which I think will cover all the bases. Thanks for the review. Keith