From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCHv2 1/2] gdb: Split func_command into two parts.
Date: Mon, 21 May 2018 16:06:00 -0000 [thread overview]
Message-ID: <aedbb3b4-892a-5ff1-4961-26e79f703727@redhat.com> (raw)
In-Reply-To: <20180521152701.GT3797@embecosm.com>
On 05/21/2018 04:27 PM, Andrew Burgess wrote:
> As the structure was so small, and only used in that one function, I
> moved the structure into the function entirely (and added an updated
> comment to both the structure, and the function). I had a little look
> through GDB and there are a few other cases of structures declared
> within a function, so hopefully this is OK. Let me know if you'd
> rather see this moved back out again.
This is fine with me as is. Feel free to push it in immediately
to get it out of the way.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-05-21 15:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 16:58 [PATCHv2 0/2] Changes to frame selection Andrew Burgess
2018-05-08 16:58 ` [PATCHv2 1/2] gdb: Split func_command into two parts Andrew Burgess
2018-05-18 19:57 ` Pedro Alves
2018-05-21 15:52 ` Andrew Burgess
2018-05-21 16:06 ` Pedro Alves [this message]
2018-05-08 16:59 ` [PATCHv2 2/2] gdb: Change how frames are selected for 'frame' and 'info frame' Andrew Burgess
2018-05-11 15:44 ` Eli Zaretskii
2018-05-21 12:16 ` Andrew Burgess
2018-05-21 17:46 ` Eli Zaretskii
2018-06-05 18:53 ` Andrew Burgess
2018-06-05 21:16 ` Philippe Waroquiers
[not found] ` <20180606082211.GF15881@embecosm.com>
2018-06-06 14:56 ` Eli Zaretskii
2018-06-07 16:19 ` [PATCHv3] " Andrew Burgess
2018-06-29 12:23 ` Andrew Burgess
2018-07-17 15:58 ` [PATCHv4] " Andrew Burgess
2018-07-23 20:46 ` Philippe Waroquiers
2018-07-25 18:14 ` Andrew Burgess
2018-08-13 22:20 ` [PATCHv5 0/2] " Andrew Burgess
2018-08-14 10:31 ` Philippe Waroquiers
2018-08-21 13:10 ` Joel Brobecker
2018-08-27 11:04 ` Andrew Burgess
2018-08-27 15:23 ` Eli Zaretskii
2018-08-28 8:43 ` Andrew Burgess
2018-08-28 9:08 ` Eli Zaretskii
2018-08-28 18:03 ` [PATCHv6] " Andrew Burgess
2018-08-28 18:20 ` Eli Zaretskii
2018-09-05 7:46 ` PING: " Andrew Burgess
2018-09-13 18:02 ` Pedro Alves
2018-09-18 23:01 ` Andrew Burgess
2018-09-19 16:26 ` Pedro Alves
2018-09-26 23:06 ` Andrew Burgess
2018-09-27 20:58 ` Pedro Alves
2018-08-13 22:20 ` [PATCHv5_A 1/2] " Andrew Burgess
[not found] ` <cover.1534197765.git.andrew.burgess@embecosm.com>
2018-08-13 22:20 ` [PATCHv5_B 2/2] " Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aedbb3b4-892a-5ff1-4961-26e79f703727@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox