From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
To: gdb-patches@sourceware.org
Cc: palves@redhat.com
Subject: [PATCH v7 3/5] gdb/remote: do not delete a thread if it has a pending exit event
Date: Wed, 22 Apr 2020 17:00:55 +0200 [thread overview]
Message-ID: <aed77a26d982e64c0389aba7690b70768cc4ecf1.1587563226.git.tankut.baris.aktemur@intel.com> (raw)
In-Reply-To: <cover.1587563226.git.tankut.baris.aktemur@intel.com>
gdb/ChangeLog:
2020-04-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* remote.c (remote_target::update_thread_list): Do not delete
a thread if it has a pending exit event.
---
gdb/remote.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/gdb/remote.c b/gdb/remote.c
index 5db406e045c..a1fbaa02fb1 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -3822,6 +3822,14 @@ remote_target::update_thread_list ()
if (tp->inf->process_target () != this)
continue;
+ /* Do not remove the thread if it has a pending exit event.
+ Otherwise we may end up with a seemingly live inferior
+ (i.e. pid != 0) that has no threads. */
+ if (tp->suspend.waitstatus_pending_p
+ && (tp->suspend.waitstatus.kind == TARGET_WAITKIND_SIGNALLED
+ || tp->suspend.waitstatus.kind == TARGET_WAITKIND_EXITED))
+ continue;
+
if (!context.contains_thread (tp->ptid))
{
/* Not found. */
--
2.17.1
next parent reply other threads:[~2020-04-22 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1587563226.git.tankut.baris.aktemur@intel.com>
2020-04-22 15:00 ` Tankut Baris Aktemur [this message]
2020-05-04 14:43 ` Pedro Alves
2020-05-04 15:33 ` Aktemur, Tankut Baris
2020-05-13 14:20 ` Pedro Alves
2020-04-22 15:00 ` [PATCH v7 5/5] gdb/infrun: handle already-exited threads when attempting to stop Tankut Baris Aktemur
2020-04-22 16:07 ` Aktemur, Tankut Baris
2020-05-03 15:38 ` Aktemur, Tankut Baris
2020-05-13 21:15 ` Pedro Alves
2020-05-14 8:50 ` Aktemur, Tankut Baris
2020-05-14 11:32 ` Pedro Alves
2020-05-14 11:42 ` Aktemur, Tankut Baris
2020-05-14 11:25 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aed77a26d982e64c0389aba7690b70768cc4ecf1.1587563226.git.tankut.baris.aktemur@intel.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox