From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0XzEJQwBUWpD0QEAWB0awg (envelope-from ) for ; Fri, 10 Jul 2026 10:26:20 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IPG3mPBc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 94C1C1E098; Fri, 10 Jul 2026 10:26:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 09CB91E070 for ; Fri, 10 Jul 2026 10:26:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A727C4BA23E6 for ; Fri, 10 Jul 2026 14:26:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A727C4BA23E6 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IPG3mPBc Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id F1E084BA23CF for ; Fri, 10 Jul 2026 14:24:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1E084BA23CF Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F1E084BA23CF Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783693463; cv=none; b=dqdeI8Qoi7SyElIsvQH7Rr4htMy5lCqCsfg0Z2v1JbOwaR/UYyIqP3D25ZZZnOAvj+KZRgWjZqz9SJDot15e1vxeRR7GNBq+4DOAK3jp1GO/J5Mgu/IDDnVxVjeY7GI8fX3boztCMvnE+mgq8TNh+OyfDjvbH9BreA/65GQHYEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783693463; c=relaxed/simple; bh=7KbwyrzId5VYBv2EdA1WQEdeHSCSPxyDjvLAJ3BSFBc=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=YhPMnP+aqGtrdCGT9V2h6FuOJhxaykw10SYrcJBQzzHIJ5Tebd8GzFtvMWgD3Uoa9ep8HA58sTCyZ0IlL6lvIzVcDo11othhdiNJHw6ki7LrUp/ll/pOx0RH2fFv2qnzZqttFvROePxqdVbAcbMQL+QCx6XHNxzS1Iqv0TpNbHE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IPG3mPBc DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F1E084BA23CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783693462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rLat32RNcLZ9IL3YYhv79dFILnly0vhJ0cJeRpybIBs=; b=IPG3mPBcnfCLOiru9DbQnLHs9lwALPycuQE/HA4Rlg3pikIAgf6FU4Rfs32BaM0GmD4JnY t6asgx+JtyPXYIsjEaxsZQigKkR/UrpuazPjFi+ycHgsDHy2qzqckAx8TAWb0Bkq4x24R4 FovsYuQxt96vyusIJDWQ+ju8QKSv+1M= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-pTIxZ_moPY6myVqg4olo0w-1; Fri, 10 Jul 2026 10:24:21 -0400 X-MC-Unique: pTIxZ_moPY6myVqg4olo0w-1 X-Mimecast-MFC-AGG-ID: pTIxZ_moPY6myVqg4olo0w_1783693460 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-493e9ea2c77so7643665e9.0 for ; Fri, 10 Jul 2026 07:24:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783693460; x=1784298260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rLat32RNcLZ9IL3YYhv79dFILnly0vhJ0cJeRpybIBs=; b=TILgjlseJrj8v9yHRkZGzf66TnZ+szJLEEWRND8cVI0nri/8odsZhWlBXj0LO88JKF 5aeVm0+JOGPER70f7ceu2E3iLnm2hHe3H1oqsIWvrNTfZ20CSJO/MKeHgi1DN4dXn23f gkLPYcBOg1pHcoO/+xyUGx2Hmw08OjwXhMedN8DWvoZo/7QJ0FU26Lv2enVM9jQi8afg mv9hbgcZLsjxL0m5uqRjdIa09JxhADdzjSA+NOGj5v3LSX8lVIjYURj+/rOhLof0jQ1u mSN4O8frbhhtc/jO9ssG4QB7+Ah/Zw7MRAs0jxsjbUoYh87E2c7A4AMJPaOj/LfuNugo VN3Q== X-Gm-Message-State: AOJu0YzhNjKXUaBTrhQM/XOZI/CIi7n47JDjFiEVeadjVZUjcPbbplZS JwLEOy7QDLNsWMrI1iBXKPFBdOERBhoLYfirXQsdhvJAtq4KhpFavSv+2ejOS8ZyfiHgScxXPq8 6gyjcEzzUf5iU0yFrN5Nt7CyYIoIbx6yzy9WdUJNGl4rQgK9M33r6tfnyE0wCZXDkffA5hR2oJ5 /VywvIVdDrT1iWYqqND0zhmKTt91JbXUCDlA0rCvF4AJx78nE= X-Gm-Gg: AfdE7clfUb4LhiV/95dffCHL5MHpWiPLUGmjWHjCu6zKA0pe1V3qHE7UCQD6pOTtueG aUUjMwc+sYYoq+F9NVil8ShP4Kro/R/EdEv7rn5ogbz7O3pusNPnAQf28QM3Jg0ewe4XhZdrkk/ N/8l3/pZcOyv0LjpsASLfha2Dt0yOr3akU0GXXJf7/aG4sB/y7Q00nWuRk1hGDzYH/XSZV4TzYo IgRAR85o5t3AHk9Jp9h3HATPaqGjv9YDJ1S+JKQeSp8dxwr7KOh09pL7u14+l10gBdYXEnjOyD3 n19xhS59xQ293754BnvTQFeC4/xh4kZFFxgPky85BGID6xESBk12ghLsObVbG0CKp5u20qYo5aG /EEsyitg= X-Received: by 2002:a05:600c:3e88:b0:493:efcd:b809 with SMTP id 5b1f17b1804b1-493efcdb895mr54997605e9.6.1783693459653; Fri, 10 Jul 2026 07:24:19 -0700 (PDT) X-Received: by 2002:a05:600c:3e88:b0:493:efcd:b809 with SMTP id 5b1f17b1804b1-493efcdb895mr54997305e9.6.1783693459151; Fri, 10 Jul 2026 07:24:19 -0700 (PDT) Received: from localhost ([31.111.209.233]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6e0e5asm145352625e9.9.2026.07.10.07.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 07:24:18 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv6 4/4] gdb: cache program space entry point information Date: Fri, 10 Jul 2026 15:24:09 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 028W2IDwl8QEMKGJIsA9l4zleT4SvYze8EKIsif2CZY_1783693460 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org After the previous two patches, every time that GDB unwinds a frame there are now two places where we check if the frame is an entry point frame, these are in get_prev_frame and get_prev_frame_always, look for the calls to `inside_entry_func`, which then calls program_space::get_entry_point_info. The calls to program_space::get_entry_point_info are not crazy expensive, but they are not free either, there are reads from target memory to read the auxv vector and the entry address offset, so on remote targets this could introduce a small delay, especially as this occurs twice per frame now. However, the information returned by program_space::get_entry_point_info is not expected to change from one call to the next. This information should be a property of the executable and libraries, so we really only need to figure it out once. This commit caches the entry point information within program_space, clearing it whenever an inferior starts or exits, or whenever the executable is updated. After clearing GDB will compute, and cache the updated information the next time it is needed, which will be whenever GDB needs to unwind a frame. It will be possible to observe this change by, for example, monitoring the remote target packets, but as far as the normal GDB output is concerned, there should be no user visible changes after this commit. --- gdb/progspace.c | 34 +++++++++++++++++++++++++++++++--- gdb/progspace.h | 9 ++++++++- 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/gdb/progspace.c b/gdb/progspace.c index 26e16cae8d0..c1f3044f4c5 100644 --- a/gdb/progspace.c +++ b/gdb/progspace.c @@ -289,9 +289,12 @@ program_space::exec_entry_point_address () const /* See progspace.h. */ -program_space::entry_point_info +const program_space::entry_point_info & program_space::get_entry_point_info () const { + if (m_entry_point_info.has_value ()) + return m_entry_point_info.value (); + std::optional exec_entry_address = this->exec_entry_point_address_if_available (); @@ -299,8 +302,9 @@ program_space::get_entry_point_info () const if (m_solib_ops != nullptr) inferior_entry_address = m_solib_ops->inferior_entry_point_address (); - return entry_point_info (std::move (inferior_entry_address), - std::move (exec_entry_address)); + m_entry_point_info.emplace (std::move (inferior_entry_address), + std::move (exec_entry_address)); + return m_entry_point_info.value (); } /* Implement the 'maint info entry-address' command. */ @@ -538,11 +542,35 @@ program_space::clear_solib_cache () deleted_solibs.clear (); } +/* Clear cached entry point information in the program space of INF. */ + +static void +clear_cached_entry_point_info_for_inferior (inferior *inf) +{ + inf->pspace->clear_cached_entry_point_info (); +} + +/* Clear cached entry point information in the program space PSPACE. */ + +static void +clear_cached_entry_point_info_for_pspace (program_space *pspace, + bool /* reload */) +{ + pspace->clear_cached_entry_point_info (); +} + /* See progspace.h. */ void initialize_progspace () { + gdb::observers::inferior_created.attach + (clear_cached_entry_point_info_for_inferior, "program-space"); + gdb::observers::inferior_exit.attach + (clear_cached_entry_point_info_for_inferior, "program-space"); + gdb::observers::executable_changed.attach + (clear_cached_entry_point_info_for_pspace, "program-space"); + add_cmd ("program-spaces", class_maintenance, maintenance_info_program_spaces_command, _("Info about currently known program spaces."), diff --git a/gdb/progspace.h b/gdb/progspace.h index d75379fe621..407d2595136 100644 --- a/gdb/progspace.h +++ b/gdb/progspace.h @@ -369,7 +369,11 @@ struct program_space /* Return information about the entry point in the main executable, and the entry point for the inferior, which might be different from the main executable. */ - entry_point_info get_entry_point_info () const; + const entry_point_info &get_entry_point_info () const; + + /* Clear any cached entry point information. */ + void clear_cached_entry_point_info () + { m_entry_point_info.reset (); } /* If there is a valid and known entry point in the main executable of this program space, return it. Otherwise return an empty optional. */ @@ -462,6 +466,9 @@ struct program_space /* See `exec_filename`. */ gdb::unique_xmalloc_ptr m_exec_filename; + + /* Cached entry point information. See get_entry_point_info. */ + mutable std::optional m_entry_point_info; }; /* The list of all program spaces. There's always at least one. */ -- 2.25.4