From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uc3tOI+jdWpSQRAAWB0awg (envelope-from ) for ; Fri, 07 Aug 2026 05:21:19 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pVdhnGPO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VJcWjV8o; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WGLz9yHG; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=RGE8e/PN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C6A201E033; Fri, 07 Aug 2026 05:21:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DEA5A1E033 for ; Fri, 07 Aug 2026 05:21:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C2C6D4B9DB6B for ; Fri, 7 Aug 2026 09:21:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C2C6D4B9DB6B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pVdhnGPO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VJcWjV8o; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WGLz9yHG; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=RGE8e/PN Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id A75EC4BA9001 for ; Fri, 7 Aug 2026 09:20:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A75EC4BA9001 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A75EC4BA9001 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786094450; cv=none; b=lUe4+B1uliKYriF7Tp2qO/9mvD5t+58RCeVkUvNeHCv3VNmoiRV5/V38gWUAMKloOpMun421ngt+C9jXrhZTmNJ40iN6j9ea1n7e/HDQl4oZjsiWJJuF+UDBZnpebs3RDxncGlJbpkarygxyIwv+gT0W/GQtI5KLbIfyZUMLEqs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786094450; c=relaxed/simple; bh=4yGL9ov9Oxg/QkNHIcfSSKa1Ms9PoUqVwNIPAF83T7g=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=QQ9I8T+Vn5TiFWutqktjSL1pMplNGzm4AppDyS+cKhDcP5/lN7Sd9mTYr8nOE7nE5wb4KI1ynijHvk6sfUhblJHAvrS5r8kqqnYfOAZ0XoisMdyO1QD0/BB4HFPwpgAPZbbVIFu0EhgNC4JGjN0Hd6Xt/GZJVF8xd8ZOib+MhtY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pVdhnGPO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VJcWjV8o; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WGLz9yHG; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=RGE8e/PN DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A75EC4BA9001 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 797613E16; Fri, 7 Aug 2026 09:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786094445; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SPl9aY0hwcq9BGnlsqEn5RY9pAMaHEOiIRJ7s25X7g=; b=pVdhnGPOgILB0B9fvBAflIBSYlympfeM3W5FiHlR5TWyKNHq85WECPaM4EQ1KtRllYGwLP XsBhHShwOuXDSHqNQnmBxSqivKLUuYiaZ+UKhUF2tGQi7LnZSyXlXZ4dhwr9uIO10IQN4A rIeebUQKmvbirXoon+eC7TkTTabhV5s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786094445; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SPl9aY0hwcq9BGnlsqEn5RY9pAMaHEOiIRJ7s25X7g=; b=VJcWjV8oQmTjJjDVVFwIcQwPaLSxhbq7L/28yiZm5X6+IQ7LUcVuq/v7HMyMTgwjPcUHdQ J7rIiilQFl14f8CA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786094441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SPl9aY0hwcq9BGnlsqEn5RY9pAMaHEOiIRJ7s25X7g=; b=WGLz9yHGErTsAv0mcSVeHxNz+HFn9seu/E29GrvATAvWTrCnz4nusIUzSGPqcn4YSjjeyj yoViokRo0TvK4VwEKEHVIG7gu53M6eRRGTZfOqT8SVFY0TNp5dxhnMi/EYolickS7JvYss FhsZo4jl+VGl647da/G03usFs1UILrs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786094441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SPl9aY0hwcq9BGnlsqEn5RY9pAMaHEOiIRJ7s25X7g=; b=RGE8e/PN26wyq4N8eAVpZ7u6wdK6wFscxghU6rQotFjuMhYH7YN0uvlfRZvSlWnYR9sAv7 yY7Xj8Zm70npzPDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 63449779B6; Fri, 7 Aug 2026 09:20:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id E6nzFmmjdWrjAQAAD6G6ig (envelope-from ); Fri, 07 Aug 2026 09:20:41 +0000 Content-Type: multipart/mixed; boundary="------------kPzy00xkF0ki7ZlQ0F15UqmE" Message-ID: Date: Fri, 7 Aug 2026 11:20:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb: share some thread proceed related code between CLI and MI To: Andrew Burgess , gdb-patches@sourceware.org References: <55e17e264f17f47680100684c9aa7bd9b88e377c.1786049312.git.aburgess@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <55e17e264f17f47680100684c9aa7bd9b88e377c.1786049312.git.aburgess@redhat.com> X-Spamd-Result: default: False [-3.14 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MIME_BASE64_TEXT_BOGUS(1.00)[]; NEURAL_HAM_LONG(-0.94)[-0.938]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_BASE64_TEXT(0.10)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:mid]; RCVD_COUNT_TWO(0.00)[2]; HAS_ATTACHMENT(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------kPzy00xkF0ki7ZlQ0F15UqmE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/6/26 10:54 PM, Andrew Burgess wrote: > I noticed that some code related to proceeding threads could be shared > between CLI and MI. This fixes a bug as the CLI code contains a fix > that the MI code is missing. > > In continue_1 (in infcmd.c) we have a loop that iterates over all > threads looking for threads that are THREAD_STOPPED and are in an > inferior that has_execution. For each thread found we then call: > > switch_to_thread (&thread); > clear_proceed_status (0); > proceed ((CORE_ADDR) -1, GDB_SIGNAL_DEFAULT); > > In exec_continue (in mi/mi-main.c) we also have a loop over all > threads that calls the proceed_thread helper function which skips > threads that are not THREAD_STOPPED, does some PID related > filtering (more on this later) and then calls the same three > functions: switch_to_thread, clear_proceed_status, proceed. > > The PID filtering mentioned above allows proceed_thread to do two > jobs, if the PID is zero then we proceed all threads. If PID is > non-zero then we proceed only the threads in the inferior with that > PID. > > You might also have spotted that in continue_1 we checked if the > inferior has execution or not. This check was added in commit: > > commit 5b6d1e4fa4fc6827c7b3f0e99ff120dfa14d65d2 > Date: Fri Jan 10 20:06:08 2020 +0000 > > Multi-target support > > A matching check was not added into the MI at this point, nor did the > commit message mention why such a check was not added. I'm choosing > to believe that this was an oversight in the 5b6d1e4fa4fc6827 commit. > And this is the bug I mentioned above. > > If we call `proceed` with a thread that is part of an inferior that > does not "has_execution" then the thread will be marked running even > though it will never actually be set running. See the early return at > the top of `proceed_resume_thread_checked` and the call to set_state > in `proceed`. > > I do worry that there might be a bigger set of bugs here if proceed > can set a thread's state to THREAD_RUNNING, but then never actually > sets the underlying thread running. But in this case, just having the > MI share code with the CLI means that we pick up the fix for this case > basically for free. > > I propose adding a new global helper function `proceed_one_thread`, > this will check if the thread is THREAD_STOPPED and is in an inferior > which has_execution. If these conditions are met then the three > functions mentioned above will be called to proceed the thread. > > I will then add a second new function `proceed_all_threads`, this will > iterate over all threads and call proceed_one_thread. > > We can then use proceed_all_threads from continue_1, replacing the > existing loop. > > In exec_continue we can move the PID (or rather inferior) check > earlier, outside the loop. If we want to resume all threads (the old > PID is zero path) then we call proceed_all_threads. If we only want > to proceed threads with one PID then we loop over threads in the > matching inferior and call proceed_one_thread on each. > > As the code I am factoring out is all within non_stop only paths I > have added `gdb_assert (non_stop);` to each of the new helper > functions, this will prevent these functions accidentally being called > in the all_stop code path. > > While moving the two `for (...)` loops I have replaced 'auto' with > 'thread_info' for additional type clarity. > > With the exception of the new has_execution check in the MI path there > should be no other user visible changes with this commit. I've added > a new test which exposes the missing has_execution check issue. Hi Andrew, thanks for finding and fixing this. The functional change is minimal (add one check), and uses a pattern already used elsewhere in the code, so LGTM. Approved-By: Tom de Vries FWIW, while reviewing the patch I came to the hypothesis that there are really three parts: - refactoring in infcmd.c - minimal fix - refactoring in exec_continue To verify this, I split off the first two parts, and confirmed that this minimal fix (not showing the part removing proceed_thread): ... diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index 8b6da41ffeb..a7e3845d6e3 100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -279,7 +265,12 @@ exec_continue (const char *const *argv, int argc) } for (auto &thread : all_threads ()) - proceed_thread (&thread, pid); + { + if (pid != 0 && thread.ptid.pid () != pid) + continue; + proceed_one_thread (thread); + } + disable_commit_resumed.reset_and_commit (); } else ... fixes the test-case failure. I didn't like the escaping in the test-case much, so I wrote a patch fixing this (attached). You could merge before committing, or I can do a follow-up commit, as you like. Thanks, - Tom --------------kPzy00xkF0ki7ZlQ0F15UqmE Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Make-gdb.mi-mi-corefile-and-live.exp-r.patch" Content-Disposition: attachment; filename*0="0001-gdb-testsuite-Make-gdb.mi-mi-corefile-and-live.exp-r.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBhODhhY2YyNmUwMzQ2YzU3ZmE4Mjc1YWY0ZDBiMjY1MTQ4NzNhYThhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IEZyaSwgNyBBdWcgMjAyNiAwOTo0NDoxMiArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IFtnZGIvdGVzdHN1aXRlXSBNYWtlIGdkYi5taS9taS1jb3JlZmlsZS1hbmQtbGl2ZS5leHAg cmVnZXhwcwogbW9yZSByZWFkYWJsZQoKLS0tCiBnZGIvdGVzdHN1aXRlL2dkYi5taS9taS1j b3JlZmlsZS1hbmQtbGl2ZS5leHAgfCAzOCArKysrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIubWkvbWktY29yZWZpbGUtYW5kLWxpdmUuZXhwIGIvZ2Ri L3Rlc3RzdWl0ZS9nZGIubWkvbWktY29yZWZpbGUtYW5kLWxpdmUuZXhwCmluZGV4IGEzYTU3 ZDNjODFhLi4xYTM0MDI5ZDA4NyAxMDA2NDQKLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIubWkv bWktY29yZWZpbGUtYW5kLWxpdmUuZXhwCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLm1pL21p LWNvcmVmaWxlLWFuZC1saXZlLmV4cApAQCAtMzksOCArMzksOCBAQCBpZiB7JGNvcmVmaWxl ID09ICIifSB7CiAKICMgU3RhcnQgR0RCIGluIG5vbi1zdG9wIGFuZCBzY2hlZHVsZS1tdWx0 aXBsZSBtb2RlLgogc2F2ZV92YXJzIHsgR0RCRkxBR1MgfSB7Ci0gICAgYXBwZW5kIEdEQkZM QUdTICIgLWV4IFwic2V0IG5vbi1zdG9wIG9uXCIiCi0gICAgYXBwZW5kIEdEQkZMQUdTICIg LWV4IFwic2V0IHNjaGVkdWxlLW11bHRpcGxlIG9uXCIiCisgICAgYXBwZW5kIEdEQkZMQUdT IHsgLWV4ICJzZXQgbm9uLXN0b3Agb24ifQorICAgIGFwcGVuZCBHREJGTEFHUyB7IC1leCAi c2V0IHNjaGVkdWxlLW11bHRpcGxlIG9uIn0KICAgICBtaV9jbGVhbl9yZXN0YXJ0ICQ6OnRl c3RmaWxlCiB9CiAKQEAgLTU2LDQyICs1Niw0NiBAQCBtaV9jcmVhdGVfYnJlYWtwb2ludCAi LWcgaTEgZm9vIiBcCiAKICMgU2V0dXAgaW5mZXJpb3IgMiwgdGhpcyB3aWxsIGxvYWQgdGhl IGNvcmUgZmlsZS4KIG1pX2dkYl90ZXN0ICItYWRkLWluZmVyaW9yIiBcCi0gICAgW211bHRp X2xpbmUgIj10aHJlYWQtZ3JvdXAtYWRkZWQsaWQ9XCJpMlwiIiBcCi0JICJ+XCJcXFxbTmV3 IGluZmVyaW9yIDJcXFxdXFxcXG5cIiIgXAotCSAiXH5cIkFkZGVkIGluZmVyaW9yIDJcW15c clxuXF0qXFxcXG5cIiIgXAotCSAiXFxeZG9uZSxpbmZlcmlvcj1cIlxbXlwiXF0rXCIoPzos Y29ubmVjdGlvbj17Lip9KT8iIF0gXAorICAgIFtxdW90ZW1ldGEgXAorCSBbbXVsdGlfbGlu ZSBcCisJICAgICAgez10aHJlYWQtZ3JvdXAtYWRkZWQsaWQ9ImkyIn0gXAorCSAgICAgIHt+ IltOZXcgaW5mZXJpb3IgMl1cbiJ9IFwKKwkgICAgICB7fiJBZGRlZCBpbmZlcmlvciAyQC9b XlxyXG5dKi9cbiJ9IFwKKwkgICAgICB7XmRvbmUsaW5mZXJpb3I9IkAvW14iXSsvIkAvKD86 LGNvbm5lY3Rpb249ey4qfSk/L31dXSBcCiAgICAgImFkZCBpbmZlcmlvciAyIgogCiAjIFNl dCB0aGUgZXhlY3V0YWJsZSBmb3IgaW5mZXJpb3IgMi4KIG1pX2dkYl90ZXN0ICItZmlsZS1l eGVjLWFuZC1zeW1ib2xzIC0tdGhyZWFkLWdyb3VwIGkyICQ6OmJpbmZpbGUiIFwKLSAgICAi XFxeZG9uZSIgXAorICAgIFtzdHJpbmdfdG9fcmVnZXhwICJeZG9uZSJdIFwKICAgICAic2V0 IGV4ZWN1dGFibGUgb2YgaW5mZXJpb3IgMiIKIAogIyBMb2FkIHRoZSBjb3JlIGZpbGUgaW50 byBpbmZlcmlvciAyLgogbWlfZ2RiX3Rlc3QgXAogICAgICItdGFyZ2V0LXNlbGVjdCAtLXRo cmVhZC1ncm91cCBpMiBjb3JlICQ6OmNvcmVmaWxlIiBcCi0gICAgW211bHRpX2xpbmUgXAot CSAiPXRocmVhZC1ncm91cC1zdGFydGVkLGlkPVwiaTJcIiwuKiIgXAotCSAiPXRocmVhZC1j cmVhdGVkLGlkPVwiMlwiLGdyb3VwLWlkPVwiaTJcIiIgXAotCSAiLipcXF5jb25uZWN0ZWQs ZnJhbWU9LioiXSBcCisgICAgW3F1b3RlbWV0YSBcCisJIFttdWx0aV9saW5lIFwKKwkgICAg ICB7PXRocmVhZC1ncm91cC1zdGFydGVkLGlkPSJpMiIsQC4uLn0gXAorCSAgICAgIHs9dGhy ZWFkLWNyZWF0ZWQsaWQ9IjIiLGdyb3VwLWlkPSJpMiJ9IFwKKwkgICAgICB7QC4uLl5jb25u ZWN0ZWQsZnJhbWU9QC4uLn1dXSBcCiAgICAgImxvYWQgY29yZSBmaWxlIGluIGluZmVyaW9y IDIiCiAKICMgQ2hlY2sgdGhlIGNvcmUgZmlsZSB0aHJlYWQgaXMgaW5pdGlhbGx5IHNob3du IGFzIHN0b3BwZWQuCi1taV9nZGJfdGVzdCAiLXRocmVhZC1pbmZvIDIiICIuKixzdGF0ZT1c InN0b3BwZWRcIi4qIiBcCittaV9nZGJfdGVzdCAiLXRocmVhZC1pbmZvIDIiIHsuKixzdGF0 ZT0ic3RvcHBlZCIuKn0gXAogICAgICJjb3JlIGZpbGUgdGhyZWFkIGlzIGluaXRpYWxseSBz dG9wcGVkIgogCiAjIFJlc3VtZSAiYWxsIiB0aHJlYWRzLiAgQXMgdGhlIGNvcmUgdGFyZ2V0 IGRvZXNuJ3Qgc3VwcG9ydCBleGVjdXRpb24KICMgdGhpcyBzaG91bGQgbm90IHRyeSB0byBz ZXQgdGhlIGNvcmUgdGFyZ2V0IHRocmVhZHMgcnVubmluZy4KIG1pX2dkYl90ZXN0ICItZXhl Yy1jb250aW51ZSAtLWFsbCIgXAotICAgIFttdWx0aV9saW5lIFwKLQkgIlxcXnJ1bm5pbmci IFwKLQkgIlxcKnJ1bm5pbmcsdGhyZWFkLWlkPVwiMVwiIl0gXAorICAgIFtzdHJpbmdfdG9f cmVnZXhwIFwKKwkgW211bHRpX2xpbmUgXAorCSAgICAgICJecnVubmluZyIgXAorCSAgICAg IHsqcnVubmluZyx0aHJlYWQtaWQ9IjEifV1dIFwKICAgICAicmVzdW1lIGFsbCIKIAogIyBX YWl0IGZvciB0aGUgbm9uLWNvcmUgdGFyZ2V0IHRocmVhZCB0byBzdG9wLgogbWlfZXhwZWN0 X3N0b3AgImJyZWFrcG9pbnQtaGl0IiBcCi0gICAgImZvbyIgIi4qIiAiLioiICIuKiIgeyIi ICJkaXNwPVwia2VlcFwiIn0gIncxLGkyIHN0b3AiCisgICAgImZvbyIgIi4qIiAiLioiICIu KiIgeyIiIHtkaXNwPSJrZWVwIn19ICJ3MSxpMiBzdG9wIgogCiAjIENoZWNrIHRoYXQgdGhl IGNvcmUgdGFyZ2V0IHRocmVhZCBpcyBzdGlsbCBzaG93aW5nIGFzIHN0b3BwZWQuCi1taV9n ZGJfdGVzdCAiLXRocmVhZC1pbmZvIDIiICIuKixzdGF0ZT1cInN0b3BwZWRcIi4qIiBcCitt aV9nZGJfdGVzdCAiLXRocmVhZC1pbmZvIDIiIHsuKixzdGF0ZT0ic3RvcHBlZCIuKn0gXAog ICAgICJjb3JlIGZpbGUgdGhyZWFkIGlzIHN0aWxsIHN0b3BwZWQiCgpiYXNlLWNvbW1pdDog NGRmNDcxMmNiOTRmNDA0NjNkYWY2YTc1YzcxYTY0ZWFmODRlNzkwMQotLSAKMi41MS4wCgo= --------------kPzy00xkF0ki7ZlQ0F15UqmE--