From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6XNVLmQMb2BMEQAAWB0awg (envelope-from ) for ; Thu, 08 Apr 2021 10:00:04 -0400 Received: by simark.ca (Postfix, from userid 112) id AC3A61EE0E; Thu, 8 Apr 2021 10:00:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7C4511E54D for ; Thu, 8 Apr 2021 10:00:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 384643950C4A; Thu, 8 Apr 2021 14:00:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 384643950C4A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617890403; bh=jKWPBQC9Xjh0uvIyllAC0uvc8E5h1t8/ohsnghHM6I0=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=JazVAMCb9KAc9IxWvOGOxFBEdw4QClnnib5ScHTH3pSwU2HS0o3GQEIq+QgvJeak0 i78ayTSaEbINX2agKNCqFr6dcmVhloLrwE+pNp07hMBBhAWPtGIJYa6FlCh2BUsCxY vLy/J0/KJESqg4jyxBixh+tJ5bkuwZIcqKulOyQc= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DFEE1385701F for ; Thu, 8 Apr 2021 14:00:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DFEE1385701F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 138DxqXD025780 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Apr 2021 09:59:57 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 138DxqXD025780 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4C0341E54D; Thu, 8 Apr 2021 09:59:52 -0400 (EDT) Subject: Re: [PATCH 3/4] gdb/breakpoint: add a 'force_condition' parameter to 'create_breakpoint' To: "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" References: <40773bd923ed8cb1f9773ecd29a5af01e204d801.1617806598.git.tankut.baris.aktemur@intel.com> <8f9e3ef4-22c0-a872-68e4-20389e4fb746@polymtl.ca> Message-ID: Date: Thu, 8 Apr 2021 09:59:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 8 Apr 2021 13:59:52 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-08 3:44 a.m., Aktemur, Tankut Baris wrote: > Ack. The other test functions also refer to hardcoded breakpoint numbers. > Fiddling with the breakpoint list by deleting/adding new breakpoints > caused the other tests to fail, and thus I simply opted for the easier > solution of hardcoding. And I don't want to put on you the burden of doing this change, so I think your patch is OK. But this would be an item on the wishlist, and I mentioned it because it can perhaps influence the future tests you write from scratch (if you agree with the idea). Simon