From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eBAcJIs2U2cXKgYAWB0awg (envelope-from ) for ; Fri, 06 Dec 2024 12:38:19 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CQyowhYY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8FA371E197; Fri, 6 Dec 2024 12:38:19 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3BAB61E092 for ; Fri, 6 Dec 2024 12:38:19 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D40633858428 for ; Fri, 6 Dec 2024 17:38:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D40633858428 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CQyowhYY Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id EB6FC3858CDB for ; Fri, 6 Dec 2024 17:37:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB6FC3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB6FC3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733506663; cv=none; b=evWVGn5HVgWadvCFoaRvXuL5NQB0IAVfkZu/d3IyDAAtK96UA+Ik200O/KbEIvDPNuZ8iAGy5OGOS4daTFqoqp0dsj6nO1lgqfO+SwYL8FQL8laDOdC7QqekpldUR/RKvSxXJ7vSxTitMymi5xgHpI9zPcguz21COshU+5mEN4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733506663; c=relaxed/simple; bh=A/bdfpXTv24zr4vRO/WiemblyFCWlA+ThR76LrlxifE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ucbyaRlcye+MTVlJStLUzet1apwBkJnKPH74umeg6eGCrdfDNdgS5Wp0WFR0MZQRwr2v9zpvH+OPEzEg/JA1mCFyDdmXOTWbfeX9IdT8miBgXEyLrqTH+FzRaBbVzpPZ7AouIDOA+wnbiUDE+3rJQyALLGXlncORfdEJTfcEKmM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB6FC3858CDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733506662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rK3yB7QxHioBYU9RnBoon7VEK7Gy1IAIgmj3nZrTL8Y=; b=CQyowhYYqO9LLMIYF+W3YqKRTO8CWE/gQFbDfMS6vImKMNiqT8+vc0ludBgNIdA1suF01q kXMs0Jwo+c7tRneXfz7zdMoZuyj1ICNHF2YWEbHpjBIGoJj9I/4DZLtzwkX6gaMVutMUkC IIi2novyQd+UJvkJiKfLpMSJ1LnvZCs= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-koOiYQQuMFKOg5fBIt1iDA-1; Fri, 06 Dec 2024 12:37:41 -0500 X-MC-Unique: koOiYQQuMFKOg5fBIt1iDA-1 X-Mimecast-MFC-AGG-ID: koOiYQQuMFKOg5fBIt1iDA Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-466916f53b8so26240931cf.1 for ; Fri, 06 Dec 2024 09:37:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733506660; x=1734111460; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rK3yB7QxHioBYU9RnBoon7VEK7Gy1IAIgmj3nZrTL8Y=; b=c9PZT1Z1J6kJice+FX3wVtd0iP+vb+Uf2frlSYq+SMXtvZH7DLVYvw6rn5m8oyOwE6 O1spnZBv7XcswqftNFQcqoIReCI4yxRJBxznf2vpTVDoUXFX1wMe+G/8DbDKzNEltKGy PDOPyj1X710EO6eQRk92hBiiHTF3ExHPo0XOTbhlcW2i5QekPKkQpxg2+/iL8L15pcZi zQaJwGL2b+5J/AIB/M6E9lbX0trOKBAcT0qg8E00XWiqNUUCgM+12ByXnpGANxXBTmus TJpwSMqCakqYMu8uDHc36/7CFwgRimjP1N2EiYWWJ8MPjx3TRb12dSUhZxjLlfelJuS+ 1M6w== X-Forwarded-Encrypted: i=1; AJvYcCXIDWGOUUxAHIjtxGbS8tS3h1RF9T5HVxVggU5hrN6Jb31XJZFG7HHS7/+g/0KCfmKnfq7lPmtWtCsNMA==@sourceware.org X-Gm-Message-State: AOJu0YweeaRDdDRe8d6XURcDpv4kD7ZQn4OxvO9Hmkru1S5Ygx57o/ik NRFjHbbvuqWcP9SxCR/6XYvwH9rJbHaZittxpcnBD8+gsqo+jmSX6HHuDAXxWONFLLgsYzmpeEE uT7Rn+GDbkG2DxYOoiY0URj428dFIHm8FVFReCieOUAIg6mOSH//jK+QodzL/L9SaPHc= X-Gm-Gg: ASbGncv+AyKxvlvVfwO0yprgKlcC+h2bawJoLzMTT8Qcv1yPArojcfTOMtXyNl6trCz +s3SlG4ja1A6b51I7jg44H6m9aD0euOkTNaTL4MEgoTC83w0Rc6sMWrWGW4c0SAhYptFZ7f0Ojb n6mAWoCQaP1YLR9/EailYd5ZHigfr5v5xfL+dUKxzcGU264jLeWV/rvFij1kQDgWpX+YJr0KZph j7CcixkfIjI20Xctd90UdJNZy03xW1F5W5ADgteW0CsrHPvbN0mYh+AUbtJAA== X-Received: by 2002:ac8:5a92:0:b0:466:b266:3464 with SMTP id d75a77b69052e-46734cd18c0mr55978601cf.24.1733506660317; Fri, 06 Dec 2024 09:37:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IFc5QGwNUpUdwjfab6M+2vGs0L/8czj9ZKZzuQvSv96KKfy3d9YTALR7m9SppFhcbvM9Q574Q== X-Received: by 2002:ac8:5a92:0:b0:466:b266:3464 with SMTP id d75a77b69052e-46734cd18c0mr55978331cf.24.1733506659940; Fri, 06 Dec 2024 09:37:39 -0800 (PST) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467297d6bb5sm23212651cf.85.2024.12.06.09.37.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Dec 2024 09:37:39 -0800 (PST) Message-ID: Date: Fri, 6 Dec 2024 14:37:37 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: Fix use-after-free when an objfile has no symbols to load To: Simon Marchi , gdb-patches@sourceware.org References: <20241205131959.3400690-1-guinevere@redhat.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YmCQ8zH3P41geY1Lb3sFlDjnA4oXKsMSk4LwvXic5og_1733506661 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/6/24 2:35 PM, Simon Marchi wrote: > > On 2024-12-05 08:19, Guinevere Larsen wrote: >> The recent commit moved an initialization of an objfile_holder in >> syms_from_objfile_1 much earlier in the function, to better deal with >> when GDB is unable to read the objfile format. >> >> However, there is an early exit from syms_from_objfile_1 when the >> objfile can be understood, but has no symbols. That was not releasing >> the objfile_holder, so the objfile was being unlinked from the program >> space, but the process of reading the objfile was being continued, >> leading to use-after-frees flagged by the Address Sanitizer. >> >> This commit fixes that UAF by making the objfile_holder release the >> objfile right before the early exit. >> >> This commit also changes the test gdb.base/dump.exp since that was the >> original test that flagged the UAF, but at the end of the test the >> generated files were being deleted, meaning we couldn't redo the test >> manually after teh fact. That final deletion was removed > teh -> the > > Approved-By: Simon Marchi > > Thanks, > > Simon > Thanks for the review, pushed! -- Cheers, Guinevere Larsen She/Her/Hers