From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66785 invoked by alias); 22 Jun 2017 12:06:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66753 invoked by uid 89); 22 Jun 2017 12:06:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 12:06:42 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1049014287D; Thu, 22 Jun 2017 12:06:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1049014287D Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1049014287D Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15FE25C3FA; Thu, 22 Jun 2017 12:06:39 +0000 (UTC) Subject: Re: [PATCH 2/2] gdb: Make some test names unique To: Yao Qi References: <86vanoi9zm.fsf@gmail.com> <1565437a-a03e-1fa8-021a-a2d32de69a97@redhat.com> Cc: Andrew Burgess , "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: Date: Thu, 22 Jun 2017 12:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00641.txt.bz2 On 06/22/2017 12:59 PM, Yao Qi wrote: > On Thu, Jun 22, 2017 at 12:08 PM, Pedro Alves wrote: >> On 06/22/2017 11:37 AM, Yao Qi wrote: >>> Andrew Burgess writes: >>> >>> >>>> mi_gdb_test "540-data-evaluate-expression vla1(1)" \ >>>> - "540\\^done,value=\"1\"" "evaluate filled vla" >>>> + "540\\^done,value=\"1\"" "evaluate filled vla(1)" >>> >>> Do not use "tail parentheses" on the test message, >>> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages >> >> The wiki doesn't mention it, but I think the rule should only apply when >> there's a space before the parens. > > I wanted to get confirm from analyze-racy-logs.py, > but I was lost in it, so I decided to follow the wiki. I only realized the need for the tweak to the rule after the original discussion that led to the rule being added to the wiki, and this is the first time I'm suggesting it, I think. >> >> I don't think it's worth it, or even a good idea to try to >> come up with different test names for all of these. In cases like >> these, I think it's generally possible to avoid the space before >> the parens. So IMO, we should clarify the rule instead >> (and the buildbot testresult diffing accordingly, if necessary). >> > > The current rule is "When you write a test, do not > put text between parentheses at the end of the text > message", we can change it "when you write a test, > do not put text between parentheses at the end of > the text message and space before parentheses". > > They are OK, > PASS: gdb.base/foo.exp: whatever test > FAIL: gdb.base/foo.exp: whatever test (timeout) > PASS: gdb.base/foo.exp: whatever test(1st) > PASS: gdb.base/foo.exp: whatever test(2nd) > > They are not OK, > PASS: gdb.trace/trace-break.exp: 2 trace trace on: trace set_point (1) > PASS: gdb.trace/trace-break.exp: 2 trace trace on: trace set_point (2) > > Is it right? Yes. Thanks, Pedro Alves