commit b4262306c3d11c87c11c873d3bd6065fcb6b0625 Author: Sandra Loosemore Date: Tue Sep 18 21:10:55 2018 -0700 Skip GDB tab-completion tests if no readline. 2018-09-18 Sandra Loosemore gdb/testsuite/ * gdb.base/complete-empty.exp: Skip tab-completion tests if no readline. * gdb.base/utf8-identifiers.exp: Likewise. * gdb.cp/cpcompletion.exp: Likewise. * gdb.linespec/cpcompletion.exp: Likewise. * gdb.linespec/cpls-abi-tag.exp: Likewise. * gdb.linespec/cpls-ops.exp: Likewise. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 701d979..6ec2f86 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,13 @@ +2018-09-18 Sandra Loosemore + + * gdb.base/complete-empty.exp: Skip tab-completion tests if + no readline. + * gdb.base/utf8-identifiers.exp: Likewise. + * gdb.cp/cpcompletion.exp: Likewise. + * gdb.linespec/cpcompletion.exp: Likewise. + * gdb.linespec/cpls-abi-tag.exp: Likewise. + * gdb.linespec/cpls-ops.exp: Likewise. + 2018-09-18 Sergio Durigan Junior * gdb.arch/amd64-invalid-stack-top.exp: Expect optional diff --git a/gdb/testsuite/gdb.base/complete-empty.exp b/gdb/testsuite/gdb.base/complete-empty.exp index 6a78538..c97b1fd 100644 --- a/gdb/testsuite/gdb.base/complete-empty.exp +++ b/gdb/testsuite/gdb.base/complete-empty.exp @@ -15,6 +15,13 @@ # This file is part of the gdb testsuite. +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + load_lib completion-support.exp gdb_exit diff --git a/gdb/testsuite/gdb.base/utf8-identifiers.exp b/gdb/testsuite/gdb.base/utf8-identifiers.exp index 12fe376..6afc884 100644 --- a/gdb/testsuite/gdb.base/utf8-identifiers.exp +++ b/gdb/testsuite/gdb.base/utf8-identifiers.exp @@ -56,6 +56,13 @@ gdb_test "continue" \ # names getting in the way of completion. gdb_test_no_output "nosharedlibrary" +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + # Test linespec completion. # A unique completion. diff --git a/gdb/testsuite/gdb.cp/cpcompletion.exp b/gdb/testsuite/gdb.cp/cpcompletion.exp index 9ec3bbf..0a5e804 100644 --- a/gdb/testsuite/gdb.cp/cpcompletion.exp +++ b/gdb/testsuite/gdb.cp/cpcompletion.exp @@ -15,6 +15,13 @@ # This file is part of the gdb testsuite. +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + load_lib completion-support.exp # A helper procedure to test location completions restricted by diff --git a/gdb/testsuite/gdb.linespec/cpcompletion.exp b/gdb/testsuite/gdb.linespec/cpcompletion.exp index d8aa5b2..1fc5390 100644 --- a/gdb/testsuite/gdb.linespec/cpcompletion.exp +++ b/gdb/testsuite/gdb.linespec/cpcompletion.exp @@ -15,6 +15,13 @@ # This file is part of the gdb testsuite. +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + load_lib completion-support.exp standard_testfile cpls.cc cpls2.cc cpls-hyphen.cc diff --git a/gdb/testsuite/gdb.linespec/cpls-abi-tag.exp b/gdb/testsuite/gdb.linespec/cpls-abi-tag.exp index e188637..a3a2e56 100644 --- a/gdb/testsuite/gdb.linespec/cpls-abi-tag.exp +++ b/gdb/testsuite/gdb.linespec/cpls-abi-tag.exp @@ -17,6 +17,13 @@ # Test ABI tag support in linespecs. +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + load_lib completion-support.exp standard_testfile cpls-abi-tag.cc diff --git a/gdb/testsuite/gdb.linespec/cpls-ops.exp b/gdb/testsuite/gdb.linespec/cpls-ops.exp index 355735e..ccd89a3 100644 --- a/gdb/testsuite/gdb.linespec/cpls-ops.exp +++ b/gdb/testsuite/gdb.linespec/cpls-ops.exp @@ -15,6 +15,13 @@ # This file is part of the gdb testsuite. +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + load_lib completion-support.exp standard_testfile cpls-ops.cc