From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107199 invoked by alias); 30 Nov 2016 19:56:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107181 invoked by uid 89); 30 Nov 2016 19:56:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=technology X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 19:55:59 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 61F6C80518; Wed, 30 Nov 2016 19:55:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUJtu2Y003530; Wed, 30 Nov 2016 14:55:57 -0500 Subject: Re: [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple To: Luis Machado , Yao Qi References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-5-git-send-email-lgustavo@codesourcery.com> <20161127170947.32vzeqciax5v275h@localhost> <20161129144851.GF22209@E107787-LIN> <20161129205524.xi3png66sw5quz5p@localhost> <9eb49791-100c-148f-b641-b1ad234b029d@codesourcery.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 30 Nov 2016 19:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <9eb49791-100c-148f-b641-b1ad234b029d@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg01014.txt.bz2 On 11/29/2016 09:14 PM, Luis Machado wrote: > Right. I agree that we don't want to have to keep inspecting things > manually. So if we decide to go all lowercase even for technology, ISA > or arch names, then i think we can enforce this better via the change to > gdb_test_multiple (and mi_gdb_test). Then we don't have to maintain a > whitelist at all. > > Does that sound reasonable? Is that going a bit too far? There's no real harm in uppercase test messages, other than inconsistency. I suspect that the main reason we see patches with uppercase test names is people starting from an existing test and applying the old time-proven copy/paste test-writing methodology. So if we fix most violations, then we should see much fewer attempts to reintroduce more. And we can't add such enforcement until we've fixed all existing ones. Thanks, Pedro Alves