From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30627 invoked by alias); 31 Aug 2017 20:39:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30020 invoked by uid 89); 31 Aug 2017 20:39:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:15.20.13.2, Hx-spam-relays-external:15.20.13.2, H*r:ip*15.20.13.2, Hx-languages-length:494 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Aug 2017 20:39:29 +0000 Received: from ESESSHC018.ericsson.se (Unknown_Domain [153.88.183.72]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 2A.01.22436.FF378A95; Thu, 31 Aug 2017 22:39:27 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.72) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 31 Aug 2017 22:39:26 +0200 Received: from [192.168.0.102] (80.216.43.226) by AMSPR07MB311.eurprd07.prod.outlook.com (2a01:111:e400:802f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.2; Thu, 31 Aug 2017 20:39:24 +0000 Subject: Re: [PATCH v4] Implement the ability to set/unset environment variables to GDBserver when starting the inferior To: Sergio Durigan Junior CC: GDB Patches , Pedro Alves , Simon Marchi References: <20170629194106.23070-1-sergiodj@redhat.com> <20170828231315.14952-1-sergiodj@redhat.com> <28c9905c-b845-a1e7-368e-fc4631e59218@ericsson.com> <87wp5j5vdm.fsf@redhat.com> From: Simon Marchi Message-ID: Date: Thu, 31 Aug 2017 20:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <87wp5j5vdm.fsf@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: HE1PR0401CA0075.eurprd04.prod.outlook.com (2603:10a6:3:19::43) To AMSPR07MB311.eurprd07.prod.outlook.com (2a01:111:e400:802f::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3f9b9af-1f22-4232-cfd4-08d4f0b05e1d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AMSPR07MB311; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB311;3:zKBfjaQC+tImaWJCHkphyGhcZ3ascgS/XaGIsbGXlUaUOKWgz7MIt4A/OwUUEJ5XHN367s665giNnFYA0G5tHAozh+rb41an5AoCKq0LwgBmFGwbkma0Uql7yeO9s9wvOWvUN3EZeFiTzpM1YAngQk2jlIRsVsnROy5eMq4Xua2MzzPsngVURDF+MrUcynnRNzlN0KuV+rKbrAQSOhFwtIdfV5LJBh29aD8RoXdqcIUdZXE9nKEpCXyVgRDN4Jzc;25:6ZuGNBCZWGLZ4rwSZJy84Yie5wzdH0q+92Sh7gEJ5FXBRdGJMUSHbpXGNasBBqArxw0lmiWNdnN6b3hG61vBicuYVmHEQAB5KB8ta+l88e+4qcgETgiDq7EluXUBnJW40jqXixzDg1pnpl3YbRRTLswkiX++jsOybV1KWb/lS6IOh2cHqXrM/qffho8fZtMGUDhuMGmSWx8Su40cjGuf4bD/YVVN5ov2jLwqlvCf7YFV+GF7nhjrwj/zhr42yOi5Vbwxy1pBHzg3OZ7UpWwpfnuXb/6NqmROqQ2ph9AnWoqk2s8QZf9uRi20FY58lKPSGrwF1S+DMbSsNQOCUz7aew==;31:rI//0dLpamdAYUlV4a2kVsIOE7LDmxGjlQP9MGiTXP20shmDyYeXrjjhkDJ3c4zGDATabYIF/qSnTl1F6J8W40XjyLGBY3rDxLslLkNxBiultSlWVaaj/uTMHSHPCYIufza4vpdlk7lxu/8LsawRoO8nYj7CJut+ILBXm80RzRNv4j6kE0qa1pA0wSx0hsNRiCQqtMsw7WQaRtOm3sJKkmTlkOCyPmS0C/ABYIjnh3w= X-MS-TrafficTypeDiagnostic: AMSPR07MB311: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB311;20:sb+txUSqOcnutSZhy4ChkKbZXZfOYKmseVPBxfF0eAWRc9NEwkUUYWZ/gub0/jGOLEZCxB+EeLVavWh5YTcgtCFDZQbtauqdoX9v4It28+UzgZbrkvDh2NTtCxAJ47lXQf+rzZgRGVXxVyO84U3aLwV/hXSaD/EgBBkjCMNJKc2LDRbupYwgOgQNuEB47635KG74TXYHbwt9pvCYq/ujBK66ajaVGUZstUv7SOUuKUdrBqIKNax45mx0rtOpQAkv6sY7zXY7JFBH2W89p2MXntHoo/SNfjOlLbssb7/RPp+8W+KHbz2m8xXQ0i9jibaS4ibgM66hKV/0lLrlchZRscDjLcPpyf6yo8IQ+i1NNIm6gqT4a+W3nxQo+ct8Eo9Oe/VcNpuMkDqkQFgtTbGkzQeE9+wi3YA00BOsNZaRzvyvRO2FnsFMtaH8ASJMwsQ1jqLPsPuzy49kvJ1BgilGRAu7CsEOI5fsq143/wXw39KGIRHMxAzbAOLQ/Zin5hvw;4:3vltnQmKfm0uVeZtp8R5y3PbqF/FgRfpcLAFHdcAvkzqTtKrhkU7Qdr9YMzT2krHSsOflvevtOUxizNWl1UuaFOPq8AcJurkTy60AYOWxxQYPIOzU3n+1UvMnpLN3YGE068LPt04iPHowmTpjtg+zQIcZD+ID97qxYNT9jOG21L+xYJy7GIQNofQMrdhrCUxHEyOl9fknfngOHwsKq6dPbaibZJA+V/HmQU9D/UTGJd3BlVYZeu9jR8Rg3zGz5LoJR8IBGnI1NMjKu581ASXAOUmN29C1W9OstatDshlKHs= X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AMSPR07MB311;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AMSPR07MB311; X-Forefront-PRVS: 04163EF38A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(7370300001)(6049001)(6009001)(39860400002)(377454003)(377424004)(24454002)(189002)(52314003)(51914003)(199003)(93886005)(117156002)(31696002)(65956001)(47776003)(106356001)(66066001)(65806001)(7350300001)(6486002)(65826007)(86362001)(4001350100001)(110136004)(25786009)(5660300001)(83506001)(36756003)(6246003)(478600001)(6666003)(97736004)(23676002)(2950100002)(68736007)(4326008)(50986999)(50466002)(230700001)(33646002)(64126003)(101416001)(229853002)(76176999)(6916009)(54906002)(54356999)(2906002)(81156014)(189998001)(31686004)(3846002)(6116002)(7736002)(81166006)(77096006)(105586002)(8676002)(305945005)(53546010)(53936002)(42186005);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB311;H:[192.168.0.102];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTE7MjM6ei9BanljR09vb2QvUFlHai9tbzVqSTlGa01R?= =?utf-8?B?M3hVdHBRZEMyYTgrazR2M0gzbzIvTUhudkRIemEyN0NXUTgvdWJXaTRucXlZ?= =?utf-8?B?M0xCeG0vb2phWkVMSVB5eDREbFlMQ25UaG9YcTJlU1NqZzc4amFFcFJucW9n?= =?utf-8?B?Q1hwMDE5NjVDeE9IdnhHamsvOWFuY3ozWXdVRHdablpEODRoMXVTbWFnaHly?= =?utf-8?B?RVdsNk92SWJJZTNLR0NTKzNPQzJSOEkzN2J6d1ZTRDh3aFk1WnNBSkRXVGh1?= =?utf-8?B?RlhlWGdwYnpLbmhIYmJjZTJ1V3Z1bTBkL0d2a2hja21oYzNrb2tMT3BYdUNE?= =?utf-8?B?REdpZEV2OUZ2eGlJMFRFUHdKd1g5bUZMbW1McDZ4UmpnNWNZdndxS3NyV2s3?= =?utf-8?B?VnRPUnZ2R3RQc3NKN25JK3hPQ0V3NU5ZYWZ3WWNJS3dvKzVDNFNZdFBya2hx?= =?utf-8?B?K2J2RlRnZ0NlZC90R2s5R29HLzVBUllMN2tVQ1QwZHBsUHlJbHh5V1V5TldY?= =?utf-8?B?aHFuTzdxZG8wTEhlOVk0eFJMcDhEOWtMT3dXY2hSVGpRekVjZUlyVGRVRTVV?= =?utf-8?B?L2tPTDdid2hlKzd2cHpIbStJTFZwencwbnp2VnJ3TkZWYnZnRWJlbU44SmRL?= =?utf-8?B?cFVWM0U2MDltT21GajVZdEFSeXhBZmpIekI2Z3kwTjVBUzg1YlN0OUl2NmNu?= =?utf-8?B?NTB2b1g4NWxVaFhqTnIzVnExaW9sQzJtYkNWQUx1dElpS1MzRitKRUQvSzFt?= =?utf-8?B?TDZWZjVpSGlETld0TnZmQjd5SmZlWFpkM0RXKytYWUtOR3J0amNtZ3NPTHBi?= =?utf-8?B?YWtUbHZXaUhndVpBTnp4VFo4dFF5a1U3eWJmS0tmaXlqa2NrSjhyRkNLM1hi?= =?utf-8?B?NDZZVi9lUFBvcTNTOHhmeGxVbVhrVFpLZCsrVHZGTzF3MXRLZ3pYUlFmY1Nx?= =?utf-8?B?N05mRzI2K3BSMFFsak1XYkhDNGFRTzJtM3J1Nm94SStUZHFtSHZGeXJtMTh4?= =?utf-8?B?TDQ5VWxGQkNIdmRVeUU2QzBTU0ZINGVMd2R4Q1BIRkZsSG1sRG5UeWxjWkdQ?= =?utf-8?B?U25mcUxmTUlIRTAyd1BCZnZBK0NuY29YMnVkNi9XcDdUVmRLV0cyVzd4SEl4?= =?utf-8?B?MnFubzdZcGJKanY3blpMUTA1aVlxYWFxb0w0OC81MnFITXVHSGx3K3BtdXQ5?= =?utf-8?B?V3ZVck5jeFhMNnJIRU9iRSt2cm42NEE3MXVpY1M3YVluQ3FQb3VibSt4eTdk?= =?utf-8?B?dFZqamxkYUFYNkhKV08rY1FWdHlkYy9oakJKMzVyMEhLV1hHTkZpSG44dUw5?= =?utf-8?B?ZzZDRUpCd2U5RnFyVk9hUkF1SHVxM2lJdTF6Q3oxMEtzcnRvL2ZTOW5lQkhC?= =?utf-8?B?VlpNTXQ3NUk2QWlERkNocy9LaktUbUZTYzdNa1pXbWxPSzVNYjM2c25idEd3?= =?utf-8?B?ZTNhTlB2cUNhYWpjSzJWSVpPcURsdFhkM1NaYlE3Y0I1YzVEYUtERFZ5ckZL?= =?utf-8?B?NnJLWHVTM0JQNXNBdjJGRlpIVU0zRUJpazhJUHB1UkNGN3ovaDBTTGN2THM5?= =?utf-8?B?M0tsOGlGRWZFUkloWThjaDBsM21vYW0yRitPL0V3UVdQYlp0YnNLd0FXdThK?= =?utf-8?B?ZEZ2NUlzaHNheFZKSXhOK1Y3QWFEM043ZmJWN3VsdTU0eVhWSG1UaGFHZVNR?= =?utf-8?B?NDQ2ZjJaNWx5VGhsNnhFdnNwVU5vb05Dd0ZtL2VQOEk3dEJKQ0pvMFdlOXdI?= =?utf-8?B?NjZjZ2FsTFZiOEp0SXVFd1o4cmhZNXI3dXhtS09rNXJyWXVKQ1NJZ3dmWi9M?= =?utf-8?B?MHBZeE1PK0VVQ2ZaeTVLWk1yWE1tZE5mWmxJc0JtbGx5M0pyV2xWQW80dFZJ?= =?utf-8?B?eHNueDBWSmk0Y0xDeWRqbU45WnVNRC83aWlBM3FPUjFja2VyWU1Fd2tuQ1o0?= =?utf-8?B?UjRMT01MYy85OFd3ZUtjYU1jZDl0aWlnUy9VYUwzdWI5RlZmdDJEWFpxQ0oy?= =?utf-8?B?VTlsS1JKdmx3Wm5kTlhYbm9pcUF1aFhTbnB3MUN1dk9aMzZZL1p1ejZ3K29X?= =?utf-8?Q?MEdivoEjdHcvozJUgWESHyWz?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB311;6:JVodqKyVcF9GLV3/OXzonSB8l3MnJMh3yUUugY0QApZOhz2/7WvDXkAwegwGx1VZiDEaVAV/O3GO5EV027Zl27FP178lbZwIAKNJQ6W8TEXHMZ0G0Hia7Z8mBzigeqZqEVJ9R3uHwdTcLzDOh9dLncOfC4tjM3X6IOFoWbuM6pWcbOF0Q3z45/FRudWh4T7p1TeEg8ioLcxtY21nGOQl+6m7ZpY1LLnnHiq6JMmDrkeZIoK1N2ybXs0gWLWFXvw8dFqNkQHlNvsHEcD4am/xckI90Yrbm+nulj3/IA96wNYZDaW9QStKb6Ls/JYv18R0KqPq1kM/+d3Q/VXIDBb4ww==;5:DRDw3jKXI6TdGtpbDe6k49bO1veotV3m2b9bK8NpFREUFzO8DtT+Iyq1eLMEkh9gix870NGk/9vuNaRloNO7zaupdZwP6uFZ1vFaOt6zIz9dZIKgu9sXOpgmDTVaXIOagEfMAegQ/wYG6ZlkH9gRWQ==;24:oM+sireh5vf7v7HWnlYezXrgRZG319eN6h+K1x7im635DEwAQ/oLWy98WYVPxpvMm1qLazUA5oTk9QEcT/FjwB+nGYP5jVIFhrsLGRCRPDU=;7:hnaYz69M3PZ0NwYU++4Un89g2rMzcYfZlljnPFq9lpXekkPACGfhG7xvR4sszBbE+CbPvXxsWxiuP7Cfdqy7FO2RDvbPLG3KMrbqcGVW0dWNkV+nJXR7+fU/5voV19bwfLV57iIRykVxKAYMj6VAEDYNtPscey6i8Ruu/VCRli5xLonKSTqH0ZsF9w0MxU1LzL1rt/MT2G2huUwFVUCBw7m1/QlV95nSY4DLuGfIFwE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2017 20:39:24.6411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB311 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00545.txt.bz2 On 2017-08-31 10:34 PM, Sergio Durigan Junior wrote: > Anyway, thanks for the patch. Yes, from what I have checked it covers > the existing tests. I'd probably even go further and do a > setenv/unsetenv inside each function that needs them, so as to really > isolate things. > > Do you prefer me to apply your patch on top of mine and submit a v5? Yes, that would be best. Simon