From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67870 invoked by alias); 18 Sep 2018 21:33:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67859 invoked by uid 89); 18 Sep 2018 21:33:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*u:Intel, H*UA:Intel, our, HContent-Transfer-Encoding:8bit X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 21:33:14 +0000 Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 2525310B476; Tue, 18 Sep 2018 17:33:12 -0400 (EDT) Subject: Re: [PATCH] Carry the gnulib getcwd backport as a patch To: Simon Marchi , "gdb-patches@sourceware.org" References: <20180918212124.5851-1-simon.marchi@ericsson.com> Cc: Sergio Durigan Junior From: John Baldwin Message-ID: Date: Tue, 18 Sep 2018 21:33:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180918212124.5851-1-simon.marchi@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00659.txt.bz2 On 9/18/18 2:21 PM, Simon Marchi wrote: > Commit > > e2fc52e7457 ("Fix PR gdb/23558: Use system's 'getcwd' when cross-compiling GDB") > > backported some changes from a future gnulib version to our import. > However, this means that every time someone wants to change our gnulib > import (e.g. add a module), they must make sure not to include that > backported change. It also means that someone running the > update-gnulib.sh script without changes will get some diffs and wonder > why. > > Instead, I suggest we carry that backport as a patch applied by the > update-gnulib.sh script after running the import tool. It will make it > clear what backport or local modification we have and should make > running update-gnulib.sh give a reproducible result. > > There is a hunk in the configure file in this patch, this is because the > commit that backported the getcwd bits didn't include the re-generated > configure. This looks good to me. I've verified it generates ok for me on a FreeBSD host as well. -- John Baldwin                                                                            Â