From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Qef2CeJq/mnVgyQAWB0awg (envelope-from ) for ; Fri, 08 May 2026 18:59:46 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=rFftZZyP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 253B51E0BA; Fri, 08 May 2026 18:59:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A41E51E067 for ; Fri, 08 May 2026 18:59:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C04E14BA2E06 for ; Fri, 8 May 2026 22:59:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C04E14BA2E06 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=rFftZZyP Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 419714BA5439 for ; Fri, 8 May 2026 22:59:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 419714BA5439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 419714BA5439 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778281153; cv=none; b=IUcDMmKB3qnYiplOt0YbVtBsNt+HXtJYxuB/l/aTstExqFXOa+LWBGZ8zbVqFZ3+1Ls1tHKbzA1OGm/xru1mxXN2H0khFJdlfmxg5uUzYx6sMeJ0jR5mtU4exwP2NkYkq8olDHTO8bztzjGpuWmzxuohVuuliifnL3jpsGHzB8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778281153; c=relaxed/simple; bh=s55piEiN/pxxp/KGz4ofylI2k29tidVw/E/MMOUh5+o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rWq7lCVu9xd9EsQPdqq3wuj8vJaREVpegD/TAfPlapGxshkMUhhSdjOBOkbd5+vDskr6afwgRyehwqKNlMSGLm0CizPSFtdIilh1/OJlSksTXzm4h8SG6sAofztADt36qnEzUURAz6iXG0fwGWsepLUo9ELPRlq4gqKymNv7axU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=rFftZZyP DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 419714BA5439 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 648Mx6UP231015 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 May 2026 18:59:11 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 648Mx6UP231015 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1778281152; bh=hYwcVuky2UAtQChSzYrVoWjMN8Nr10S/SD5YOIZI5O8=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=rFftZZyPRQYMyJC05dROF1p3hOM8M01iUVe+sCSFF3wV2+1SUh3KH9AVf6n19Sue+ IH81ycIv3jKEZZs+9lO7CY43ecroJZpyT53zhvRqOvV6SmyLt5zQD88kmdHaJvo59M NZnDAZRS/up7+FTSCF1VDSs/Qobervr9trz6vhfleNGU2kxv15Q8jz2JbX/hX4cllH H4P9PONxVvwXXCfVOBTxeoqOFpn11ukOxc1UIOkkkzFUXXjTeUuErQmtKnTfX/L6mP AXxVBDXt8j+pF0lAgkEgURyLj6p5+jG1BDcn+egOkcle6sUXDN2waePwNhZNXmGt8j 6sLN1CgTGMMHA== Received: by simark.ca (Postfix) id 9D52B1E067; Fri, 08 May 2026 18:59:06 -0400 (EDT) Message-ID: Date: Fri, 8 May 2026 18:59:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] gdb/dwarf: move dwo_unit and dwo_file to read.h To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20260316232042.368080-1-simon.marchi@polymtl.ca> <20260416200256.386186-1-simon.marchi@efficios.com> <20260416200256.386186-3-simon.marchi@efficios.com> <87qznzj5sz.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87qznzj5sz.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 8 May 2026 22:59:06 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-04-28 14:30, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> From: Simon Marchi > Simon> This is to allow index-write.c to see these types, in a later patch. > > No objection but I do hesitate to make read.h even bigger. > The trend IMO has been to move stuff out of it. > > Approved-By: Tom Tromey > > Tom I'd be more than happy to move it to another file. Perhaps "dwo.h", or "dwo-unit.h", depending on how specific we want to be. What is your preference? Simon