Re: [PATCH 7/7] Add "set startup-quietly"

Eli Zaretskii via Gdb-patches
2020-10-08T06:44:52Z

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 7 Oct 2020 21:05:11 +0100
> Cc: Tom Tromey <tom@tromey.com>
>
> +set startup-quietly on|off
> +show startup-quietly
> + When enabled, this causes GDB to act as if "-silent" were always
> + passed on the command line. This saves the setting into a special
> + configuration file, so that it can be read during startup and
> + applied.

As I wrote earlier, the second sentence is inaccurate/incomplete.

> +@kindex set startup-quietly
> +@kindex show startup-quietly
> +This can also be enabled using @code{set startup-quietly on}. The
> +default is @code{off}. Use @code{show startup-quietly} to see the
> +current setting. Changing this setting will cause it to automatically
> +be saved in a special configuration file, which is read by
> +@value{GDBN} early in its startup.

Likewise. Also, the text should say explicitly that the setting will
not affect any aspect of GDB behavior during the current session.

> +The directory in which this file appears depends on the host platform.
> +On most systems, the file is in the @file{gdb} subdirectory of the
> +directory pointed to by the @env{XDG_CONFIG_HOME} environment
> +variable, if it is defined, else in the @file{.config/gdb}
> +subdirectory of your home directory. However, on some systems, the
> +default may differ according to local convention.

Once again, this has been already documented elsewhere in the manual,
and in more detail. Please leave here just the cross-reference to
that place, and please call that file "startup file", for consistency
with the terminology there.
> + c = add_setshow_boolean_cmd ("startup-quietly", class_support,
> + &startup_quiet, _("\
> +Set whether GDB should start up quietly."), _(" \
> +Show whether GDB should start up quietly."), NULL,

I think the doc string should mention that the setting has no effect
in this session.