Re: [PATCH 6/7] Let the user control the startup style

Eli Zaretskii via Gdb-patches
2020-10-08T06:40:30Z

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 7 Oct 2020 21:05:10 +0100
> Cc: Tom Tromey <tom@tromey.com>
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index bd3aca84d51..d72d51b18b6 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -132,6 +132,13 @@ show exec-file-mismatch -- Show exec-file-mismatch handling (ask|warn|off).
> executable file; if 'warn', just display a warning; if 'off', don't
> attempt to detect a mismatch.
>
> +set style startup foreground COLOR
> +set style startup background COLOR
> +set style startup intensity VALUE
> + Control the styling of startup text. This saves the setting into
> + a special configuration file, so that it can be read during startup
> + and applied.

The second sentence is unclear: do you mean that setting the style
saves the setting into a file? Isn't that true only if such saving
was enabled by specifying the name of that file?

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 66b87608b89..f11948e8c4f 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -25880,6 +25880,21 @@
> @code{set style address} family of commands. By default, this style's
> foreground color is blue.
>
> +@item startup
> +Control the styling of some text that is printed at startup. These
> +are managed with the @code{set style startup} family of commands. By
> +default, this style's foreground color is magenta and it has bold
> +intensity. Changing these settings will cause them to automatically
> +be saved in a special configuration file, which is read by
> +@value{GDBN} early in its startup.

Same comment here.

> +The directory in which this file appears depends on the host platform.
> +On most systems, the file is in the @file{gdb} subdirectory of the
> +directory pointed to by the @env{XDG_CONFIG_HOME} environment
> +variable, if it is defined, else in the @file{.config/gdb}
> +subdirectory of your home directory. However, on some systems, the
> +default may differ according to local convention.

This seems to describe (in less detail) what was already described in
another place in the manual. Please replace this text (sans the first
sentence) with a cross-reference to that other place.

Thanks.