From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DzmNJmSvhGVCCCcAWB0awg (envelope-from ) for ; Thu, 21 Dec 2023 16:34:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1703194468; bh=98a/0pDuO/2BTvVev+DuJXru75YaUC5OvfnZUAHdY4o=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XBirQuYuoWO5ad3IRhJ8t4MMgcdeq1HSWS+IUWCL9XoY7DdlNwloOXhNnBE8Bg/tG ruG+vnVESQR3woy+wWXfaRAC8qNgHQ8k/W+na70WsvP8mYtm98hQW7boNINLE7mD5B 7z9z/CqcQZoDp2iQAKTmgHldXyTVP74gewgPbcrw= Received: by simark.ca (Postfix, from userid 112) id 961E21E0C3; Thu, 21 Dec 2023 16:34:28 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=N+WzZSqL; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 850F51E0AC for ; Thu, 21 Dec 2023 16:34:26 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1BE23384CBA9 for ; Thu, 21 Dec 2023 21:34:26 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BCB253858D37 for ; Thu, 21 Dec 2023 21:34:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BCB253858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BCB253858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703194454; cv=none; b=H+nwYh5ft+JMeIenuY1w5ckPHVG8/bAsqQC4BVxTxCz+Z5TASuEHOIh6uKarx2t3XqeZhoKHfru9MP2on6hHa9naEopAAxzr4ifnw/9DXpkT6BkCd0lxM9i/Lhm09BI1r1H3RLmu0VWV6pzZDthbcomkffAK497ZTfY7Hjo0pWU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703194454; c=relaxed/simple; bh=98a/0pDuO/2BTvVev+DuJXru75YaUC5OvfnZUAHdY4o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=VO7WohSB60zpbCtKTXV/YnCa2yxcPTp2OB3pgUQ04f2QWNuhszWbXA01C/oawOJNWxHGkz9ZR32DoxVLGaQXWUmqmYm/VFuOYQalsmY0IJT2qFZQfcHWZUerNLQ8QfAg+XFjMyheP1A0+Zs0Hou3og9wZgUd3ts1AQzYcYupTXw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1703194453; bh=98a/0pDuO/2BTvVev+DuJXru75YaUC5OvfnZUAHdY4o=; h=Date:Subject:To:References:From:In-Reply-To:From; b=N+WzZSqLuY6TLSkFiQszQPJDEJKPqby0lapilY2pGKcoEJ/oWCj1LKEccqsPg2p9r 77Yt0O7U5LxfvyaHaryqgVBcx/KzwMm2zwmPdtM6yyCA+aLf64DpwfKw8aSHWoXqFJ qY9B1s71SjXuVJCMsafKGIaVJdNEQJQ/l9xyAznk= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7BC621E0AC; Thu, 21 Dec 2023 16:34:13 -0500 (EST) Message-ID: Date: Thu, 21 Dec 2023 16:34:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 15/26] gdbserver: check for nullptr condition in regcache::get_register_status Content-Language: fr To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <893ba2a52032456c31cbb868c2f2ae4e0661b6e0.1677582745.git.tankut.baris.aktemur@intel.com> From: Simon Marchi In-Reply-To: <893ba2a52032456c31cbb868c2f2ae4e0661b6e0.1677582745.git.tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2/28/23 06:28, Tankut Baris Aktemur via Gdb-patches wrote: > A regcache can be initialized with a register value buffer, in which > case, the register_status pointer is null. This condition is checked > in set_register_status, but not in get_register_status. Do this check > for consistence and safety. > --- > gdbserver/regcache.cc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc > index ec11082be6f..0c6f1eb392b 100644 > --- a/gdbserver/regcache.cc > +++ b/gdbserver/regcache.cc > @@ -489,7 +489,10 @@ regcache::get_register_status (int regnum) const > { > #ifndef IN_PROCESS_AGENT > gdb_assert (regnum >= 0 && regnum < tdesc->reg_defs.size ()); > - return (enum register_status) (register_status[regnum]); > + if (register_status != nullptr) > + return (enum register_status) (register_status[regnum]); > + else > + return REG_VALID; > #else > return REG_VALID; > #endif > -- > 2.25.1 Thanks, that LGTM, I think it can be pushed on its own. Approved-By: Simon Marchi Simon