From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SdphIbuFqGgrqAkAWB0awg (envelope-from ) for ; Fri, 22 Aug 2025 10:59:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1755874747; bh=Faj9CuFtvLw2Nd9OGIr7MOO6h4InqXoeovLpNeImJ9o=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=U5wm3NW76mfNUgOlZw/xltyJRu+886mDajgCRg4gC1yVoGQQsns4wxPQ0Cxy3SboN MFKdDtt+sge/SX9cAWvDul95BqneO0ZuTJT6VH3bablf4Ktq8Wido0r8XAfeWcH11X rXPpqlXYgUApj217Bsua55/6wAyxlWHKc0VuKlEk= Received: by simark.ca (Postfix, from userid 112) id 84E801E023; Fri, 22 Aug 2025 10:59:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=gvUzMDO7; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1D6351E023 for ; Fri, 22 Aug 2025 10:59:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE6953851A92 for ; Fri, 22 Aug 2025 14:59:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE6953851A92 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=gvUzMDO7 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 177AA3851A81 for ; Fri, 22 Aug 2025 14:57:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 177AA3851A81 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 177AA3851A81 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755874671; cv=none; b=hJGBM9zqwhhF7NGwnneVhFagHnhxn9sE5xXwyE5hq3R91LX+W40l5axBEqTA/HQJ9gqbH672z9iAn8egTiKjovtDEhZK4HKm5SYDCPr4HzYD11v6zaVw+eyrmZySP/hdLXTufC52HG/dMMvpg65/GNVkI0gu7uyRCCRiQKelj70= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755874671; c=relaxed/simple; bh=Faj9CuFtvLw2Nd9OGIr7MOO6h4InqXoeovLpNeImJ9o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=scqrrVk+/ndVB0z3yFZnJAq6D3wMXImTXOVs/J/WM8GpKNxArVpxpUtfNlb1A4xrjia9A27mATh6+uuwuevGg2T828pieO/39yIRW4S17Wgjq9wZanyGQ1l+rSi/QGGI5ISztxlc04le70rcx/63Bk93I4O3IZsQqkIGJW+EbU4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 177AA3851A81 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1755874670; bh=Faj9CuFtvLw2Nd9OGIr7MOO6h4InqXoeovLpNeImJ9o=; h=Date:Subject:To:References:From:In-Reply-To:From; b=gvUzMDO78qs0Q0QGQv4v7SydLogvH7dXI1aD902j9wijQFh4s0rsHuEKm9iCntvjp hTtzsz19/JN9daNS8spAF5Egqs1Y0yX3EtXIlAP54ttoPQ6WJWwrI+0tsL5+61thPi O6riFIvrSk5sNSOgYDL3KFdUMZfM2lwSWDxTmRVo= Received: by simark.ca (Postfix) id 764C71E023; Fri, 22 Aug 2025 10:57:50 -0400 (EDT) Message-ID: Date: Fri, 22 Aug 2025 10:57:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] [gdb/symtab] Detect overlapping ranges in create_addrmap_from_gdb_index To: Tom de Vries , gdb-patches@sourceware.org References: <20250821133114.24091-1-tdevries@suse.de> <20250821133114.24091-4-tdevries@suse.de> Content-Language: fr From: Simon Marchi In-Reply-To: <20250821133114.24091-4-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/21/25 9:31 AM, Tom de Vries wrote: > In create_addrmap_from_gdb_index, use the return value of > addrmap_mutable::insert_empty to detect overlapping ranges. > > Tested on x86_64-linux. > --- > gdb/dwarf2/read-gdb-index.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/gdb/dwarf2/read-gdb-index.c b/gdb/dwarf2/read-gdb-index.c > index 7db2834f4d3..79d19a3abaa 100644 > --- a/gdb/dwarf2/read-gdb-index.c > +++ b/gdb/dwarf2/read-gdb-index.c > @@ -1434,7 +1434,15 @@ create_addrmap_from_gdb_index (dwarf2_per_objfile *per_objfile, > return false; > } > > - mutable_map.set_empty (lo, hi - 1, index->units[cu_index]); > + bool full_range_p > + = mutable_map.set_empty (lo, hi - 1, index->units[cu_index]); > + if (!full_range_p) > + { > + complaint (_(".gdb_index address table has a range (%s - %s) that" > + " overlaps with an earlier range"), > + hex_string (lo), hex_string (hi)); > + return false; > + } > } > > index->index_addrmap > -- > 2.43.0 > LGTM. Approved-By: Simon Marchi Simon