From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43913 invoked by alias); 4 Dec 2018 16:44:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43825 invoked by uid 89); 4 Dec 2018 16:44:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:720, Friday, friday X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Dec 2018 16:44:31 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 350478C32B for ; Tue, 4 Dec 2018 16:44:30 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E66A95C21C; Tue, 4 Dec 2018 16:44:29 +0000 (UTC) Subject: Re: [RFC/PATCH] Fix dwarf2read.c:dwarf2_find_containing_comp_unit's binary search To: Sergio Durigan Junior Cc: GDB Patches References: <20181130172148.18830-1-sergiodj@redhat.com> <87ftvi1mi3.fsf@tromey.com> <87zhtqqw3p.fsf@redhat.com> From: Keith Seitz Message-ID: Date: Tue, 04 Dec 2018 16:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87zhtqqw3p.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00039.txt.bz2 On 11/30/18 10:05 AM, Sergio Durigan Junior wrote: > On Friday, November 30 2018, Tom Tromey wrote: > >>>>>>> "Sergio" == Sergio Durigan Junior writes: >> >> Sergio> https://bugzilla.redhat.com/show_bug.cgi?id=1613614 >> Sergio> * dwarf2read.c (dwarf2_find_containing_comp_unit): Add >> Sergio> 'mid_cu->length' to '*cu_off' when checking if 'sect_off' is >> Sergio> inside the CU. >> >> Thanks for the extensive analysis. >> I agree this is correct; please check this in. > > Thanks for the quick review. This has been pushed: > > 81fbbaf96216ed88973a069e4ed25379d7421ec8 > Is this needed for 8.2 branch? Keith