From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120454 invoked by alias); 27 Mar 2018 20:49:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120274 invoked by uid 89); 27 Mar 2018 20:48:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,TIME_LIMIT_EXCEEDED,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Mar 2018 20:48:20 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w2RKm5Iv027576 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 27 Mar 2018 16:48:10 -0400 Received: by simark.ca (Postfix, from userid 112) id D20A41E77A; Tue, 27 Mar 2018 16:48:05 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id CAE9C1E4B2; Tue, 27 Mar 2018 16:48:04 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 27 Mar 2018 20:49:00 -0000 From: Simon Marchi To: Weimin Pan Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4 PR gdb/16959] gdb hangs in infinite recursion In-Reply-To: References: <1522101276-114428-1-git-send-email-weimin.pan@oracle.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 27 Mar 2018 20:48:06 +0000 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00577.txt.bz2 On 2018-03-27 15:53, Weimin Pan wrote: > On 3/26/2018 8:28 PM, Simon Marchi wrote: >> On 2018-03-26 17:54, Weimin Pan wrote: >>> @@ -658,15 +659,14 @@ cp_print_static_field (struct type *type, >>>        addr = value_address (val); >>>        obstack_grow (&dont_print_statmem_obstack, (char *) &addr, >>>              sizeof (CORE_ADDR)); >>> -      type = check_typedef (type); >>> -      cp_print_value_fields (type, value_enclosing_type (val), >>> +      cp_print_value_fields (real_type, value_enclosing_type (val), >> >> As discussed previously, here we should pass the original type. > > Hi Simon, > > OK, just made the change to pass the original type to > cp_print_value_fields() > which in turn calls check_typedef() to get the real type. > >> >> Btw, if you now have push access to the git repo, you should add >> yourself in the "Write After Approval" section of the gdb/MAINTAINERS >> file.  This will help you make sure everything is set up correctly.  >> Don't forget to include a ChangeLog entry for it and post the patch on >> the mailing list afterwards (mentioning that you have pushed it), you >> can inspire yourself from how people have done it in the past. > > Is there any document or instructions that I can access to understand > the whole process better? I am not sure there is such a document, but there isn't that much to the process. We should probably have a little something on the wiki though, if there isn't already. To setup your git repo, see here, in the section "Read-write git": https://www.gnu.org/software/gdb/current/ The important part is using the ssh:// address. After that, it's like any other git repo. It will use the public key you provided while registering for your account. In my local repo, I added it as a different remote with a special name (other than origin) to help prevent pushing things accidentally. So, for example: $ git remote add upstream ssh://sourceware.org/git/binutils-gdb.git You can then check that your access work by doing $ git fetch upstream Then: 1. While on the master branch, make sure you only have the patch (or patches) you intend to push applied on top of upstream/master. 2. Make sure you inserted the ChangeLog entries in the actual ChangeLog files and amended your commit 3. Push with "git push upstream master:master" 4. Notify the mailing list that you have pushed the patch. For the patch adding yourself as a write-after-approval maintainer, you can see how Pedro did it recently: The commit: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=7eb2418fa4641c60f6713986de7d3a50fd7a22c0 The mailing list message: https://sourceware.org/ml/gdb-patches/2018-03/msg00391.html Simon