From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Q27CEF35aGlR1wQAWB0awg (envelope-from ) for ; Thu, 15 Jan 2026 09:27:41 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ESpynaGD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=w6eSdkHa; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ESpynaGD; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=w6eSdkHa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 33E941E0DD; Thu, 15 Jan 2026 09:27:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 494721E070 for ; Thu, 15 Jan 2026 09:27:40 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id ADF144BA2E1D for ; Thu, 15 Jan 2026 14:27:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ADF144BA2E1D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ESpynaGD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=w6eSdkHa; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ESpynaGD; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=w6eSdkHa Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id A8F7E4BA2E2A for ; Thu, 15 Jan 2026 14:26:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8F7E4BA2E2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A8F7E4BA2E2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768487215; cv=none; b=PEMOvIB9nq8XOQP58KhOHG39WG0aMPT8JwJRhpbRY4gLa8Yag/nTaCveNUMXeOYwWUW+DfvASEcQnErWR8MzZJRkBe5m63b42R5XQRTHDnHAOv45j1aZ7p6UNQABaz3etz+g32YCfbBU41BY5VpQ7c+8BHZLgWscUQhQ5jsIiSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768487215; c=relaxed/simple; bh=Lx8WCnzy5The8RX8b0jMeYhuuOzOFLPr86IsC27Anoo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=nNLKvECa38juCgb8KVrK2OqWOyDWF3T2rULrSM36zDD3Cg2Z69pdy9ELV762YkkmZSTq0yG4+4+vwel9O+TrOxCAOgCVeXQ9gA+M0bSo2QQHkY7FjmNsfPiEAroUbtYFcbC9ZJqJHzTZLAxLDh3TCF94eNG1IO+zZXwYKmNBxYE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A8F7E4BA2E2A Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B60DD336FD; Thu, 15 Jan 2026 14:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1768487214; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fub7PpJAQnWW7YqsGMfZNSgYvkDwEVxVU7ZbkJOLUrQ=; b=ESpynaGDOk9/k0IlttwH79TFv+97rVZU5tIzcHs9dGUJTOEUWV6Y8ycilMbmjiiJbjFha0 u7uC6+rRDYyDsmvOsabeVA3apDevQuPsoPpRD1UiLbHkK6qci91spz917yaSbv6f6kjXP8 jrspUjra+0JZ1v8qHjVvh17o07fLMRo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1768487214; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fub7PpJAQnWW7YqsGMfZNSgYvkDwEVxVU7ZbkJOLUrQ=; b=w6eSdkHaq63m/Jfi0oNtr/BERradh2Ay+46ZzGa7Ob5oHarumg+IOSBkXZu8vi0C0CrVhU LWy9/79yI9QbWtCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1768487214; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fub7PpJAQnWW7YqsGMfZNSgYvkDwEVxVU7ZbkJOLUrQ=; b=ESpynaGDOk9/k0IlttwH79TFv+97rVZU5tIzcHs9dGUJTOEUWV6Y8ycilMbmjiiJbjFha0 u7uC6+rRDYyDsmvOsabeVA3apDevQuPsoPpRD1UiLbHkK6qci91spz917yaSbv6f6kjXP8 jrspUjra+0JZ1v8qHjVvh17o07fLMRo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1768487214; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fub7PpJAQnWW7YqsGMfZNSgYvkDwEVxVU7ZbkJOLUrQ=; b=w6eSdkHaq63m/Jfi0oNtr/BERradh2Ay+46ZzGa7Ob5oHarumg+IOSBkXZu8vi0C0CrVhU LWy9/79yI9QbWtCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9F15B3EA63; Thu, 15 Jan 2026 14:26:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3yFkJS75aGkMZQAAD6G6ig (envelope-from ); Thu, 15 Jan 2026 14:26:54 +0000 Message-ID: Date: Thu, 15 Jan 2026 15:26:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tui] Fix crash with debuginfod query From: Tom de Vries To: Andrew Burgess , gdb-patches@sourceware.org References: <20260114172833.1824823-1-tdevries@suse.de> <87pl7bt6nz.fsf@redhat.com> <5dbfe8e2-5f2b-40a3-80ca-09098df913df@suse.de> Content-Language: en-US In-Reply-To: <5dbfe8e2-5f2b-40a3-80ca-09098df913df@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/15/26 2:13 PM, Tom de Vries wrote: > Ok, I'll see if I can implement this approach in a more polished > fashion.  Please let me know if you prefer to work on it your self. FYI, sofar I got this, passes all TUI test-cases. Thanks, - Tom ... diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c index 272f5134d85..9280ce2a0fa 100644 --- a/gdb/tui/tui-layout.c +++ b/gdb/tui/tui-layout.c @@ -268,6 +268,23 @@ tui_remove_some_windows () tui_apply_current_layout (true); } +extern bool defer_rerender; +bool defer_rerender = false; + +static std::vector> deferred_rerender; + +extern void do_deferred_rerender (); + +void +do_deferred_rerender () +{ + for (auto f: deferred_rerender) + { + f (); + } + deferred_rerender.clear (); +} + void tui_win_info::resize (int height_, int width_, int origin_x_, int origin_y_) @@ -296,7 +313,13 @@ tui_win_info::resize (int height_, int width_, if (handle == nullptr) make_window (); - rerender (); + if (defer_rerender) + deferred_rerender.push_back ([this] () + { + rerender (); + }); + else + rerender (); } diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c index fb94823f0fe..21e8838fa44 100644 --- a/gdb/tui/tui.c +++ b/gdb/tui/tui.c @@ -393,6 +393,9 @@ gdb_getenv_term (void) return ""; } +extern bool defer_rerender; +extern void do_deferred_rerender (); + /* Enter in the tui mode (curses). When in normal mode, it installs the tui hooks in gdb, redirects the gdb output, configures the readline to work in tui mode. @@ -493,6 +496,7 @@ tui_enable (void) def_prog_mode (); tui_show_frame_info (deprecated_safe_get_selected_frame ()); + defer_rerender = true; tui_set_initial_layout (); tui_set_win_focus_to (tui_src_win ()); keypad (tui_cmd_win ()->handle.get (), TRUE); @@ -516,6 +520,9 @@ tui_enable (void) tui_setup_io (1); + do_deferred_rerender (); + defer_rerender = false; + /* Resize windows before anything might display/refresh a window. */ if (tui_win_resized ())