From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107215 invoked by alias); 18 May 2018 20:57:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107192 invoked by uid 89); 18 May 2018 20:57:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=readahead_cache, sk:get_rem X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 20:57:22 +0000 Received: from ESESSHC003.ericsson.se (Unknown_Domain [153.88.183.27]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 12.A7.31227.F2E3FFA5; Fri, 18 May 2018 22:57:20 +0200 (CEST) Received: from ESESBMR501.ericsson.se (153.88.183.129) by ESESSHC003.ericsson.se (153.88.183.27) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 18 May 2018 22:55:32 +0200 Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESBMR501.ericsson.se (153.88.183.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 18 May 2018 22:55:32 +0200 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB502.ericsson.se (153.88.183.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 18 May 2018 22:55:31 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.114] (192.75.88.130) by BYAPR15MB2392.namprd15.prod.outlook.com (2603:10b6:a02:8d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Fri, 18 May 2018 20:55:28 +0000 Subject: Re: [PATCH 03/10] remote: Make readahead_cache a C++ class To: Pedro Alves , References: <20180516141830.16859-1-palves@redhat.com> <20180516141830.16859-4-palves@redhat.com> From: Simon Marchi Message-ID: Date: Fri, 18 May 2018 21:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180516141830.16859-4-palves@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN1PR12CA0055.namprd12.prod.outlook.com (2603:10b6:802:20::26) To BYAPR15MB2392.namprd15.prod.outlook.com (2603:10b6:a02:8d::11) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BYAPR15MB2392; X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2392;3:ylwGN6AF15F8UpBnqRChN0iPgAlNAwNmnfwMVBm08LVo48q9fxZgDw+GJYibNm+xKul4vS8qLABY9SfEEnTWTJo383PVbmBnmH8r/ESLAci9nM1gx1tGDMD/o0+5HM3/khkXEzd61Npltrmd2nmTn8LUWIA9hWB+QsYVCJw0vNlxZRPU8VcZwuGLAaMXqiyU4kS0jt/4zcePx6kpGvPMsQ1I0sDQsoXUY3b/ycf0d5rMOn0eDALgC+uwllMyQ+7N;25:C/iDf6eG0jJa2gIctyKXZWzN4pduv0k3n4yL7nyNP8WCI8DhewQjgPAYntgreejiyFiwWopItT62t7Ll2RCrmkGTgOHxzOVMOZs0+WSRXUUPLZPRIlQ8smIGT4jGKJ8fLQnRL4gDnmu9Wn5h2o3UvXZ2MX8dDv3/Hpx+w7gnRzEbluR/PNH4YJxomXDurdnHh2ntqKG4bovNuBPlPCGEMEXmLGXalnL6PlH8ZsN2a1huTM5FCRbaiKm/5UIZJMLe6hNZzvsqe4wig92Y/y1AAfCwAqcZQBz3r6V8a8xUAah7dg6N+URIJbNV6cKaogE/53KilC8YzY+SQkAdSYu6FQ==;31:OGtg1cxswcdgD6PQaLJVSL5RHgRfO/T2ngdzNsPPkxANor2bYjuUlPQXRi+lgO/XyasljYLhQWS1aGQ4SBD/vZc5Ihj0DARvPSaLRmGdnuUdcK0+R74I1nkhd38vjlF1HY95OmgTIUAhtloBWvfXauwKTLJcUnWNLqPUgouXXOOPKg21p+tZM07YSCzSOf8X5Hdt7FShT86c9PPZR1ijdPSLmTozGmOrP62X8fVcka0= X-MS-TrafficTypeDiagnostic: BYAPR15MB2392: X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2392;20:uplp5NfHqGZ4aeVTA/9vg+8fYHZpzVpOmNr/Ealrn5kN4PbeaFjwQDW3w84A/MMXbwsXDFUztugBZ1nh/t2D4NoGGnuhLPlcxim14ATbaCUY3LxE6zsdSjbJZk4KyzMO6EN1ViRyEp1xMozJbvhQfccbXaB3GEUeEjbB9d0eJJzSGH/vcjzlXjq49rMfaPPoY58dXs4mbTSIqGFKlfl9ezULEtIq9GPn0V6qmtR90IbSBrOeEhxmkI2fcf4/UjWnl8ZvmtF7Htl+2nGWLpYMTqlA1BoVbfBKBob0iMrJ6uVtfHAYfF5XUwN7W8q8CRDBvRyCslkWQcTBy/6rphwZX8EK6USAxbckwowkpratNTZ7UCwjgZLWQZwdefsbouEyDwqkp7OJGxI4FRh4kVJdIBDjf5G3ZRljKE5cD0+3J7vFjVWfKxu3Mz2PePVERZ+w4ULIlZhkX2nSDWRQyvCW4Gblb/wzAGCjrYpSaW0rq+Wz0a3ynCh0CfDopX+vlrTk;4:DQDo4xcqFoAYxeU/O0bF9PElS2FYKhMOMKoc/zpC0OvYP4HXbe10Q7XdE7IJ54z5h0+Nkx7GJBvVxkqumCwO9z3RIFLoaQlgbp7NIm3M5FidpVHen78lVusvW6R7i79Vy1U1UY9hdS16LQxILcBAxOrcsl3SO4SoYR2GghkVwwkLIC4sqKxNGU911Xl/12sYlFVdvYvEFmE8Exdy1WqKnq3evnwW/0o4K+1hgG7/fzfLSpjpACt1SFX851Qr7QKwxTZKKeSWAH7E155F4J5AsA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(149027)(150027)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016);SRVR:BYAPR15MB2392;BCL:0;PCL:0;RULEID:;SRVR:BYAPR15MB2392; X-Forefront-PRVS: 0676F530A9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(39380400002)(376002)(396003)(346002)(366004)(377424004)(189003)(199004)(8936002)(81166006)(8676002)(36756003)(81156014)(16526019)(229853002)(186003)(68736007)(26005)(5660300001)(76176011)(2906002)(6486002)(65826007)(16576012)(65956001)(2486003)(52146003)(23676004)(64126003)(65806001)(25786009)(7736002)(316002)(50466002)(66066001)(305945005)(47776003)(52116002)(58126008)(106356001)(105586002)(3846002)(6116002)(53936002)(478600001)(6666003)(86362001)(97736004)(31686004)(44832011)(49976009)(230700001)(6246003)(386003)(486006)(53546011)(2616005)(956004)(11346002)(31696002)(476003)(446003)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR15MB2392;H:[142.133.48.114];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWUFQUjE1TUIyMzkyOzIzOk1tSHBPTlU5YzFTYzNGbUdEVE1mK1JvWGNE?= =?utf-8?B?QWVuU2JTSDJpLzBXS0hHSzAvekovaFJpaGU5d0c5MTZmRDIzU1gxdGhVN3pj?= =?utf-8?B?WVRscTdkaFZQbklrR0JOK2pETUNMMUxUd1hTSHYwVkJGa1pGTi8xWDB6dkNB?= =?utf-8?B?eHdJR2VKUGpYbDFxWmRXQmplL1NjNWdVRU9wbHBDVDJiN3UxT2ZzejYyYWhM?= =?utf-8?B?STlpc2E5R3VodWpoY29oVHpGTmpOTjNPem9ReWxOMDliWXJlNjkrV0tGekJQ?= =?utf-8?B?QitXWmY5TDl4dXNFNlplOHVLNFJBRE42S1U3dFc5ZjIxYkY3OXY2eHNUU1dj?= =?utf-8?B?alJLWldISG5EVVBtdkFxYWFWMDJsczZjdExwOUFNQmlwdkExSnBaaGt3dzY5?= =?utf-8?B?OGgyNEU4aG5nb1lPdmJZeFBzTzJFSCtyRWxDVERmUUM5c1NrZlJKVWFYZXNy?= =?utf-8?B?bU5QN2lwcjVEY1JTNGxHNnpZVTl2d3lvQnhpOXdtWWs0WVBPcW11L09MWEJJ?= =?utf-8?B?SXBLeFVscHJkbHh5dnVzTmRwVExQVDB5enF2WXZ3QklYMzhZRkdzTXpxeUdt?= =?utf-8?B?QzNQQlNER0NTZlY4NzA5T3N4OXgvcUxCY3EyOUlIR1lwcXdnZ0RzWnpIRjFY?= =?utf-8?B?UitvcllLMlI5WkhmTm4wcFRrUlZSY0lXSzJYUTI4dEFiWkhUOTJscFhKVHEz?= =?utf-8?B?NE1LejBOVUxrL0pWd1VCQzU4NkdGQ0NSRUY5bXZOMFhWbnJiR0d3MlJUME1Z?= =?utf-8?B?dmsxNkNNZ2FVQ3pTY0dwTFRxVXFlVXI2Mmdyd0M0STJCMkJtcUFNeXZqaHAr?= =?utf-8?B?YW5iZEt2Rm9YNTB4Z2NTL3pEMW1xV0dRZms2TXZseFhtL2VKUEhyZHJ6VUxZ?= =?utf-8?B?bDVPNTI5WTJ3VWVBZzkvS2QrSXdTQ0w0TUlTR1F4MDNlQytKb015Zm9WV2dE?= =?utf-8?B?aS9JN05sV2h1YjFoeWZWUk91V0p6OHg2Y21YR1lXczJFaDNOSTRHcGE3Sitx?= =?utf-8?B?ZmNzc3ZUQlpLc2NQMVA3WXZRdHcyK0IzZ3A1Zy9xRUZPSFhOU1MveWp2LzNL?= =?utf-8?B?aXpiQzdtNGh6N1Nic1dRTUt6Z1VETFZHYmx1T1RUd0FZT3k3MmVVU3VkVlJ4?= =?utf-8?B?bTI1Qk9ia3gvdEZoVk5FcGZjcmdsMWZ1d1M5eHhkM09wRVBnM2J0eG13Z2lO?= =?utf-8?B?TTFTNnlLYjRiQStWL2pWejVBb0ZLaWo3K29ZbmJQYzJ2ekg3U3hqUXcxcDlr?= =?utf-8?B?SHJaUWFLaGVQZkhsd1BWaExkUm5xank3Vyt3K3g3aUhJUk1Mby9malZPZDhm?= =?utf-8?B?SmxRbkNBQU1rWTVYYk0wYkI5NzNyTDA3M1hlYTFieEhEREdzdE16eXNsWVVI?= =?utf-8?B?R2ZYR1JoaXZYcW9xT3QrcnZEMkJZY3p0N1FML0t3NjhhK0pGcWxsVnhIcUNj?= =?utf-8?B?aXZRcC8vM25BT3ViOFBFdmtuNXFhajY4bVVmenlxZjdZRHRZQVpXUnZFTnJs?= =?utf-8?B?bE4vb2ZoeEh4b3poamllNVVDTzRZYitTR3JRWGQrTTYxWjFDWlozZmpOZnEv?= =?utf-8?B?ZVN4YnVpOUUyemh0NktoR1gvNEt5OTEwWHU2eGlkU00zWUM2WEFtQ05rSWdD?= =?utf-8?B?UHNmVzJkOGpEanZBWmlqejBrcnZZNUoyNEVqU0RrUlVJVzVoSjBLTEMrcXhh?= =?utf-8?B?a0dta3cycXVZZXBDeTJnWm93VFVOelRBZURnRXprTEwvTENTV0lFMDlZRGNO?= =?utf-8?B?KzJ3d3UzNTV1d0tNYXBlMkNuYi9xRnAreFVhZ1BRQ09PK29kK25LQm5VdU1o?= =?utf-8?B?MEVEYndIenRkMWQrT3dzSnEvOUx4MzFMSW8rSjFMT3BuamUrNGFaLzlENWps?= =?utf-8?B?SnFvQmRRMEhuMWRwbU40aFQzY0lveWtKYy9ZQjhVL3ZERm1HY2YyTnhJNUVC?= =?utf-8?Q?FvIgH4QQ2NzWhR5bJ9lxTFl0qvNEfY=3D?= X-Microsoft-Antispam-Message-Info: V2l4mHXJidhbnta2RzkCcRKvv9AYVyzZQauoSKaNF5HxCbSoezBOcoPjNR2IB1IRxY2yD/RxUbMBL5/arKsNn7iHbuJ2TV+vCqWLw2ckefMmvr5Hj+VZkhOrHf4wZ8n9RwRKfXg2ylPoqDKEjw+aj+uvrwpvcsxJNWNwTTdkCJ6P5vHuOoCHN39qT/q4Z2Oz X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2392;6:QMJZyBgjUpWN7r78WJdueVXiH56nFPJwL0/KML8Xqw4xbtz8YRxN37jV67JEQdL82IxQUPNglpIInlUbnGXaZo+8uNBmZSlTH1oV770uYKANd9FGSewa6hRJ6TN/js5kkdTFMb7+30cfWf+EBthZXoiL3T8HZNaIQGJnN2jmlcVkMKLFG9w3/XOhhRTZsAfyuObrnMZe3C36iNlZCpEsCMNkoaBqAwlL4HzSM62Z2r5mEBfxNYnOHGDgs1OaW1gCsF2YqyGTjbxbmB2rngwTmBBM6Si76g5hjSEkF+4ESo8PDbzmRAK06yUoIr8k8htDQLA9+IDCz5ZfpHxrGZCbkWDNrpFStaJVDk9ktdNcMZS8fbWEd+8TV1gfB6Zz5JL27pH6h5SWCXWVKIQhUWFQbmd3byK9vS8bs7M7Nx8oYwjG/+r6Yl5Ygo0Wv/LYi9WtcRXYEwbDmwmRS40Zovio/A==;5:qXliS8d5XFfys5aABC9KhgjxKdj00CfaNQhrVLmcQyjZc+qreFdWC9XwBMCb4F6ArVNKGm3ewmaFCwVQ4DJjeFkGvh+WUaIlOBDgvT7anwxqa0irfkc2VUuJdgueow0NXKU9Y538o0a5OO6Ycj2Y85HIj4bYAgFRRz2Oohz/5M0=;24:ypvh+zG+pps15oOn2eTo0lRQvXAcBnkikWLquogNTd/3BOZ+eo9O+2rhnRWwyYFbutxqpiIwKv9G1YcaTKa5WxBoS6FRK1CRQAeuzfRXmHk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2392;7:KPzwU6U2kf4EPBLF/XQshP2l04zlo8PrhBnDdMIZ6v+BZWbqq7oWptI3IJV/anx7P/7FhIRzAKQDMMwEFgtDOy55R2YVXbyniCJqVV0sOYV880OvwbGmaFDoSynt0+Fen7q5JXatI2crXqe219xzMHeiZnHlBjXrCbxYtc6rT7EFJMdo4hDHH/aax/0UsfF2IGjPBVs9jmMHhR4T8sD27AGJn3tIYrTS/dVDuqD3QOL0MSyAwu2lYMr/ZFlW4nS8 X-MS-Office365-Filtering-Correlation-Id: 270a0eb4-624c-4d3a-236a-08d5bd01b030 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2018 20:55:28.7604 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 270a0eb4-624c-4d3a-236a-08d5bd01b030 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2392 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00422.txt.bz2 On 2018-05-16 10:18 AM, Pedro Alves wrote: > The idea here is eliminate the get_remote_state calls from within > readahead_cache_invalidate, readahead_cache_invalidate_fd, > remote_hostio_pread_from_cache by making those functions be class > methods instead. Later on we'll have one readahead_cache instance per > remote connection, and this change makes that easier. LGTM. Simon