From: Nick Clifton <nickc@redhat.com>
To: Stafford Horne <shorne@gmail.com>, binutils@sourceware.org
Cc: GDB patches <gdb-patches@sourceware.org>,
Richard Henderson <rth@twiddle.net>,
Openrisc <openrisc@lists.librecores.org>
Subject: Re: [PATCH 0/4] OpenRISC binutils updates and new relocs
Date: Mon, 17 Sep 2018 15:07:00 -0000 [thread overview]
Message-ID: <aceede44-4ab0-9267-a949-5cd5f3c5e81e@redhat.com> (raw)
In-Reply-To: <20180908213515.GN4594@lianli.shorne-pla.net>
Hi Stafford,
> Does anyone have concerns with these patches? Mostly they are for openrisc
> parts only.
Sorry for the long silence - I have been very busy of late.
The patch series looks basically fine to me, so I have no concerns there.
There are a few minor formatting glitches, but nothing serious.
I do not see any need to add extra document for the new relocs, unless you
have created new assembler pseudo-ops to generate them. (I did not see any
code to add such operators, but I may have missed something).
I do have one question though. Is there a need to be able to distinguish
between binaries that use the new l.adrp instruction and those that don't.
For example if a library is built using the new instruction but then it is
linked into an executable which is supposed to run on silicon which does
not support the new instruction, should the linker issue an error ? If so,
how does it detect this situation ?
Cheers
Nick
next prev parent reply other threads:[~2018-09-17 15:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 14:38 Stafford Horne
2018-08-21 14:39 ` [PATCH 4/4] or1k: Add the l.muld, l.muldu, l.macu, l.msbu insns Stafford Horne
2018-08-21 14:39 ` [PATCH 3/4] or1k: Add the l.adrp insn and supporting relocations Stafford Horne
2018-08-21 14:39 ` [PATCH 1/4] or1k: Add relocations for high-signed and low-stores Stafford Horne
2018-08-21 14:39 ` [PATCH 2/4] or1k: Fix messages for relocations in shared libraries Stafford Horne
2018-09-08 21:35 ` [PATCH 0/4] OpenRISC binutils updates and new relocs Stafford Horne
2018-09-17 15:07 ` Nick Clifton [this message]
2018-09-17 16:29 ` Richard Henderson
[not found] ` <20180918095234.GP4594@lianli.shorne-pla.net>
2018-09-18 11:55 ` Nick Clifton
2018-09-18 12:08 ` Joel Sherrill
2018-09-21 12:41 ` Stafford Horne
2018-09-19 13:23 ` Stafford Horne
2018-09-27 6:08 ` Stafford Horne
2018-09-28 15:39 ` Nick Clifton
2018-10-01 7:08 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aceede44-4ab0-9267-a949-5cd5f3c5e81e@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=openrisc@lists.librecores.org \
--cc=rth@twiddle.net \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox