Re: [PATCH 3/5] Add support for 'info proc files' on FreeBSD core dumps.

Tom Tromey
2018-09-13T15:08:51Z

>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:

John> That comment is in the structure 'struct kinfo_ofile' which is for
John> an older format of this structure used in FreeBSD 7.0 kernels. 7.1
John> and later kernels use the 'struct kinfo_file' structure which has a
John> fixed layout (and includes an explicit kf_pad0 padding field). FreeBSD
John> didn't add the NT_PROCSTAT_FILES note to process core dumps until FreeBSD
John> 10.0 (also merged to 9.2), so process cores have only ever included the
John> newer format with a fixed layout.

John> If it is helpful I could add a comment. I think I redid the same
John> archaeology when adding the initial 'info proc' core dump bits for
John> FreeBSD. :)

I think a comment sounds helpful for future developers.

Tom