Re: [PATCH 4/5] Support 'info proc files' on live FreeBSD processes.

Simon Marchi
2018-09-08T23:01:08Z

On 2018-09-08 01:36 AM, John Baldwin wrote:
> This walks the list of struct kinfo_file objects returned by a call to
> kinfo_getfile outputting a description of each open file descriptor.

LGTM.

It would be nice to share the printing of the information between core
and live process, so that we can't forget to change one if we change the
other. But if there are some subtle differences between both loops that
would make sharing more annoying than anything, I don't mind.

Simon