Re: [patch] gdb/testsuite: Fix POSIX-isms in gdb.base/shell.exp

Sandra Loosemore
2020-06-26T22:22:51Z

On 6/26/20 1:08 AM, Eli Zaretskii wrote:
> [snip]
>
> Here's the patch I installed on the master branch:
>
> diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
> index 4b1a4c0..c591934 100644
> --- a/gdb/doc/ChangeLog
> +++ b/gdb/doc/ChangeLog
> @@ -1,3 +1,8 @@
> +2020-06-26 Eli Zaretskii <eliz@gnu.org>
> +
> + * gdb.texinfo (Shell Commands): More accurate description of use
> + of $SHELL. Reported by Sandra Loosemore <sandra@codesourcery.com>.
> +
> 2020-06-23 Andrew Burgess <andrew.burgess@embecosm.com>
>
> * gdb.texinfo (Maintenance Commands): Document new 'maint print
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 7f8c77a..fbe9f85 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -1451,9 +1451,10 @@
> @itemx !@var{command-string}
> Invoke a standard shell to execute @var{command-string}.
> Note that no space is needed between @code{!} and @var{command-string}.
> -If it exists, the environment variable @code{SHELL} determines which
> -shell to run. Otherwise @value{GDBN} uses the default shell
> -(@file{/bin/sh} on Unix systems, @file{COMMAND.COM} on MS-DOS, etc.).
> +On GNU and Unix systems, the environment variable @code{SHELL}, if it
> +exists, determines which shell to run. Otherwise @value{GDBN} uses
> +the default shell (@file{/bin/sh} on GNU and Unix systems,
> +@file{cmd.exe} on MS-Windows, @file{COMMAND.COM} on MS-DOS, etc.).
> @end table
>
> The utility @code{make} is often needed in development environments.
>

This looks fine to me -- thanks.

-Sandra