Re: [ping] Re: [patch] gdb/testsuite: Fix POSIX-isms in gdb.base/shell.exp

Simon Marchi
2020-07-16T02:42:02Z

On 2020-07-15 3:53 p.m., Sandra Loosemore wrote:
> Ping? I'd like to get this patch into the GDB 10 branch.
>
> https://sourceware.org/pipermail/gdb-patches/2020-June/169865.html
>
> On 6/24/20 7:35 PM, Sandra Loosemore wrote:
>> This patch fixes a group of failures in gdb.base/shell.exp on Windows
>> host due to assumptions that GDB is launching a POSIX-like shell.  On
>> Windows, we get CMD.EXE instead.
>>
>> There is a potential second group of failures on Windows host not
>> addressed by this patch, due to the dependence of some of these tests on
>> utilities like wc, sed, and grep.  These tests happen to work for me
>> because the test harness connects to the remote host using Cygwin ssh
>> and both GDB and CMD.EXE inherit the PATH setting from the parent Cygwin
>> shell.  I don't know if disabling those tests on Windows host too is
>> appropriate, or again if this is an instance of badly-designed tests
>> that could be rewritten to avoid those dependencies.  WDYT?
>>
>> -Sandra
>

The patch looks raisonnable to me... but Eli, as the de facto Windows specialist,
could you give your OK?

Simon