From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9825 invoked by alias); 17 Jul 2018 15:41:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9791 invoked by uid 89); 17 Jul 2018 15:41:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jul 2018 15:41:17 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w6HFfAPZ006809 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 17 Jul 2018 11:41:15 -0400 Received: by simark.ca (Postfix, from userid 112) id 747661EF28; Tue, 17 Jul 2018 11:41:10 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 25AE71E08D; Tue, 17 Jul 2018 11:41:10 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 17 Jul 2018 15:41:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 03/15] Remove parameters from start_psymtab_common In-Reply-To: <20180510222357.27332-4-tom@tromey.com> References: <20180510222357.27332-1-tom@tromey.com> <20180510222357.27332-4-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00520.txt.bz2 On 2018-05-10 18:23, Tom Tromey wrote: > start_psymtab_common takes references to the global_psymbols and > static_psymbols vectors, but it also has an objfile parameter. This > is redundant, so this patch simplifies the function by removing those > reference parameters. LGTM. Simon