From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id D0HLHn1K6mgafSkAWB0awg (envelope-from ) for ; Sat, 11 Oct 2025 08:15:57 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ZfLic5J3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 65F651E0B6; Sat, 11 Oct 2025 08:15:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E78A71E047 for ; Sat, 11 Oct 2025 08:15:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7DEDF385781A for ; Sat, 11 Oct 2025 12:15:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DEDF385781A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ZfLic5J3 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id CA35B385843F for ; Sat, 11 Oct 2025 12:15:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA35B385843F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA35B385843F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760184923; cv=none; b=Vz3EnGmjf0iRh1v9+ltrXq+nritDRHpsPwoHpFD/n3F6RY2NBqrsuM0ZhwFBpl+JCHoMBQXlU/TsP49RKGrgJqPhx+uX3FMj+P93Ayir/qhoQDg61adcjuNsgX8/2Bq4sEjIsXNu4Ox7St2eiKovxdnDkAuC+t1ucoB4gTX+/Vo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760184923; c=relaxed/simple; bh=yZ4hgKLSt3LpK7HTjhiaYd1zP9XaaP96rX1sNdg+3xI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=DC1Tf9bwj2FR5qh0CXD7x4BmYbaDtOr+2rUBfgRZGNwyGri4ruqVpeFNPsyIwmTrZzMFkOX/Df1qlf7n3k7XnanSWE3dXVSS2qcY4sn1gqxh7VWdlPWO9syoO+2HMkb1xF84ZAS1u66J4tUHWz6d5w9HydzIerIFYZ2EhpOFZMc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA35B385843F Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-46e37d6c21eso16389445e9.0 for ; Sat, 11 Oct 2025 05:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760184921; x=1760789721; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kIgSqVpyX4AQQhZH0W+2KJS5kHMIL0YI0c+t+y2IUak=; b=ZfLic5J38+7jlgh2K0p7E5p31RWgSOh5IH4zeEI1kFv+uZuPRVFYBZZuDruxMEoGif rcKOghS24UDg8ZF3q5fcwpi+AIwGX3WFiPhMdl2dLXKunSgdg67eBfk5sfWwHcD8q6N9 6EjIrQKHeD+a5Q1xpoa+ChfDeFq4pvXK/6waI6t+ZM1rPz0pg7L8c4BncXwP0LqHltR/ YPtoYoiiSa5XmqbiugF/7G000KBTZvpj7A0Vh8DsF3t60/M9iVOunmWnLaw7Wun2pyle u/X8qxUm0XCrh8xwRUhPZLHBzfGBBCSKRN5zuQVg6BAEZn0ApUTqKjz0ChCsEBY6Ga53 aRpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760184921; x=1760789721; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kIgSqVpyX4AQQhZH0W+2KJS5kHMIL0YI0c+t+y2IUak=; b=kPI4uoHQhG4YH+JN+r6YjwvbHXi05XTQ4EhmhX3BHyl91oxkdWQcrjyrIgNnMbg5Ds BTGLhAB2GqT+WKBaH0etUgA/VeTDU+zKKrfgDlLjRgajGrrL3b2WiEspbNCMB9nbHzRQ Fyk/ZgCGEcAkpCJPPJXkMuOS4NXU3Kg8ewlHIlMuRN38xI73OR0rbENPaJeODqWnHOHk hrOGkG9QgtGuSkOStBX2j2L97s9e/LKdl0pekUGCOXExeHqiHtBRFXegNdP2Q0T0WhSE 8/yrVI4P7KGMSUexx5oi9hKQYf5+AswigpUtCnfVi0yBGxJ0NylUfUd2zs0LL6M37ZM+ 62aQ== X-Forwarded-Encrypted: i=1; AJvYcCW8o1I7afKE2NbNXw+3MxedLivtcvUP2iZ4JI5PiY/q+we5kXLn3MAb89Lmo9aO0j1H7WmTC9jGv146zw==@sourceware.org X-Gm-Message-State: AOJu0YxM9oNHrgl/UuNVqfMd7iN6z8K/CFXWFSwup0ibcfOy6p/z0pmU 90a/5+FNmyJ2EqzFeJJPp/47ipwe36btTyXdzMD0YfSMf2bx54pv43MRAzJqoQ== X-Gm-Gg: ASbGncvvyCnO9DqeTs164CBCgVrhQVpqhwKsXa292BQPLFcCgU3AYVmtNw5qDy5pC7z W8aS7w4ZswoJdXkOvcmNYFqXmh8t3QtM0uaB+3zvNtIF0O5gwZGITpNTAR4EAyT4+CIgtRnMniO Xmcv86edpS0Ar6i1MmA9yA5jpJRIkQRLY2kXWpy67Mqqk4vVGFWOqgPpWUaIYyI3uZnoeXrHztu 0TeBtamfkyVWHDFpAjtih1/6F+3ryLomBLxbIcxBraYnxGu9WFgnXN8yuVL4KhmhsMPe9Y43vBm YAdxVjbup7pVzylFYlbcARzWzPWh92NqgOGMep+f00I4dowrlYFU4zYDadkL1iEQuU8uMhph3Gc EiPZlya7UoWWi5md7ATUyKDC2sZcgur4OTlUK3Gd6KfiROz3P/9RoLQ== X-Google-Smtp-Source: AGHT+IHYzyGHVylKK3JVlPZp5y0USNA/P75ArMrtzQP5JLFeJd3cfpwbSM8DFw0GhOYbSNkP3wVsyQ== X-Received: by 2002:a05:600c:3548:b0:45b:4a98:91cf with SMTP id 5b1f17b1804b1-46fa9aa24b3mr101776405e9.15.1760184921173; Sat, 11 Oct 2025 05:15:21 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce582abcsm8746855f8f.17.2025.10.11.05.15.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Oct 2025 05:15:20 -0700 (PDT) Message-ID: Date: Sat, 11 Oct 2025 13:15:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] gdb/aarch64: signal frame support for fpmr Content-Language: en-US To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20251007123132.26769-1-Ezra.Sitorus@arm.com> <20251007123132.26769-4-Ezra.Sitorus@arm.com> From: Luis In-Reply-To: <20251007123132.26769-4-Ezra.Sitorus@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 07/10/2025 13:31, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > Add support for FPMR in signal frames and restore contents of FPMR. > --- > Changes from v1->v2: > * Addressed comments/whitespace/formatting issues > > Ezra > > gdb/aarch64-linux-tdep.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c > index 10b44d978af..e905be40a8d 100644 > --- a/gdb/aarch64-linux-tdep.c > +++ b/gdb/aarch64-linux-tdep.c > @@ -167,6 +167,7 @@ > #define AARCH64_TPIDR2_MAGIC 0x54504902 > #define AARCH64_ZT_MAGIC 0x5a544e01 > #define AARCH64_GCS_MAGIC 0x47435300 > +#define AARCH64_FPMR_MAGIC 0x46504d52 > > /* Defines for the extra_context that follows an AARCH64_EXTRA_MAGIC. */ > #define AARCH64_EXTRA_DATAP_OFFSET 8 > @@ -213,6 +214,9 @@ > /* features_enabled value offset in the GCS signal frame context. */ > #define AARCH64_GCS_CONTEXT_FEATURES_ENABLED_OFFSET 16 > > +/* FPMR constants. */ > +#define AARCH64_FPMR_OFFSET 8 > + > /* Holds information about the signal frame. */ > struct aarch64_linux_sigframe > { > @@ -260,6 +264,12 @@ struct aarch64_linux_sigframe > uint64_t gcspr; > /* Flags indicating which GCS features are enabled for the thread. */ > uint64_t gcs_features_enabled; > + > + /* True if we have an FPMR entry in the signal context, false otherwise. */ > + bool fpmr_available = false; > + /* The Floating Point Mode Register. */ > + CORE_ADDR fpmr = 0; > + > }; > > /* Read an aarch64_ctx, returning the magic value, and setting *SIZE to the > @@ -576,6 +586,22 @@ aarch64_linux_read_signal_frame_info (const frame_info_ptr &this_frame, > section += size; > break; > } > + case AARCH64_FPMR_MAGIC: > + { > + gdb_byte buf[8]; > + if (target_read_memory (section + AARCH64_FPMR_OFFSET, > + buf, 8) != 0) > + { > + warning (_("Failed to read the FPMR section address from the" > + " signal frame context.")); > + section += size; > + break; > + } > + signal_frame.fpmr = extract_unsigned_integer (buf, 8, byte_order); > + signal_frame.fpmr_available = true; > + section += size; > + break; > + } > case AARCH64_EXTRA_MAGIC: > { > /* Extra is always the last valid section in reserved and points to > @@ -739,6 +765,13 @@ aarch64_linux_sigframe_init (const struct tramp_frame *self, > } > } > > + /* Handle FPMR. */ Sorry, missed this one. The above indentation is off. Please fix it. > + if (tdep->has_fpmr () && signal_frame.fpmr_available != 0) > + { > + trad_frame_set_reg_value (this_cache, tdep->fpmr_regnum, > + signal_frame.fpmr); > + } > +