From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gqNDLAP3mGIQ9AkAWB0awg (envelope-from ) for ; Thu, 02 Jun 2022 13:44:35 -0400 Received: by simark.ca (Postfix, from userid 112) id A41E61E221; Thu, 2 Jun 2022 13:44:35 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=NqHbEyae; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 31EA81E01D for ; Thu, 2 Jun 2022 13:44:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 980653954464 for ; Thu, 2 Jun 2022 17:44:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 980653954464 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1654191873; bh=ezaE3jLmZdjzy329/63ssxfEXanYEMfqpdez7azOMwM=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=NqHbEyae+FHBg3733vBESIRa/YiplDNI16t5iSPMk6Uctekyiqvy4r1zWmXbj48Bf cILUG+0U5+tXMjU4vaM49STwZmABQhrtihh6tUjdfeDOdwteB99udD9RaCSC8dLwJM TqwU3VsNs/BDE1n2IhfKkhu9Q+22jNCqYs+vF2/Q= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D87DE3858C51 for ; Thu, 2 Jun 2022 17:44:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D87DE3858C51 Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 67E801E01D; Thu, 2 Jun 2022 13:44:10 -0400 (EDT) Message-ID: Date: Thu, 2 Jun 2022 13:44:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH][gdb] Fix warning in foreach_arch selftests Content-Language: fr To: Tom de Vries , Pedro Alves , gdb-patches@sourceware.org References: <20220601104130.GA24730@delia.home> <45511000-6883-53f4-cec6-395cd0c5b216@palves.net> <066c8609-1458-725d-1ed6-7e8fbce04c0c@simark.ca> <59e73c8e-2ba5-c980-3369-02c3e53be21d@suse.de> In-Reply-To: <59e73c8e-2ba5-c980-3369-02c3e53be21d@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 6/2/22 11:44, Tom de Vries via Gdb-patches wrote: > On 6/1/22 21:08, Simon Marchi wrote: >> Hi Tom, >> >> This introduces some failures for me: >> >> Running selftest print_one_insn::A6.^M >> Self test failed: Cannot access memory at address 0x0^M > > Hi Simon, > > sorry for not catching this, I forgot to test with --enable-targets=all, I'll try to fix the default in my build scripts. > > I've done a new version of the existing patch (so it applies once the old one is reverted). > > Mainly because I realized that there's an easier way to handle the osabi none setting: > ... > @@ -68,6 +68,7 @@ foreach_arch_test_generator (const std::string &name, >            { >              struct gdbarch_info info; >              info.bfd_arch_info = bfd_scan_arch (arch); > +            info.osabi = GDB_OSABI_NONE; >              struct gdbarch *gdbarch = gdbarch_find_by_info (info); >              SELF_CHECK (gdbarch != NULL); >              function (gdbarch); > ... > > Currently regression testing, but at least fixes the ARC regression. It fixes the gdb.gdb/unittest.exp failure, but introduces: FAIL: gdb.arch/amd64-osabi.exp: arch=i386:x86-64: print sizeof (void*) FAIL: gdb.arch/amd64-osabi.exp: arch=i386:x86-64: print sizeof (long double) FAIL: gdb.arch/amd64-osabi.exp: arch=i386:x64-32: print sizeof (long double) Simon