From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82922 invoked by alias); 26 Mar 2019 14:56:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82037 invoked by uid 89); 26 Mar 2019 14:56:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:278, HContent-Transfer-Encoding:8bit X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Mar 2019 14:56:19 +0000 Received: from [172.16.0.89] (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 019DC1E478; Tue, 26 Mar 2019 10:56:16 -0400 (EDT) Subject: Re: FW: [PATCH 2/2] gdbserver: Add linux_get_hwcap To: Alan Hayward , "gdb-patches@sourceware.org" , nd References: <20190325120542.92123-1-alan.hayward@arm.com> <20190325120542.92123-2-alan.hayward@arm.com> <353e83d9-efb3-c485-9ae6-6fc0a1f54553@simark.ca> <57CEBD0C-44A5-48D1-8CEB-54584E1A1A21@arm.com> <59A457A2-F464-4A05-A471-700F066114AD@arm.com> From: Simon Marchi Message-ID: Date: Tue, 26 Mar 2019 14:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <59A457A2-F464-4A05-A471-700F066114AD@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-03/txt/msg00595.txt.bz2 On 2019-03-26 10:33 a.m., Alan Hayward wrote: > It’s within a is_elf64 check, so should always be 8. Ah, good point. >>> Updated patch below. Will push if you have no more comments. It LGTM, thanks for doing this! Simon