From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24202 invoked by alias); 20 Oct 2017 14:28:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24192 invoked by uid 89); 20 Oct 2017 14:28:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Providing, H*r:ip*15.20.77.5 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Oct 2017 14:28:47 +0000 Received: from ESESSHC014.ericsson.se (Unknown_Domain [153.88.183.60]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id AE.8F.03220.C180AE95; Fri, 20 Oct 2017 16:28:44 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.60) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 20 Oct 2017 16:28:43 +0200 Received: from [142.133.61.79] (192.75.88.130) by DB4PR07MB315.eurprd07.prod.outlook.com (2a01:111:e400:982f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Fri, 20 Oct 2017 14:28:41 +0000 Subject: Re: [PATCH V4] symlookup: improves symbol lookup when a file is specified. To: "Tedeschi, Walfred" , Simon Marchi CC: "palves@redhat.com" , "gdb-patches@sourceware.org" References: <1508317280-31265-1-git-send-email-walfred.tedeschi@intel.com> <327caaf3429595c07a29d455ea3ed6a0@polymtl.ca> From: Simon Marchi Message-ID: Date: Fri, 20 Oct 2017 14:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CY4PR04CA0033.namprd04.prod.outlook.com (2603:10b6:903:c6::19) To DB4PR07MB315.eurprd07.prod.outlook.com (2a01:111:e400:982f::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 22531bc2-f7c1-47bd-9c9d-08d517c6dd50 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603229);SRVR:DB4PR07MB315; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB315;3:1QGdP6KM2qurMtOYKbBeVAhwRl/5fs/YW4sbKuoaQ2SYL71rVJfcLSq90rlE2rj79ZueHjVP4fZk53QNAxo5tWSHmjtGLXXQNK9Vx6Jr7vOQP7CkXvx7dv0c4RoCIKprm06Tf01oBZARisRg4zZA9vhe0R3zOVfG5+3uMzkcIre+Quyos52sK6hhugVCdSZ5T7iV/zFsE85yU+qCQKCB8no6+OB1E3BfLOEU2xTCHihWf40Vxp4/vmduNf5L3mrc;25:2vxMfl5iQo5kgRloSgqjEdo0REgR+NQiY1WfmhBvsxFr5pbPOB/V7Z4clQtoiywMRy4UtcTbthuzrZ4aEk221wwIbpMKLaupKF1W75u5rr1ldG5jrZU3N4xEKe0k1WV7+Wux6ZnPqx72aULFTN8shb2GTzMh2prn8VL5/OBWdGtn7gqBAM2U1mNERZmUxEeMFrQn840cw9/RmRZwvOnoF4QIwicPzDe7CrTlOrPo6RCpNrRRTYN6rMe1e8atm6GAf8iggwglWBvx5YQXpozdybrsZeEkTQNHf7OTolWLLnWMImoouL75az9+EMm3ouXMbYJSXAh5P5P5QPR0Iwf9gnkjvPPMmktOX/ZcHZi+DC8=;31:6oEIED5PUnW84lNRgyIjN/nTkRMnWyHolhIPqakeCXUn4FSzH1w+JXI1fgGHjYyLWZ301npCRRv1Gl14azS3pzSRxwnVJQNZF68pwWk4jaUzHHfHYjbk89O4a4lFmrg/5bWdtXUc7FlSstLkuzCn0FU+RcIAlrBl/4hSRYn9wqPourZl9H9YcUTjg7GhkE/pyAfI/JsHvm66CfCz2zety/1gQCPL8EFze9ZFgCeuDow= X-MS-TrafficTypeDiagnostic: DB4PR07MB315: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB315;20:fLcaJYS/K/WWo1l0rGsbsiZ8h+V7pUM/IfoCtt4RCHgJpjpGoJQduV6ckJ0NaZf2GejsgLrOvuWeYeO+lhVidQQua6ey2hYl9Rc4FML0FmzbUDfU3PfUP1inCzaKm5zec5koiUCUN96Ikr5DNEyn1X0/JhG7/LE+XlVLSApsJctlkCKGv2ld/8G8V6i+e5P0x0oLNVnClGIOXcgVFdnu1VOX39VF04Ifcbs8FT/2+EMpLDfm4hv6M1Gz/UGCpqW8tq9GqRLjbt3CSOxKL9XitG54ARMAPrHnMXxD2IMPTV7U59j/XzPBwsKY/2F/uMHVRT9r9OaBwTGnHt/UbntlJMFBZ/nQWtq81TDpbxA1nzkG76dDOIRgcsQpKV0QH458szlU5VUeXIKEsxvGTjcAUJhybomjnSR8XUHYOPRawGCfWL7Oa07CFfaHG4/kDfd+LCtvgGPGDx1E1C5ANsV3wNRekzS87zc1h0Wy4PUQSxjaK9fXEKYj7VLxEEc+9bpk;4:X8YTbUu3PKq5x8FB/dUUstYTRVo6qPmNmoLqxQH1kXW6m/PUtajpfvlHl4SmMyAewvkP6ngrSIiT7xEDN2CEh5+hIOFXNbFcl/r99yrfIW2W2lCNYJUr6VxeQk9oWgx93wm+QRGjKXYouIWnytMYxjyVpb2ONO2/vAmEIX73FOeJrFohQddvvmhYkgKZ4DTANaXr9WmxL9L03rB5wBT3L4yrjPB8XaB000YVbT1yENbIumXF6W/9E2kIzJvxTrSi X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231020)(100000703101)(100105400095)(6041248)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB4PR07MB315;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB4PR07MB315; X-Forefront-PRVS: 0466CA5A45 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(346002)(39860400002)(24454002)(189002)(377424004)(43784003)(199003)(25786009)(6246003)(106356001)(230700001)(4326008)(31686004)(478600001)(101416001)(49976008)(81156014)(76176999)(50986999)(2906002)(6116002)(54356999)(105586002)(33646002)(86362001)(8676002)(316002)(31696002)(3846002)(97736004)(8936002)(4001150100001)(81166006)(53546010)(16526018)(5660300001)(65826007)(50466002)(36756003)(83506002)(189998001)(54906003)(305945005)(7736002)(16576012)(53936002)(58126008)(23676002)(68736007)(6666003)(229853002)(2950100002)(6486002)(110136005)(65956001)(64126003)(65806001)(47776003)(66066001)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB315;H:[142.133.61.79];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTU7MjM6SGxRL3BPSVg1cDhNQy8ycE1TN0k0QTlwL1dM?= =?utf-8?B?aDFKYXJnRFpGRWQ4TmpEdWt6S1B4UkY5QUw5d3o2S25zV29RaUwrOUlONk51?= =?utf-8?B?SHRReWRxaHBjVTYwT2RZK01SbnEvNkxDOWdmckk0TDJDeWhxZ3BHZCtUZ1h0?= =?utf-8?B?bjhCNHg4VUpWUU83WnJwM0N4bU5zUCtBWE9NbG9jaVAwQThCQXpvZ1dITGNj?= =?utf-8?B?ZVhrVXdCQ0RUU01odGlXVXFHRnFZb25xZEY5ZlJqUjZ3dS9ieXpaVC9pSkd4?= =?utf-8?B?WDFrZjVScjFDeW1UZm5INmhZbkVGTVpNQnFuTjVMeVB4akFHdTc5R0hNTERB?= =?utf-8?B?cmMwcWNrdUpQY2R6T2tqbHpRYndPbDhnVTZKTXN1NXg2dWdXS1JNSXM1M2hY?= =?utf-8?B?eXhNNFlEWDBHN25QNmQ5RWtLM29XOGM4cS81S0RPWkdjS0hTVkgxOU4xQ0M4?= =?utf-8?B?dUF5bHJqOExZenpZZGpCWHh0em43a0JlMnNidjhabzFqbm9jR3RWNzFlWmto?= =?utf-8?B?QUw4K3h5WkpzMGFjL1V5Z1dQdHdtaXA5TUZjcHBLcVpSd0ZMdEUxazJOS0dq?= =?utf-8?B?RGllK0dSMVlzb1hTTTlTTkRJZUZUb3pKTXZ3RGVlby9xMzMzb3RDMW1qZ1BG?= =?utf-8?B?dTkvRkw3RFlmZXRvbVhzelVybG94TEJTSm1xMkphNE1EYURESnAxU0ZTU0Nn?= =?utf-8?B?MDFZb3h2dWhBQUcvYkx2eUhiZWFGbHl5OGluMzNGZUk4Nnh0Lzdsb3NLWTQy?= =?utf-8?B?eDBEbkVXc3REc0Z3MGQrbzdsaVo2cUZPQmhaaGVkVytxbWlPcWt1T1YxdHVC?= =?utf-8?B?cU5rOEd2dEdBRGV5VEVobG5idFJDMFNwcXBIQlBZS3ZENFpKcnpQdEZ0dHJw?= =?utf-8?B?d3l2MCtNcWg2TVF5Zllub0x6bkpYZ3FkTzVsNm93TCtvUHB1S3o3dUp1Tzg4?= =?utf-8?B?S1pCMnNJc1U4R1kxMzJMUTZoQkhwbFNPN0dPYTY1Vk41bWE4Ykk1WkY5Wndy?= =?utf-8?B?TXBwNll4YjQzU1ROK3dpb3ovajR6NGZyTnJXYmc4ODRldlR1M0hDeHJHdjFW?= =?utf-8?B?Vm9Wd3ZaWTVBSWF2Q2ZOUUlpa2RmZmR1QWRubHh4djdpaDQwbk9tV1JPbkw4?= =?utf-8?B?S0l5SVRONmxSaHQ2VHdEdkxBRGsvZFZBdE0ybXJsZ0ZaeFQzSDdtbkV5ZndL?= =?utf-8?B?LzRrUElKaEFaQkY2RmxzZ2dWQVBVUGd6N08xYTBMV280YzRaZ2tLM2QzUlJW?= =?utf-8?B?c1B2NTg1d2xoUGtJdGJFdjB1ajVpMGtKRGZacTk1OUMzYmZObzRwTWlOS0ZO?= =?utf-8?B?NFlpK2d0cncwS2sxVzAwcXJET21yNHpQSDA0ZXowc1IvVWMzQkhJMmd6eTB2?= =?utf-8?B?VmlrZ2MxbEt2cHFoR0NBUVJITnUya2o4TngzTUFtZWJ0anoyOGhHd1FiVWJC?= =?utf-8?B?enNBWFVHVjNpaW56RHRNaTkxTSs4Yk40OS9oZkxqNUhaWU0yN3ZWNlQxOEUw?= =?utf-8?B?VnJZUEdNY3R0OGs2TnArbGNhQ0VFdWJDb2dDelI5dG9zcjJGcjFaQUVvUmov?= =?utf-8?B?S1BFUEY2YkNZamlTQ3ZrUFY0d0JhR0RlY3JSMWYvUXcvL3pXZkp6SzYrL1c4?= =?utf-8?B?TmRwMmpDQkZBVzRUZ056bjlCK2pMWFVNOVc0NkZjaDIyUUUrSWVOY0E4MURl?= =?utf-8?B?ZCtzWnArT28vRVE2elVPVEp5WTNhNTRrRjlQSmxZY2tLWjZ3R2lINXA2Mjg1?= =?utf-8?B?UUtQMlRKT1FJNS9WUVUyNDBqWXV5a1lLcVBra2tvZllJQmg2VWJiYVZmT214?= =?utf-8?B?RS9IdWhSSzRWUmozQktPZTMyeVdjTW4zdzhsRGhRY1NhTUhSYjJuQ0wyTnBm?= =?utf-8?B?c09jV0ZUYkpVYUhZWE00SDJwVmJOSUNkY2crZ1JrWWN3eHhjSnlKRSsxUU9B?= =?utf-8?B?ak5PazVuZnNVZVJmdDFxdjV6QVJtR1hZNjNjL2wzNUtVNHIvSkc1N2NDb0s2?= =?utf-8?Q?UOu9C?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB315;6:O3n8Xqs5rn+jRTi6a6cXc3/BYVkd6Kmvy1Y/PP2ndz+TxsjRPmHZEQQaOwEgq9pKVJfwHWfMItHnfH5LvKZRSPLkWTeU7OoomVJ2+U34tk8IkIZva7KdbHaLqkt4SUh4CvzWRXxmQVXTev1kM1UhqzxaTi0TcjVBWtl6sCNcdHTEoNZJtbBxStpa1CHeMj3LMpQbZDNM+iJqXkL2LO/dPdcInnPMdOK6WEIhmwjZ/aQQ6m5WCsGEZooWqJ2zShUgzULd1c9zpEfGLEdD7SugDX00k2cplzk/mjzOQCcXLkHvNNexfJjY8vnp3wXCY28YexpyappGxP22zLTVY62g5A==;5:5ZZBStZgY6lwXEbjFp4uObiH8Af8oGznhRuVlj+DjPkBrE0kAYQSMyZeCnxToYyEulU30jYLGyzVZWRNj58jKg3xxNJjXhzhVh0vnqG5pDgDqZ5Nm2Lv561qLfbhPKV2bLLc0G6XyyVpw2v0SEMhaQ==;24:g2czybo+xR5f/j9SqBv5H9TTNL66zrEPOO3Q1aU2OIyzUUFDfAq96hCaTxMBuoMzr/MLZcnZjfeCP5nvAtrwqsRuN+BC8qXuibIi5jSQ30M=;7:CIVWVFRPrdipGqs49xC2uzFWIbt5Jh9aTEXMP7oOg8k2oIiec9JiEQT52q12rpAmdu/Fwvm2FpvrDYv9eSnGDDuBUdSHC9/8vSPTlGpmoq7BzOFTZRBG+OqtUWamS8WZ/OTXWF2MVwfFBnmaZHTOXh9zhphOaWCMXa/bWayMREBwXv0D7rfn3aYYjS4R0FqhB+fXgbs3vvzo0BH82H2Cc3apNCC+DO8iFvqtnvGK6ng= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2017 14:28:41.4616 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB315 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00663.txt.bz2 On 2017-10-20 03:45 AM, Tedeschi, Walfred wrote: > Hi Simon, > > Thanks for your review! > For all the comment above I agree, Thanks again! > > For the one below there are different point of views. > How I see it: Very few sane people will add a symbols in a shared library that > will collide like the case we presented here. If one does so how can the debugger > help? I think one usual use case is plugins implemented with shared library. Although the data symbols will commonly be static, and the plugin will only expose some function symbols. > Providing the same value as the runtime or linker does? > This one user already knows. > Or providing what the debug information provides as value created by the library itself. > In final end both are right. :| > > But when specifying the scope if user is provided the value of the debug info it should > be easier to spot that there is something weird going on in the code. I think what you just said summarizes the problem well and I think it makes sense. I just don't think I have enough experience about symbol handling to understand the situation fully. Could another maintainer with more experience about symbols give the final ok? > That was my rationale. > > Perhaps, the debugger could here even provide a new command to analyze those colliding symbols. Yes, and maybe a way to print all symbols with a given name, with some info about where they come from. Simon