From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DbtdGUQcEGbJjCQAWB0awg (envelope-from ) for ; Fri, 05 Apr 2024 11:44:04 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UpKNBWfN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 566CD1E0C0; Fri, 5 Apr 2024 11:44:04 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1AC491E030 for ; Fri, 5 Apr 2024 11:44:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25FEF3846074 for ; Fri, 5 Apr 2024 15:44:01 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4C8703858C24 for ; Fri, 5 Apr 2024 15:43:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C8703858C24 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4C8703858C24 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712331824; cv=none; b=kW5E/V0/J4vzaXW6sfcdw22rwAwulgqr/swZNv2iII6t0/GEB6xBsNJQghj4uhJgBH7ZYCEKpe61cuHI4dHnv67YiDVALrqdjeCC+T4eNbXCSwDbVKc7kqNfyVpsHMXFIdj4VbJGXOinX01/DCld82NBxmk8ns+XzcuXWaT6OS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712331824; c=relaxed/simple; bh=sOL8zk472iaUweLngPC1BfnGXSZoMzpjUglUh8MI6Ws=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ueEikgedhjb+GqFuFm3rCmyJHtnhDL6pz7hw63SORx0zYVIis8kQQHg7c1ha8EXBc1Gdy9SchDY0rn30WnvQoSa5K1ijyAG/Xw+jZknkHlNIbdnwIXTEo22ToruYNM0n2o1a9PxpLh7X4fVTr8Qx2Ln/l9tWVscOoZKldnFAA5A= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712331819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w11hkGO5M+oZ1ujWb4fDeD3Fdi42Da8UewY2bqRX+bg=; b=UpKNBWfNR4ENsqOLd6u4yxm1w4vo7b4GDcITFjHvwFPiw9a9CswssLJKDFIfuot0ativ/n ih+6o43tOGT23+/D9ZUG75SKzHUO7ROCZTJJyLYwYpHxV2mg073G1mwg0gtWWV818w4YV/ QK0d2svfVzBqSJPn4w3bjYbOOsYOxK4= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-DpzV8ZIsM82Q03lchdnefw-1; Fri, 05 Apr 2024 11:43:37 -0400 X-MC-Unique: DpzV8ZIsM82Q03lchdnefw-1 Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-6e68ce1602fso2634491a34.3 for ; Fri, 05 Apr 2024 08:43:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712331816; x=1712936616; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=w11hkGO5M+oZ1ujWb4fDeD3Fdi42Da8UewY2bqRX+bg=; b=UwCMBICepVhf0luWi3MWlmU7K19hkaQOddRHVxapB6al36Rqy5oyhNHlLIrjCyOvJk kfVaJifQ4B/l1nl9d15DPHNKvqHG6/2g7JrHjjdiHTjZojvgkEe/HEo1exDUMrCT3foX Bs6lqakOBMxtT41/WC3GQw9+SWuzuYsGBa4kqEMeMIpnUAAQEOOY4mwI8Avt4XyPTTz3 IFv0vsYpIfwLoggvhQHDYdkvaO60wxZEZ6cL3mhdhdCheh7xjKX1rxrP2j/xO/6w06DY Lbxy5SevvTVRWpzOdrdRVqWZW/3ieRN3jpNpxykQep78UngNF+WAqAV7UACcuCOrYBb1 WIcw== X-Forwarded-Encrypted: i=1; AJvYcCU/BIk5x2c9yeo98s86KTt5JuXwmbkvTCXrKjd9Se+eKTvfpjU38i37EJH1K0fzHsothCpZoguhzadBIVtJYMyIcDWGfOIqJBS4WQ== X-Gm-Message-State: AOJu0YyRtTmLgD+lfUFZrngDGG028mj9bdCr12MkQWehWn07WLHRp8DN K7L+vmHl5HZFBKc+KSM5EuouXtiS3oR46E6EEknPZbjLyx93vUhkHue+1fXrY+D+7nW4NW9Qt/N cUjjQVakC0wr7ASAoT3khU4gioVB3P7SHCIHNTJECDPVtL2A2Ys3/vKwl1QM= X-Received: by 2002:a9d:6d05:0:b0:6e6:9783:bba9 with SMTP id o5-20020a9d6d05000000b006e69783bba9mr1947424otp.22.1712331816663; Fri, 05 Apr 2024 08:43:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJgns3EGCvo08KmUGjctOMVfQ3LA0fz0vDrrm67suM5rL2WEv5aq6DOPkt5MUhSgZOxoDKKg== X-Received: by 2002:a9d:6d05:0:b0:6e6:9783:bba9 with SMTP id o5-20020a9d6d05000000b006e69783bba9mr1947410otp.22.1712331816217; Fri, 05 Apr 2024 08:43:36 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1002? ([2804:14d:8084:92c5::1002]) by smtp.gmail.com with ESMTPSA id v10-20020a05622a014a00b0043445214fddsm854594qtw.51.2024.04.05.08.43.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 08:43:35 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 12:43:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Change message when reaching end of reverse history. To: "Metzger, Markus T" , Alex Chronopoulos Cc: Eli Zaretskii , "gdb-patches@sourceware.org" References: <20240313204830.2521708-1-achronop@gmail.com> <50e7e7f5-024b-4ac8-be5c-948ad2f41e73@redhat.com> <8634s18vdh.fsf@gnu.org> <7d497864-4bef-4f95-bab5-1bf9cbee7000@redhat.com> <86le5t7151.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------SbE0ys3YZ1I2zyJf5Q4Z8SVm" Content-Language: en-US X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_WEB, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------SbE0ys3YZ1I2zyJf5Q4Z8SVm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I think it would be good to have an indication for MI too, but I don't think it has to be tied to the acceptance of this patch due to the difference in how MI reports (only saying 'reason: no-history'). Once this patch is in, I'll open a bug where we can discuss how to do it. -- Cheers, Guinevere Larsen She/Her/Hers On 4/5/24 02:18, Metzger, Markus T wrote: > > Looks good to me, too.  Please make sure to update tests that check > for the old string. > > That leaves the question whether we need an indication for MI, too. > > Regards, > > Markus. > > *From:* Alex Chronopoulos > *Sent:* Thursday, April 4, 2024 9:55 PM > *To:* Guinevere Larsen > *Cc:* Eli Zaretskii ; Metzger, Markus T > ; gdb-patches@sourceware.org > *Subject:* Re: [PATCH] Change message when reaching end of reverse > history. > > Absolutely, thank you both. > > My understanding is that the backward message remains the same. If not > let me know. Otherwise will update the patch. > > On Thu, Apr 4, 2024, 19:26 Guinevere Larsen wrote: > > On 4/4/24 09:39, Eli Zaretskii wrote: > >> Date: Thu, 4 Apr 2024 09:16:46 -0300 > >> Cc: gdb-patches@sourceware.org, achronop@gmail.com > >> From: Guinevere Larsen > >> > >>> If the above makes no sense, would someone please explain in more > >>> detail what was the original issue, and I will try to come up > with a > >>> better suggestion. > >>> > >> The original issue is that when a user is in replay mode going > forward, > >> and they hit the message "no more reverse-execution history", some > >> interpret that message as 'you can no longer execute forward' > instead of > >> the intended 'if you continue executing, we will do new things and > >> record them, instead of just replaying what was already done'. > > Then how about this instead: > > > >    End of recorded history; following steps will be added to > history. > > > Sounds good to me. Markus, Alex, do you agree? > > -- > Cheers, > Guinevere Larsen > She/Her/Hers > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 > --------------SbE0ys3YZ1I2zyJf5Q4Z8SVm Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
I think it would be good to have an indication for MI too, but I don't think it has to be tied to the acceptance of this patch due to the difference in how MI reports (only saying 'reason: no-history'). Once this patch is in, I'll open a bug where we can discuss how to do it.
-- 
Cheers,
Guinevere Larsen
She/Her/Hers
On 4/5/24 02:18, Metzger, Markus T wrote:

Looks good to me, too.  Please make sure to update tests that check for the old string.

 

That leaves the question whether we need an indication for MI, too.

 

Regards,

Markus.

 

From: Alex Chronopoulos <achronop@gmail.com>
Sent: Thursday, April 4, 2024 9:55 PM
To: Guinevere Larsen <blarsen@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>; Metzger, Markus T <markus.t.metzger@intel.com>; gdb-patches@sourceware.org
Subject: Re: [PATCH] Change message when reaching end of reverse history.

 

Absolutely, thank you both.

 

My understanding is that the backward message remains the same. If not let me know. Otherwise will update the patch.

 

On Thu, Apr 4, 2024, 19:26 Guinevere Larsen <blarsen@redhat.com> wrote:

On 4/4/24 09:39, Eli Zaretskii wrote:
>> Date: Thu, 4 Apr 2024 09:16:46 -0300
>> Cc: gdb-patches@sourceware.org, achronop@gmail.com
>> From: Guinevere Larsen <blarsen@redhat.com>
>>
>>> If the above makes no sense, would someone please explain in more
>>> detail what was the original issue, and I will try to come up with a
>>> better suggestion.
>>>
>> The original issue is that when a user is in replay mode going forward,
>> and they hit the message "no more reverse-execution history", some
>> interpret that message as 'you can no longer execute forward' instead of
>> the intended 'if you continue executing, we will do new things and
>> record them, instead of just replaying what was already done'.
> Then how about this instead:
>
>    End of recorded history; following steps will be added to history.
>
Sounds good to me. Markus, Alex, do you agree?

--
Cheers,
Guinevere Larsen
She/Her/Hers

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

--------------SbE0ys3YZ1I2zyJf5Q4Z8SVm--