I think it would be good to have an indication for MI too, but I don't think it has to be tied to the acceptance of this patch due to the difference in how MI reports (only saying 'reason: no-history'). Once this patch is in, I'll open a bug where we can discuss how to do it. -- Cheers, Guinevere Larsen She/Her/Hers On 4/5/24 02:18, Metzger, Markus T wrote: > > Looks good to me, too.  Please make sure to update tests that check > for the old string. > > That leaves the question whether we need an indication for MI, too. > > Regards, > > Markus. > > *From:* Alex Chronopoulos > *Sent:* Thursday, April 4, 2024 9:55 PM > *To:* Guinevere Larsen > *Cc:* Eli Zaretskii ; Metzger, Markus T > ; gdb-patches@sourceware.org > *Subject:* Re: [PATCH] Change message when reaching end of reverse > history. > > Absolutely, thank you both. > > My understanding is that the backward message remains the same. If not > let me know. Otherwise will update the patch. > > On Thu, Apr 4, 2024, 19:26 Guinevere Larsen wrote: > > On 4/4/24 09:39, Eli Zaretskii wrote: > >> Date: Thu, 4 Apr 2024 09:16:46 -0300 > >> Cc: gdb-patches@sourceware.org, achronop@gmail.com > >> From: Guinevere Larsen > >> > >>> If the above makes no sense, would someone please explain in more > >>> detail what was the original issue, and I will try to come up > with a > >>> better suggestion. > >>> > >> The original issue is that when a user is in replay mode going > forward, > >> and they hit the message "no more reverse-execution history", some > >> interpret that message as 'you can no longer execute forward' > instead of > >> the intended 'if you continue executing, we will do new things and > >> record them, instead of just replaying what was already done'. > > Then how about this instead: > > > >    End of recorded history; following steps will be added to > history. > > > Sounds good to me. Markus, Alex, do you agree? > > -- > Cheers, > Guinevere Larsen > She/Her/Hers > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 >