From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qDr0MmlzZGDHCQAAWB0awg (envelope-from ) for ; Wed, 31 Mar 2021 09:04:41 -0400 Received: by simark.ca (Postfix, from userid 112) id C3E511EE14; Wed, 31 Mar 2021 09:04:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BE1041E590 for ; Wed, 31 Mar 2021 09:04:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7AF1F3858031; Wed, 31 Mar 2021 13:04:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7AF1F3858031 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617195880; bh=39eA1xEf+wuMjmgP6oBeLmejh+113euOPPAIjXaJcH0=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=DOfJVv48UbkgiWWLT0ANMhojFDDH3XZEZLSHerB8bQlB/KxqnNy/oDUoj42J9FlZG t3Y3/434IhqF+tVTwUp//TbLX08coLSPEtFKlcRFtNwtcQwtzD4f9s7b/fUdpNMa9a q3Ekj8T+bIrvcerxiSye8Aj5D+pUU8qN9ZXZGUNA= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id F1B093858012 for ; Wed, 31 Mar 2021 13:04:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F1B093858012 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12VD4Wks030304 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Mar 2021 09:04:37 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12VD4Wks030304 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 581101E590; Wed, 31 Mar 2021 09:04:32 -0400 (EDT) Subject: Re: [PATCH][gdb/testsuite] Ignore DEBUGINFOD_URLS To: Tom de Vries , gdb-patches@sourceware.org References: <20210331123331.GA3054@delia> Message-ID: Date: Wed, 31 Mar 2021 09:04:32 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210331123331.GA3054@delia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 31 Mar 2021 13:04:32 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-03-31 8:33 a.m., Tom de Vries wrote:> Hi, > > On openSUSE Tumbleweed, DEBUGINFOD_URLS is now defined by default: > ... > $ echo $DEBUGINFOD_URLS > https://debuginfod.opensuse.org/ > ... > > With DEBUGINFOD_URLS defined we run into: > ... > FAIL: gdb.mi/mi-sym-info.exp: List all functions from debug information only \ > (timeout) > ... > as reported in PR27667. > > There's a latency of ~0.5s per request, which is ok-ish for interactive usage. > But the symbol-info-functions command ends up issuing 21 source requests, > which means we easily run into the 10s timeout. > > Fix this by unsetting DEBUGINFOD_URLS in default_gdb_init. > > Any comments? > > Thanks, > - Tom > > [gdb/testsuite] Ignore DEBUGINFOD_URLS > > gdb/testsuite/ChangeLog: > > 2021-03-31 Tom de Vries > > PR testsuite/27667 > * lib/gdb.exp (default_gdb_init): Unset DEBUGINFOD_URLS. > > --- > gdb/testsuite/lib/gdb.exp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 73fea3a104d..d18aec648d9 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -5270,6 +5270,10 @@ proc default_gdb_init { test_file_name } { > # tests. > setenv TERM "dumb" > > + # If DEBUGINFOD_URLS is set, gdb will try to download sources and > + # debug info for f.i. system libraries. Prevent this. > + unsetenv DEBUGINFOD_URLS > + > # Ensure that GDBHISTFILE and GDBHISTSIZE are removed from the > # environment, we don't want these modifications to the history > # settings. > I think this is OK, we want to reduce external influence on the tests as much as possible. However, I could imagine we could have a "debuginfod" board file, which runs all tests with a controlled debuginfod server it spawns itself, and it would set DEBUGINFOD_URLS accordingly. It could override gdb_compile to feed all compiled binaries to the debuginfod server, something like that. Simon